* [PATCH 0/1] pseudo (1.4.5) -- this time for sure
@ 2013-02-13 20:20 Peter Seebach
2013-02-13 20:20 ` [PATCH 1/1] pseudo_1.4.5.bb: Finish fixing linkat() Peter Seebach
0 siblings, 1 reply; 2+ messages in thread
From: Peter Seebach @ 2013-02-13 20:20 UTC (permalink / raw)
To: openembedded-core
The question of how many copies of the chroot path should be prepended
to paths when calling link() is a challenging one, but after flirtations
with 2 (pseudo 1.4.3) and 0 (pseudo 1.4.4) I think I've settled on a
reasonable compromise at 1.
The underlying logic bug was an under-considered attempt to avoid
doing path expansions before calling a *at() function, which might help
with relative paths, but doesn't work with a chroot directory. In
fact, since we're fully expanding paths (including any fd-relative
paths), there's not even areason to use the linkat() syscall to implement
this.
Retested, and verified against the following trivial test case:
#include <unistd.h>
#include <stdio.h>
#include <fcntl.h>
#include <string.h>
#include <errno.h>
int
main(void) {
int rc;
chdir("/home/seebs/pseudo/r");
chroot("/home/seebs/pseudo/r");
rc = link("/a", "/b");
printf("%d: %d [%s]\n", rc, errno, strerror(errno));
return 0;
}
I am informed that pseudo 1.4.5.tar.bz2 is in the Yocto project download
area already.
Sorry for the trouble!
The following changes since commit bbcd8b344598850ea2c8d3ad375c519713581fde:
Chen Qi (1):
busybox: add config fragments
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/pseudo145
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/pseudo145
Peter Seebach (1):
pseudo_1.4.5.bb: Finish fixing linkat()
.../pseudo/{pseudo_1.4.4.bb => pseudo_1.4.5.bb} | 4 ++--
meta/recipes-devtools/pseudo/pseudo_git.bb | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
rename meta/recipes-devtools/pseudo/{pseudo_1.4.4.bb => pseudo_1.4.5.bb} (43%)
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH 1/1] pseudo_1.4.5.bb: Finish fixing linkat()
2013-02-13 20:20 [PATCH 0/1] pseudo (1.4.5) -- this time for sure Peter Seebach
@ 2013-02-13 20:20 ` Peter Seebach
0 siblings, 0 replies; 2+ messages in thread
From: Peter Seebach @ 2013-02-13 20:20 UTC (permalink / raw)
To: openembedded-core
The 1.4.4 fix replaced possible double-prepending of chroot paths
with possible non-prepending of chroot paths. After significant
evaluation, have settled on a single prepending of the chroot
path as a workable compromise.
Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
---
.../pseudo/{pseudo_1.4.4.bb => pseudo_1.4.5.bb} | 4 ++--
meta/recipes-devtools/pseudo/pseudo_git.bb | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
rename meta/recipes-devtools/pseudo/{pseudo_1.4.4.bb => pseudo_1.4.5.bb} (43%)
diff --git a/meta/recipes-devtools/pseudo/pseudo_1.4.4.bb b/meta/recipes-devtools/pseudo/pseudo_1.4.5.bb
similarity index 43%
rename from meta/recipes-devtools/pseudo/pseudo_1.4.4.bb
rename to meta/recipes-devtools/pseudo/pseudo_1.4.5.bb
index dea607c..e99974f 100644
--- a/meta/recipes-devtools/pseudo/pseudo_1.4.4.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_1.4.5.bb
@@ -4,5 +4,5 @@ PR = "r0"
SRC_URI = "http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2"
-SRC_URI[md5sum] = "ae18a1388c032ac910adbf8c3111fdc4"
-SRC_URI[sha256sum] = "e72cb188fd8efb9eadfb5ce571a45a99245ae312eb9830cb9a9726bb25e47c17"
+SRC_URI[md5sum] = "1b8677f7730bd4c51daab7727c35123e"
+SRC_URI[sha256sum] = "e36360e4899467ac842fece894177cb50207671a90e0567ffc74c144fa377f51"
diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb b/meta/recipes-devtools/pseudo/pseudo_git.bb
index efffc95..b895d2f 100644
--- a/meta/recipes-devtools/pseudo/pseudo_git.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
@@ -1,7 +1,7 @@
require pseudo.inc
-SRCREV = "363a94bb851046f62648d7c96c749e899bd0648e"
-PV = "1.4.4+git${SRCPV}"
+SRCREV = "011b401fb6be38d739215e455588af4dcd707e17"
+PV = "1.4.5+git${SRCPV}"
PR = "r0"
DEFAULT_PREFERENCE = "-1"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-13 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-13 20:20 [PATCH 0/1] pseudo (1.4.5) -- this time for sure Peter Seebach
2013-02-13 20:20 ` [PATCH 1/1] pseudo_1.4.5.bb: Finish fixing linkat() Peter Seebach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.