* [PATCH 1/6] ACPICA: Comment update
2013-07-17 1:47 [PATCH 0/6] ACPICA 20130626 Release Lv Zheng
@ 2013-07-17 1:48 ` Lv Zheng
2013-07-17 1:48 ` [PATCH 2/6] ACPICA: TableManager: Export acpi_tb_scan_memory_for_rsdp() Lv Zheng
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Lv Zheng @ 2013-07-17 1:48 UTC (permalink / raw)
To: Rafael J. Wysocki, Robert Moore, Len Brown; +Cc: Lv Zheng, linux-acpi
From: Bob Moore <robert.moore@intel.com>
No functional change. Add some comments concerning behavior
when the _STA method does not exist. According to the ACPI
specification, in this case the device should be assumed to be
present, functional, and enabled.
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Acked-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/acpica/nsxfname.c | 7 ++++++-
drivers/acpi/acpica/uteval.c | 8 +++++++-
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/nsxfname.c b/drivers/acpi/acpica/nsxfname.c
index f3a4d95..21a2ef3 100644
--- a/drivers/acpi/acpica/nsxfname.c
+++ b/drivers/acpi/acpica/nsxfname.c
@@ -379,9 +379,14 @@ acpi_get_object_info(acpi_handle handle,
* Get extra info for ACPI Device/Processor objects only:
* Run the _STA, _ADR and, sx_w, and _sx_d methods.
*
- * Note: none of these methods are required, so they may or may
+ * Notes: none of these methods are required, so they may or may
* not be present for this device. The Info->Valid bitfield is used
* to indicate which methods were found and run successfully.
+ *
+ * For _STA, if the method does not exist, then (as per the ACPI
+ * specification), the returned current_status flags will indicate
+ * that the device is present/functional/enabled. Otherwise, the
+ * current_status flags reflect the value returned from _STA.
*/
/* Execute the Device._STA method */
diff --git a/drivers/acpi/acpica/uteval.c b/drivers/acpi/acpica/uteval.c
index ee83adb..4fd6897 100644
--- a/drivers/acpi/acpica/uteval.c
+++ b/drivers/acpi/acpica/uteval.c
@@ -239,7 +239,8 @@ acpi_ut_evaluate_numeric_object(char *object_name,
* RETURN: Status
*
* DESCRIPTION: Executes _STA for selected device and stores results in
- * *Flags.
+ * *Flags. If _STA does not exist, then the device is assumed
+ * to be present/functional/enabled (as per the ACPI spec).
*
* NOTE: Internal function, no parameter validation
*
@@ -257,6 +258,11 @@ acpi_ut_execute_STA(struct acpi_namespace_node *device_node, u32 * flags)
ACPI_BTYPE_INTEGER, &obj_desc);
if (ACPI_FAILURE(status)) {
if (AE_NOT_FOUND == status) {
+ /*
+ * if _STA does not exist, then (as per the ACPI specification),
+ * the returned flags will indicate that the device is present,
+ * functional, and enabled.
+ */
ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
"_STA on %4.4s was not found, assuming device is present\n",
acpi_ut_get_node_name(device_node)));
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/6] ACPICA: TableManager: Export acpi_tb_scan_memory_for_rsdp()
2013-07-17 1:47 [PATCH 0/6] ACPICA 20130626 Release Lv Zheng
2013-07-17 1:48 ` [PATCH 1/6] ACPICA: Comment update Lv Zheng
@ 2013-07-17 1:48 ` Lv Zheng
2013-07-17 1:48 ` [PATCH 3/6] ACPICA: Disassembler: Expand maximum output string length to 64K Lv Zheng
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Lv Zheng @ 2013-07-17 1:48 UTC (permalink / raw)
To: Rafael J. Wysocki, Robert Moore, Len Brown; +Cc: Lv Zheng, linux-acpi
From: Bob Moore <robert.moore@intel.com>
This patch exports this function to be used by other ACPICA utilities.
Chao Guan, Bob Moore.
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Acked-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/acpica/actables.h | 5 +++++
drivers/acpi/acpica/tbxfroot.c | 4 +---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/acpica/actables.h b/drivers/acpi/acpica/actables.h
index 7755e91..917315e 100644
--- a/drivers/acpi/acpica/actables.h
+++ b/drivers/acpi/acpica/actables.h
@@ -47,6 +47,11 @@
acpi_status acpi_allocate_root_table(u32 initial_table_count);
/*
+ * tbxfroot - Root pointer utilities
+ */
+u8 *acpi_tb_scan_memory_for_rsdp(u8 *start_address, u32 length);
+
+/*
* tbfadt - FADT parse/convert/validate
*/
void acpi_tb_parse_fadt(u32 table_index);
diff --git a/drivers/acpi/acpica/tbxfroot.c b/drivers/acpi/acpica/tbxfroot.c
index 7c2ecfb..e76ed0f 100644
--- a/drivers/acpi/acpica/tbxfroot.c
+++ b/drivers/acpi/acpica/tbxfroot.c
@@ -49,8 +49,6 @@
ACPI_MODULE_NAME("tbxfroot")
/* Local prototypes */
-static u8 *acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length);
-
static acpi_status acpi_tb_validate_rsdp(struct acpi_table_rsdp *rsdp);
/*******************************************************************************
@@ -231,7 +229,7 @@ acpi_status acpi_find_root_pointer(acpi_size *table_address)
* DESCRIPTION: Search a block of memory for the RSDP signature
*
******************************************************************************/
-static u8 *acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length)
+u8 *acpi_tb_scan_memory_for_rsdp(u8 *start_address, u32 length)
{
acpi_status status;
u8 *mem_rover;
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/6] ACPICA: Disassembler: Expand maximum output string length to 64K
2013-07-17 1:47 [PATCH 0/6] ACPICA 20130626 Release Lv Zheng
2013-07-17 1:48 ` [PATCH 1/6] ACPICA: Comment update Lv Zheng
2013-07-17 1:48 ` [PATCH 2/6] ACPICA: TableManager: Export acpi_tb_scan_memory_for_rsdp() Lv Zheng
@ 2013-07-17 1:48 ` Lv Zheng
2013-07-17 1:48 ` [PATCH 4/6] ACPICA: Remove restriction of 256 maximum GPEs in any GPE block Lv Zheng
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Lv Zheng @ 2013-07-17 1:48 UTC (permalink / raw)
To: Rafael J. Wysocki, Robert Moore, Len Brown; +Cc: Lv Zheng, linux-acpi
From: Bob Moore <robert.moore@intel.com>
Was 256 bytes max. The original purpose of this constraint was to
limit the amount of debug output. However, the string function in
question (UtPrintString) is now used for the disassembler also,
where 256 bytes is insufficient. Reported by RehabMan@GitHub.
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Acked-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/acpica/acutils.h | 2 +-
drivers/acpi/acpica/utstring.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/acpica/acutils.h b/drivers/acpi/acpica/acutils.h
index 3c76ede..4c081c4 100644
--- a/drivers/acpi/acpica/acutils.h
+++ b/drivers/acpi/acpica/acutils.h
@@ -616,7 +616,7 @@ int acpi_ut_stricmp(char *string1, char *string2);
acpi_status acpi_ut_strtoul64(char *string, u32 base, u64 *ret_integer);
-void acpi_ut_print_string(char *string, u8 max_length);
+void acpi_ut_print_string(char *string, u16 max_length);
void ut_convert_backslashes(char *pathname);
diff --git a/drivers/acpi/acpica/utstring.c b/drivers/acpi/acpica/utstring.c
index c53759b..cb1e9cc 100644
--- a/drivers/acpi/acpica/utstring.c
+++ b/drivers/acpi/acpica/utstring.c
@@ -333,7 +333,8 @@ acpi_status acpi_ut_strtoul64(char *string, u32 base, u64 *ret_integer)
* FUNCTION: acpi_ut_print_string
*
* PARAMETERS: string - Null terminated ASCII string
- * max_length - Maximum output length
+ * max_length - Maximum output length. Used to constrain the
+ * length of strings during debug output only.
*
* RETURN: None
*
@@ -342,7 +343,7 @@ acpi_status acpi_ut_strtoul64(char *string, u32 base, u64 *ret_integer)
*
******************************************************************************/
-void acpi_ut_print_string(char *string, u8 max_length)
+void acpi_ut_print_string(char *string, u16 max_length)
{
u32 i;
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 4/6] ACPICA: Remove restriction of 256 maximum GPEs in any GPE block
2013-07-17 1:47 [PATCH 0/6] ACPICA 20130626 Release Lv Zheng
` (2 preceding siblings ...)
2013-07-17 1:48 ` [PATCH 3/6] ACPICA: Disassembler: Expand maximum output string length to 64K Lv Zheng
@ 2013-07-17 1:48 ` Lv Zheng
2013-07-17 1:48 ` [PATCH 5/6] ACPICA: Fix compiler warnings for casting issues (only some compilers) Lv Zheng
2013-07-17 1:49 ` [PATCH 6/6] ACPICA: Update version to 20130626 Lv Zheng
5 siblings, 0 replies; 7+ messages in thread
From: Lv Zheng @ 2013-07-17 1:48 UTC (permalink / raw)
To: Rafael J. Wysocki, Robert Moore, Len Brown; +Cc: Lv Zheng, linux-acpi
From: Bob Moore <robert.moore@intel.com>
The FADT can support over 1000 GPEs, so remove any restriction
on the GPE numbers.
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Acked-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/acpica/evgpeinit.c | 11 -----------
include/acpi/actypes.h | 7 -------
2 files changed, 18 deletions(-)
diff --git a/drivers/acpi/acpica/evgpeinit.c b/drivers/acpi/acpica/evgpeinit.c
index 9037f17..7842700 100644
--- a/drivers/acpi/acpica/evgpeinit.c
+++ b/drivers/acpi/acpica/evgpeinit.c
@@ -125,7 +125,6 @@ acpi_status acpi_ev_gpe_initialize(void)
/* GPE block 0 exists (has both length and address > 0) */
register_count0 = (u16)(acpi_gbl_FADT.gpe0_block_length / 2);
-
gpe_number_max =
(register_count0 * ACPI_GPE_REGISTER_WIDTH) - 1;
@@ -204,16 +203,6 @@ acpi_status acpi_ev_gpe_initialize(void)
goto cleanup;
}
- /* Check for Max GPE number out-of-range */
-
- if (gpe_number_max > ACPI_GPE_MAX) {
- ACPI_ERROR((AE_INFO,
- "Maximum GPE number from FADT is too large: 0x%X",
- gpe_number_max));
- status = AE_BAD_VALUE;
- goto cleanup;
- }
-
cleanup:
(void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
return_ACPI_STATUS(AE_OK);
diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
index a64adcc..3433d2c 100644
--- a/include/acpi/actypes.h
+++ b/include/acpi/actypes.h
@@ -668,13 +668,6 @@ typedef u32 acpi_event_status;
#define ACPI_EVENT_FLAG_SET (acpi_event_status) 0x04
#define ACPI_EVENT_FLAG_HANDLE (acpi_event_status) 0x08
-/*
- * General Purpose Events (GPE)
- */
-#define ACPI_GPE_INVALID 0xFF
-#define ACPI_GPE_MAX 0xFF
-#define ACPI_NUM_GPE 256
-
/* Actions for acpi_set_gpe, acpi_gpe_wakeup, acpi_hw_low_set_gpe */
#define ACPI_GPE_ENABLE 0
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 5/6] ACPICA: Fix compiler warnings for casting issues (only some compilers)
2013-07-17 1:47 [PATCH 0/6] ACPICA 20130626 Release Lv Zheng
` (3 preceding siblings ...)
2013-07-17 1:48 ` [PATCH 4/6] ACPICA: Remove restriction of 256 maximum GPEs in any GPE block Lv Zheng
@ 2013-07-17 1:48 ` Lv Zheng
2013-07-17 1:49 ` [PATCH 6/6] ACPICA: Update version to 20130626 Lv Zheng
5 siblings, 0 replies; 7+ messages in thread
From: Lv Zheng @ 2013-07-17 1:48 UTC (permalink / raw)
To: Rafael J. Wysocki, Robert Moore, Len Brown
Cc: Lv Zheng, linux-acpi, Jung-uk Kim
From: Jung-uk Kim <jkim@FreeBSD.org>
Fixes compiler warnings from GCC 4.2 and perhaps other compilers.
Jung-uk Kim <jkim@FreeBSD.org>
Signed-off-by: Jung-uk Kim <jkim@FreeBSD.org>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Acked-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/acpica/exdump.c | 6 +++---
drivers/acpi/acpica/nsxfname.c | 4 +++-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
index c740f24..4d046fa 100644
--- a/drivers/acpi/acpica/exdump.c
+++ b/drivers/acpi/acpica/exdump.c
@@ -338,6 +338,7 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
{
u8 *target;
char *name;
+ const char *reference_name;
u8 count;
if (!info) {
@@ -426,10 +427,9 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
case ACPI_EXD_REFERENCE:
+ reference_name = acpi_ut_get_reference_name(obj_desc);
acpi_ex_out_string("Class Name",
- ACPI_CAST_PTR(char,
- acpi_ut_get_reference_name
- (obj_desc)));
+ ACPI_CAST_PTR(char, reference_name));
acpi_ex_dump_reference_obj(obj_desc);
break;
diff --git a/drivers/acpi/acpica/nsxfname.c b/drivers/acpi/acpica/nsxfname.c
index 21a2ef3..83c1644 100644
--- a/drivers/acpi/acpica/nsxfname.c
+++ b/drivers/acpi/acpica/nsxfname.c
@@ -158,6 +158,7 @@ acpi_get_name(acpi_handle handle, u32 name_type, struct acpi_buffer * buffer)
{
acpi_status status;
struct acpi_namespace_node *node;
+ char *node_name;
/* Parameter validation */
@@ -202,7 +203,8 @@ acpi_get_name(acpi_handle handle, u32 name_type, struct acpi_buffer * buffer)
/* Just copy the ACPI name from the Node and zero terminate it */
- ACPI_MOVE_NAME(buffer->pointer, acpi_ut_get_node_name(node));
+ node_name = acpi_ut_get_node_name(node);
+ ACPI_MOVE_NAME(buffer->pointer, node_name);
((char *)buffer->pointer)[ACPI_NAME_SIZE] = 0;
status = AE_OK;
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 6/6] ACPICA: Update version to 20130626
2013-07-17 1:47 [PATCH 0/6] ACPICA 20130626 Release Lv Zheng
` (4 preceding siblings ...)
2013-07-17 1:48 ` [PATCH 5/6] ACPICA: Fix compiler warnings for casting issues (only some compilers) Lv Zheng
@ 2013-07-17 1:49 ` Lv Zheng
5 siblings, 0 replies; 7+ messages in thread
From: Lv Zheng @ 2013-07-17 1:49 UTC (permalink / raw)
To: Rafael J. Wysocki, Robert Moore, Len Brown; +Cc: Lv Zheng, linux-acpi
From: Bob Moore <robert.moore@intel.com>
Version 20130626.
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Acked-by: Len Brown <len.brown@intel.com>
---
include/acpi/acpixf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 1b09300..60b583f 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -46,7 +46,7 @@
/* Current ACPICA subsystem version in YYYYMMDD format */
-#define ACPI_CA_VERSION 0x20130517
+#define ACPI_CA_VERSION 0x20130626
#include <acpi/acconfig.h>
#include <acpi/actypes.h>
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread