All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Hob: check if warnings are related to package build
@ 2013-12-03 15:52 Valentin Popa
  2013-12-03 15:52 ` [PATCH 1/1] " Valentin Popa
  0 siblings, 1 reply; 2+ messages in thread
From: Valentin Popa @ 2013-12-03 15:52 UTC (permalink / raw)
  To: bitbake-devel


The following changes since commit a6450a951fd52d1330c577139dd492f0c8abb1f8:

  ref-manual: Added the multilib* class. (2013-12-03 12:53:40 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib vpopa/YOCTO_5621
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=vpopa/YOCTO_5621

Valentin Popa (1):
  Hob: check if warnings are related to package build

 bitbake/lib/bb/ui/crumbs/runningbuild.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.3.2



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] Hob: check if warnings are related to package build
  2013-12-03 15:52 [PATCH 0/1] Hob: check if warnings are related to package build Valentin Popa
@ 2013-12-03 15:52 ` Valentin Popa
  0 siblings, 0 replies; 2+ messages in thread
From: Valentin Popa @ 2013-12-03 15:52 UTC (permalink / raw)
  To: bitbake-devel

If warnings come from recipes parsing
and not from package build, 'parent' object
will be None; so don't update the color for it.

[YOCTO #5621]

Signed-off-by: Valentin Popa <valentin.popa@intel.com>
---
 bitbake/lib/bb/ui/crumbs/runningbuild.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bitbake/lib/bb/ui/crumbs/runningbuild.py b/bitbake/lib/bb/ui/crumbs/runningbuild.py
index 0a48a6b..16a955d 100644
--- a/bitbake/lib/bb/ui/crumbs/runningbuild.py
+++ b/bitbake/lib/bb/ui/crumbs/runningbuild.py
@@ -174,13 +174,13 @@ class RunningBuild (gobject.GObject):
                       color,
                       0))
 
-            # if there are warnings, mark the task with warning
-            # color;
+            # if there are warnings while processing a package
+            #  (parent), mark the task with warning color;
             # in case there are errors, the updates will be
             #  handled on TaskFailed.
-            if color == HobColors.WARNING:
+            if color == HobColors.WARNING and parent:
                 self.model.set(parent, self.model.COL_COLOR, color)
-                if task: #then we have a parent, and update it's color
+                if task: #then we have a parent (package), and update it's color
                     self.model.set(self.tasks_to_iter[(package, None)], self.model.COL_COLOR, color)
 
         elif isinstance(event, bb.build.TaskStarted):
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-03 15:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 15:52 [PATCH 0/1] Hob: check if warnings are related to package build Valentin Popa
2013-12-03 15:52 ` [PATCH 1/1] " Valentin Popa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.