All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] fetcher2: remove stamps
@ 2013-12-27  6:51 Robert Yang
  2013-12-27  6:51 ` [PATCH 1/2] bitbake: fetcher2: clean(): remove the .patch.done Robert Yang
  2013-12-27  6:51 ` [PATCH 2/2] bitbake: fetcher2: git.py: clean(): remove the .tar.gz.done Robert Yang
  0 siblings, 2 replies; 3+ messages in thread
From: Robert Yang @ 2013-12-27  6:51 UTC (permalink / raw)
  To: bitbake-devel

The following changes since commit 005af45191ded6185c618c708181b31281e43092:

  bitbake: fetch2: avoid printing "no checksum" error message twice (2013-12-22 14:29:13 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib robert/fetch_stamp
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/fetch_stamp

Robert Yang (2):
  bitbake: fetcher2: clean(): remove the .patch.done
  bitbake: fetcher2: git.py: clean(): remove the .tar.gz.done

 bitbake/lib/bb/fetch2/__init__.py |    2 +-
 bitbake/lib/bb/fetch2/git.py      |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
1.7.10.4



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] bitbake: fetcher2: clean(): remove the .patch.done
  2013-12-27  6:51 [PATCH 0/2] fetcher2: remove stamps Robert Yang
@ 2013-12-27  6:51 ` Robert Yang
  2013-12-27  6:51 ` [PATCH 2/2] bitbake: fetcher2: git.py: clean(): remove the .tar.gz.done Robert Yang
  1 sibling, 0 replies; 3+ messages in thread
From: Robert Yang @ 2013-12-27  6:51 UTC (permalink / raw)
  To: bitbake-devel

There was a problem:

$ bitbake xf86-video-omapfb -cfetch && bitbake xf86-video-omapfb -ccleanall

Everything should be removed, but the
0006-omapfb-port-to-new-xserver-video-API.patch.done still exists in the
DL_DIR, this is because the clean() in the fetch2/__init__.py skips
removing the local file, so that it will skip removing the .done.

The local file (file://) isn't needed to be removed since it is not
downloaded into DL_DIR, but the .done should be removed, this patch will
remove the .done, and it doesn't remove anything else since the clean()
in local.py does nothing.

[YOCTO #5687]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/fetch2/__init__.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
index 8fdf59c..1d89aaf 100644
--- a/bitbake/lib/bb/fetch2/__init__.py
+++ b/bitbake/lib/bb/fetch2/__init__.py
@@ -1497,7 +1497,7 @@ class Fetch(object):
             ud = self.ud[url]
             ud.setup_localpath(self.d)
 
-            if not ud.localfile or self.localpath is None:
+            if not ud.localfile and ud.localpath is None:
                 continue
 
             if ud.lockfile:
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] bitbake: fetcher2: git.py: clean(): remove the .tar.gz.done
  2013-12-27  6:51 [PATCH 0/2] fetcher2: remove stamps Robert Yang
  2013-12-27  6:51 ` [PATCH 1/2] bitbake: fetcher2: clean(): remove the .patch.done Robert Yang
@ 2013-12-27  6:51 ` Robert Yang
  1 sibling, 0 replies; 3+ messages in thread
From: Robert Yang @ 2013-12-27  6:51 UTC (permalink / raw)
  To: bitbake-devel

There was a problem:

$ bitbake xf86-video-omapfb -cfetch && bitbake xf86-video-omapfb -ccleanall

The git2_git.pingu.fi.xf86-video-omapfb.tar.gz has been removed from the
DL_DIR, but the git2_git.pingu.fi.xf86-video-omapfb.tar.gz.done still exists,
this is because the "open(ud.donestamp, 'w').close()" in try_mirror_url() will
create the git2_git.xxx.tar.gz.done, but no one removes it (the clean() in
fetch2/__init__.py removes the DL_DIR/git2/pkg.done)

This only happens on the git fetcher AFAIK.

[YOCTO #5688]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/fetch2/git.py |    1 +
 1 file changed, 1 insertion(+)

diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index bd107db..b4b9368 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -283,6 +283,7 @@ class Git(FetchMethod):
 
         bb.utils.remove(ud.localpath, True)
         bb.utils.remove(ud.fullmirror)
+        bb.utils.remove(ud.fullmirror + ".done")
 
     def supports_srcrev(self):
         return True
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-27  6:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-27  6:51 [PATCH 0/2] fetcher2: remove stamps Robert Yang
2013-12-27  6:51 ` [PATCH 1/2] bitbake: fetcher2: clean(): remove the .patch.done Robert Yang
2013-12-27  6:51 ` [PATCH 2/2] bitbake: fetcher2: git.py: clean(): remove the .tar.gz.done Robert Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.