All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH 0/3] collectd: three fixes
@ 2014-04-08  7:54 jackie.huang
  2014-04-08  7:54 ` [meta-oe][PATCH 1/3] collectd: enable/disable libpq explicitly jackie.huang
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: jackie.huang @ 2014-04-08  7:54 UTC (permalink / raw)
  To: openembedded-devel

From: Jackie Huang <jackie.huang@windriver.com>

---
The following changes since commit bc969d3705c45928de8525ef3d2d9d2867311864:

  inetutils: add -dbg packages for tftpd, telnetd and rshd (2014-04-02 11:18:54 -0400)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib jhuang0/r_collectd_0
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/r_collectd_0

Ming Liu (1):
  collectd: explicitly disable libsensors support

Wenzong Fan (2):
  collectd: enable/disable libpq explicitly
  collectd: fix init status

 .../collectd/collectd/collectd.init                |   13 ++++++++++++-
 .../recipes-extended/collectd/collectd_5.2.2.bb    |    4 +++-
 2 files changed, 15 insertions(+), 2 deletions(-)

-- 
1.7.9.5



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH 1/3] collectd: enable/disable libpq explicitly
  2014-04-08  7:54 [meta-oe][PATCH 0/3] collectd: three fixes jackie.huang
@ 2014-04-08  7:54 ` jackie.huang
  2014-04-08  7:54 ` [meta-oe][PATCH 2/3] collectd: fix init status jackie.huang
  2014-04-08  7:54 ` [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support jackie.huang
  2 siblings, 0 replies; 6+ messages in thread
From: jackie.huang @ 2014-04-08  7:54 UTC (permalink / raw)
  To: openembedded-devel

From: Wenzong Fan <wenzong.fan@windriver.com>

If '--with-libpq' is not included in configure options, the configure
script will assume 'with-libpq=yes' and try to figure below variables
out with 'pg_config':

    with_libpq_includedir, with_libpq_libdir

This causes configure QA errors on some hosts that have 'pg_config'
installed (which from postgresql-devel):

* ERROR: This autoconf log indicates errors, it looked at host include
  and/or library paths while determining system capabilities.

Anyways the target package should not depend on any host headers/libs,
we should enable/disable the libpq support explicitly according to if
the postgresql feature was enabled.

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 .../recipes-extended/collectd/collectd_5.2.2.bb    |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
index 25be1c4..4eed2b6 100644
--- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
+++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
@@ -23,7 +23,8 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG[snmp] = "--enable-snmp,--disable-snmp --with-libnetsnmp=no,net-snmp"
 PACKAGECONFIG[libmemcached] = "--with-libmemcached,--without-libmemcached,libmemcached"
 PACKAGECONFIG[iptables] = "--enable-iptables,--disable-iptables,iptables"
-PACKAGECONFIG[postgresql] = "--enable-postgresql,--disable-postgresql,postgresql"
+PACKAGECONFIG[postgresql] = "--enable-postgresql --with-libpq=yes, \
+        --disable-postgresql --with-libpq=no,postgresql"
 PACKAGECONFIG[dbi] = "--enable-dbi,--disable-dbi,libdbi"
 PACKAGECONFIG[modbus] = "--enable-modbus,--disable-modbus,libmodbus"
 PACKAGECONFIG[libowcapi] = "--with-libowcapi,--without-libowcapi,owfs"
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH 2/3] collectd: fix init status
  2014-04-08  7:54 [meta-oe][PATCH 0/3] collectd: three fixes jackie.huang
  2014-04-08  7:54 ` [meta-oe][PATCH 1/3] collectd: enable/disable libpq explicitly jackie.huang
@ 2014-04-08  7:54 ` jackie.huang
  2014-04-08  7:54 ` [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support jackie.huang
  2 siblings, 0 replies; 6+ messages in thread
From: jackie.huang @ 2014-04-08  7:54 UTC (permalink / raw)
  To: openembedded-devel

From: Wenzong Fan <wenzong.fan@windriver.com>

Fix init status to get it works with 'service --status-all'.

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 .../collectd/collectd/collectd.init                |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/collectd/collectd/collectd.init b/meta-oe/recipes-extended/collectd/collectd/collectd.init
index abdb194..95f5f73 100644
--- a/meta-oe/recipes-extended/collectd/collectd/collectd.init
+++ b/meta-oe/recipes-extended/collectd/collectd/collectd.init
@@ -146,6 +146,17 @@ d_stop() {
 	return "$rc"
 }
 
+# return:
+#   0 if the daemon is running
+#   3 if the daemon is stopped
+d_status(){
+	if test "$USE_COLLECTDMON" == 1; then
+		status $COLLECTDMON_DAEMON
+	else
+		status $DAEMON
+	fi
+}
+
 case "$1" in
 	start)
 		echo -n "Starting $NAME"
@@ -164,7 +175,7 @@ case "$1" in
 		esac
 		;;
 	status)
-		status_of_proc -p "$_PIDFILE" "$DAEMON" "$NAME" && exit 0 || exit $?
+		d_status
 		;;
 	restart|force-reload)
 		echo -n "Restarting $NAME"
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support
  2014-04-08  7:54 [meta-oe][PATCH 0/3] collectd: three fixes jackie.huang
  2014-04-08  7:54 ` [meta-oe][PATCH 1/3] collectd: enable/disable libpq explicitly jackie.huang
  2014-04-08  7:54 ` [meta-oe][PATCH 2/3] collectd: fix init status jackie.huang
@ 2014-04-08  7:54 ` jackie.huang
  2014-04-08  8:28   ` Koen Kooi
  2 siblings, 1 reply; 6+ messages in thread
From: jackie.huang @ 2014-04-08  7:54 UTC (permalink / raw)
  To: openembedded-devel

From: Ming Liu <ming.liu@windriver.com>

To avoid an implicit build result.

Signed-off-by: Ming Liu <ming.liu@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 .../recipes-extended/collectd/collectd_5.2.2.bb    |    1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
index 4eed2b6..00010c7 100644
--- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
+++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
@@ -35,6 +35,7 @@ EXTRA_OECONF = " \
                 --disable-perl --with-libperl=no --with-perl-bindings=no \
                 --with-libgcrypt=${STAGING_BINDIR_CROSS}/libgcrypt-config \
                 --disable-notify_desktop \
+                --with-libsensors=no \
 "
 
 do_install_append() {
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support
  2014-04-08  7:54 ` [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support jackie.huang
@ 2014-04-08  8:28   ` Koen Kooi
  2014-04-08  8:52     ` Huang, Jie (Jackie)
  0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2014-04-08  8:28 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

jackie.huang@windriver.com schreef op 08-04-14 09:54:
> From: Ming Liu <ming.liu@windriver.com>
> 
> To avoid an implicit build result.

Should this be a PACKAGECONFIG option?

> 
> Signed-off-by: Ming Liu <ming.liu@windriver.com> Signed-off-by: Jackie
> Huang <jackie.huang@windriver.com> --- 
> .../recipes-extended/collectd/collectd_5.2.2.bb    |    1 + 1 file
> changed, 1 insertion(+)
> 
> diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb index
> 4eed2b6..00010c7 100644 ---
> a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb +++
> b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb @@ -35,6 +35,7 @@
> EXTRA_OECONF = " \ --disable-perl --with-libperl=no
> --with-perl-bindings=no \ 
> --with-libgcrypt=${STAGING_BINDIR_CROSS}/libgcrypt-config \ 
> --disable-notify_desktop \ +                --with-libsensors=no \ "
> 
> do_install_append() {
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTQ7MVMkyGM64RGpERAmj+AJ4rqJPUBZ4FIn97cJQZbe7N+dplBwCeJY3v
vw+CKp3dZdL5QvuP/4jReao=
=yGBZ
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support
  2014-04-08  8:28   ` Koen Kooi
@ 2014-04-08  8:52     ` Huang, Jie (Jackie)
  0 siblings, 0 replies; 6+ messages in thread
From: Huang, Jie (Jackie) @ 2014-04-08  8:52 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org



> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of Koen Kooi
> Sent: Tuesday, April 08, 2014 4:28 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> jackie.huang@windriver.com schreef op 08-04-14 09:54:
> > From: Ming Liu <ming.liu@windriver.com>
> >
> > To avoid an implicit build result.
> 
> Should this be a PACKAGECONFIG option?

Yeah, it make sense, I will change it to be a PACKAGECONFIG option, thanks!

Thanks,
Jackie

> 
> >
> > Signed-off-by: Ming Liu <ming.liu@windriver.com> Signed-off-by: Jackie
> > Huang <jackie.huang@windriver.com> ---
> > .../recipes-extended/collectd/collectd_5.2.2.bb    |    1 + 1 file
> > changed, 1 insertion(+)
> >
> > diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb index
> > 4eed2b6..00010c7 100644 ---
> > a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb +++
> > b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb @@ -35,6 +35,7
> > @@ EXTRA_OECONF = " \ --disable-perl --with-libperl=no
> > --with-perl-bindings=no \
> > --with-libgcrypt=${STAGING_BINDIR_CROSS}/libgcrypt-config \
> > --disable-notify_desktop \ +                --with-libsensors=no \ "
> >
> > do_install_append() {
> >
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> 
> iD8DBQFTQ7MVMkyGM64RGpERAmj+AJ4rqJPUBZ4FIn97cJQZbe7N+dplBwCeJY3v
> vw+CKp3dZdL5QvuP/4jReao=
> =yGBZ
> -----END PGP SIGNATURE-----
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-04-08  8:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08  7:54 [meta-oe][PATCH 0/3] collectd: three fixes jackie.huang
2014-04-08  7:54 ` [meta-oe][PATCH 1/3] collectd: enable/disable libpq explicitly jackie.huang
2014-04-08  7:54 ` [meta-oe][PATCH 2/3] collectd: fix init status jackie.huang
2014-04-08  7:54 ` [meta-oe][PATCH 3/3] collectd: explicitly disable libsensors support jackie.huang
2014-04-08  8:28   ` Koen Kooi
2014-04-08  8:52     ` Huang, Jie (Jackie)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.