All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jason@lakedaemon.net, keescook@chromium.org,
	Virtualization List <virtualization@lists.linux-foundation.org>,
	Amit Shah <amit.shah@redhat.com>,
	herbert@gondor.apana.org.au
Subject: [PATCH 0/2] hwrng: don't fetch data before device init
Date: Wed,  2 Jul 2014 15:58:14 +0530	[thread overview]
Message-ID: <cover.1404296679.git.amit.shah@redhat.com> (raw)

Hi,

When booting a recent kernel under KVM with the virtio-rng device
enabled, the boot process was stalling.  Bisect pointed to a commit
made during the 3.15 window to fetch randomness from newly-registered
devices in the hwrng core.  The details are in the patches.

I considered a couple of approaches, but basing on the init() function
being registered, as is done in patch 1 here, seems like the best idea,
since quite a few drivers need to initialize their devices before data
is fetched off them.

Please review and apply if appropriate,

Amit Shah (2):
  hwrng: don't fetch rng from sources without init
  virtio: rng: introduce an init fn for hwrng core

 drivers/char/hw_random/core.c       |  8 +++++---
 drivers/char/hw_random/virtio-rng.c | 11 +++++++++++
 2 files changed, 16 insertions(+), 3 deletions(-)

-- 
1.9.3

WARNING: multiple messages have this Message-ID (diff)
From: Amit Shah <amit.shah@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Virtualization List <virtualization@lists.linux-foundation.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	herbert@gondor.apana.org.au, keescook@chromium.org,
	jason@lakedaemon.net, Amit Shah <amit.shah@redhat.com>
Subject: [PATCH 0/2] hwrng: don't fetch data before device init
Date: Wed,  2 Jul 2014 15:58:14 +0530	[thread overview]
Message-ID: <cover.1404296679.git.amit.shah@redhat.com> (raw)

Hi,

When booting a recent kernel under KVM with the virtio-rng device
enabled, the boot process was stalling.  Bisect pointed to a commit
made during the 3.15 window to fetch randomness from newly-registered
devices in the hwrng core.  The details are in the patches.

I considered a couple of approaches, but basing on the init() function
being registered, as is done in patch 1 here, seems like the best idea,
since quite a few drivers need to initialize their devices before data
is fetched off them.

Please review and apply if appropriate,

Amit Shah (2):
  hwrng: don't fetch rng from sources without init
  virtio: rng: introduce an init fn for hwrng core

 drivers/char/hw_random/core.c       |  8 +++++---
 drivers/char/hw_random/virtio-rng.c | 11 +++++++++++
 2 files changed, 16 insertions(+), 3 deletions(-)

-- 
1.9.3


             reply	other threads:[~2014-07-02 10:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 10:28 Amit Shah [this message]
2014-07-02 10:28 ` [PATCH 0/2] hwrng: don't fetch data before device init Amit Shah
2014-07-02 10:28 ` [PATCH 1/2] hwrng: don't fetch rng from sources without init Amit Shah
2014-07-02 10:28   ` Amit Shah
2014-07-02 11:58   ` Jason Cooper
2014-07-02 11:58   ` Jason Cooper
2014-07-02 12:11     ` Amit Shah
2014-07-02 12:11       ` Amit Shah
2014-07-02 12:14       ` Jason Cooper
2014-07-02 12:14       ` Jason Cooper
2014-07-02 10:28 ` [PATCH 2/2] virtio: rng: introduce an init fn for hwrng core Amit Shah
2014-07-02 10:28   ` Amit Shah
2014-07-02 13:00 ` [PATCH 1/2 v2] hwrng: Allow drivers to disable reading during probe Jason Cooper
2014-07-02 13:00   ` [PATCH 2/2 v2] hwrng: virtio: " Jason Cooper
2014-07-02 13:00   ` Jason Cooper
2014-07-02 13:26   ` [PATCH 1/2 v2] hwrng: Allow drivers to " Amit Shah
2014-07-02 13:26   ` Amit Shah
2014-07-02 13:41     ` Jason Cooper
2014-07-02 15:11       ` Kees Cook
2014-07-02 15:11         ` Kees Cook
2014-07-02 16:02         ` Amit Shah
2014-07-02 16:02           ` Amit Shah
2014-07-02 15:58       ` Amit Shah
2014-07-02 15:58       ` Amit Shah
2014-07-02 13:41     ` Jason Cooper
2014-07-02 13:00 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1404296679.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jason@lakedaemon.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.