All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-trivial@nongnu.org
Cc: Gonglei <arei.gonglei@huawei.com>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-trivial] [PATCH 0/4] cleanup -daemonize and pidfile creation a bit
Date: Thu, 30 Oct 2014 18:07:13 +0300	[thread overview]
Message-ID: <cover.1414681502.git.mjt@msgid.tls.msk.ru> (raw)

The $subject theme is quite messy, with many things done in a cryptic
and twisty way without any need for that.  This trivial patch series
tries to clean up and improve it.  In particular, it aims to make
pidfile errors visible with -daemonize -- something which Gonglei
tried to fix in e5048d15ce6a and which we're revering because that
fix turned out to be incomplete and wrong.

The patches are simple but I split them into several to easy review.

Michael Tokarev (4):
  os-posix: use global daemon_pipe instead of cryptic fds[1]
  os-posix: replace goto again with a proper loop
  pidfile: stop making pidfile error a special case
  os-posix: reorder parent notification for -daemonize

 include/qemu-common.h |    1 -
 os-posix.c            |   62 ++++++++++++++++++-------------------------------
 os-win32.c            |    5 ----
 vl.c                  |    2 +-
 4 files changed, 23 insertions(+), 47 deletions(-)

-- 
1.7.10.4



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-trivial@nongnu.org
Cc: Gonglei <arei.gonglei@huawei.com>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 0/4] cleanup -daemonize and pidfile creation a bit
Date: Thu, 30 Oct 2014 18:07:13 +0300	[thread overview]
Message-ID: <cover.1414681502.git.mjt@msgid.tls.msk.ru> (raw)

The $subject theme is quite messy, with many things done in a cryptic
and twisty way without any need for that.  This trivial patch series
tries to clean up and improve it.  In particular, it aims to make
pidfile errors visible with -daemonize -- something which Gonglei
tried to fix in e5048d15ce6a and which we're revering because that
fix turned out to be incomplete and wrong.

The patches are simple but I split them into several to easy review.

Michael Tokarev (4):
  os-posix: use global daemon_pipe instead of cryptic fds[1]
  os-posix: replace goto again with a proper loop
  pidfile: stop making pidfile error a special case
  os-posix: reorder parent notification for -daemonize

 include/qemu-common.h |    1 -
 os-posix.c            |   62 ++++++++++++++++++-------------------------------
 os-win32.c            |    5 ----
 vl.c                  |    2 +-
 4 files changed, 23 insertions(+), 47 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2014-10-31 15:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 15:07 Michael Tokarev [this message]
2014-10-30 15:07 ` [Qemu-devel] [PATCH 0/4] cleanup -daemonize and pidfile creation a bit Michael Tokarev
2014-10-30 15:07 ` [Qemu-trivial] [PATCH 1/4] os-posix: use global daemon_pipe instead of cryptic fds[1] Michael Tokarev
2014-10-30 15:07   ` [Qemu-devel] " Michael Tokarev
2014-10-31  4:57   ` [Qemu-trivial] " Gonglei
2014-10-31  4:57     ` [Qemu-devel] " Gonglei
2014-10-30 15:07 ` [Qemu-trivial] [PATCH 2/4] os-posix: replace goto again with a proper loop Michael Tokarev
2014-10-30 15:07   ` [Qemu-devel] " Michael Tokarev
2014-10-31  4:58   ` [Qemu-trivial] " Gonglei
2014-10-31  4:58     ` [Qemu-devel] " Gonglei
2014-10-30 15:07 ` [Qemu-trivial] [PATCH 3/4] pidfile: stop making pidfile error a special case Michael Tokarev
2014-10-30 15:07   ` [Qemu-devel] " Michael Tokarev
2014-10-31  5:00   ` [Qemu-trivial] " Gonglei
2014-10-31  5:00     ` [Qemu-devel] " Gonglei
2014-10-31  7:16     ` [Qemu-trivial] " Michael Tokarev
2014-10-31  7:16       ` [Qemu-devel] " Michael Tokarev
2014-10-31  7:33       ` [Qemu-trivial] " Gonglei
2014-10-31  7:33         ` [Qemu-devel] " Gonglei
2014-10-31  7:41         ` [Qemu-trivial] " Michael Tokarev
2014-10-31  7:41           ` [Qemu-devel] " Michael Tokarev
2014-10-31  7:58           ` [Qemu-trivial] " Gonglei
2014-10-31  7:58             ` [Qemu-devel] " Gonglei
2014-10-31  8:02             ` [Qemu-trivial] " Michael Tokarev
2014-10-31  8:02               ` [Qemu-devel] " Michael Tokarev
2014-10-31  8:10               ` [Qemu-trivial] " Gonglei
2014-10-31  8:10                 ` [Qemu-devel] " Gonglei
2014-10-30 15:07 ` [Qemu-trivial] [PATCH 4/4] os-posix: reorder parent notification for -daemonize Michael Tokarev
2014-10-30 15:07   ` [Qemu-devel] " Michael Tokarev
2014-10-31  5:02   ` [Qemu-trivial] " Gonglei
2014-10-31  5:02     ` [Qemu-devel] " Gonglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1414681502.git.mjt@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.