[PATCH 0/4] staging: rtl8192u: Fix checkpatch.pl warnings in ieee80211_crypt.c

[PATCH 0/4] staging: rtl8192u: Fix checkpatch.pl warnings in ieee80211_crypt.c

[Navya Sri Nizamkari]

This patchset clears checkpatch.pl warnings in ieee80211_crypt.c
such as:
convert printk to a preferable function like netdev_dbg or pr_dbg,
fix the comment line style warning, replace asm header files with
linux ones, fix the quoted string split across a line.

Navya Sri Nizamkari (4):
  staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg
  staging: rtl8192u: Clean-up comment line style
  staging: rtl8192u: Replace asm header files with linux ones.
  staging: rtl8192u: Fix quoted string split across lines

 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

-- 
1.9.1

[PATCH 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg

[Navya Sri Nizamkari]

Convert printk(KERN_DEBUG.. ) to netdev_dbg if its a network driver
and pr_dbg if its not a driver, to fix the checkpatch.pl warning:

WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 5533221..e517e81 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
 	spin_lock_irqsave(&ieee->lock, flags);
 	ieee80211_crypt_deinit_entries(ieee, 0);
 	if (!list_empty(&ieee->crypt_deinit_list)) {
-		printk(KERN_DEBUG "%s: entries remaining in delayed crypt "
-		       "deletion list\n", ieee->dev->name);
+		netdev_dbg(ieee->dev, "entries remaining in delayed crypt "
+		       "deletion list\n");
 		ieee->crypt_deinit_timer.expires = jiffies + HZ;
 		add_timer(&ieee->crypt_deinit_timer);
 	}
@@ -118,7 +118,7 @@ int ieee80211_register_crypto_ops(struct ieee80211_crypto_ops *ops)
 	list_add(&alg->list, &hcrypt->algs);
 	spin_unlock_irqrestore(&hcrypt->lock, flags);
 
-	printk(KERN_DEBUG "ieee80211_crypt: registered algorithm '%s'\n",
+	pr_dbg("ieee80211_crypt: registered algorithm '%s'\n",
 	       ops->name);
 
 	return 0;
@@ -146,7 +146,7 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops)
 	spin_unlock_irqrestore(&hcrypt->lock, flags);
 
 	if (del_alg) {
-		printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm "
+		pr_dbg("ieee80211_crypt: unregistered algorithm "
 		       "'%s'\n", ops->name);
 		kfree(del_alg);
 	}
@@ -232,7 +232,7 @@ void __exit ieee80211_crypto_deinit(void)
 		struct ieee80211_crypto_alg *alg =
 			(struct ieee80211_crypto_alg *) ptr;
 		list_del(ptr);
-		printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm "
+		pr_dbg("ieee80211_crypt: unregistered algorithm "
 		       "'%s' (deinit)\n", alg->ops->name);
 		kfree(alg);
 	}
-- 
1.9.1

[PATCH 2/4] staging: rtl8192u: Clean-up comment line style

[Navya Sri Nizamkari]

Convert style of comment from C99 to C89 to fix the
following checkpatch.pl error:

ERROR: "Do not use C99 // comments"

Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index e517e81..8c29c58 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -11,7 +11,7 @@
  *
  */
 
-//#include <linux/config.h>
+/* #include <linux/config.h> */
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
-- 
1.9.1

[PATCH 3/4] staging: rtl8192u: Replace asm header files with linux ones.

[Navya Sri Nizamkari]

As asm header files are included in linux header files, this patch
uses <linux/string.h> instead of <asm/string.h> and <linux/errno.h>
instead of <asm/errno.h> to fix checkpatch.pl errors:

ERROR: Use #include <linux/string.h> instead of <asm/string.h>
ERROR: Use #include <linux/errno.h> instead of <asm/errno.h>

Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 8c29c58..553e421 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -15,8 +15,8 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
-#include <asm/string.h>
-#include <asm/errno.h>
+#include <linux/string.h>
+#include <linux/errno.h>
 
 #include "ieee80211.h"
 
-- 
1.9.1

[PATCH 4/4] staging: rtl8192u: Fix quoted string split across lines

[Navya Sri Nizamkari]

This patch fixes the checkpatch.pl warning:

WARNING: quoted string split across lines

Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 553e421..0004939 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
 	spin_lock_irqsave(&ieee->lock, flags);
 	ieee80211_crypt_deinit_entries(ieee, 0);
 	if (!list_empty(&ieee->crypt_deinit_list)) {
-		netdev_dbg(ieee->dev, "entries remaining in delayed crypt "
-		       "deletion list\n");
+		netdev_dbg(ieee->dev,
+		       "entries remaining in delayed crypt deletion list\n");
 		ieee->crypt_deinit_timer.expires = jiffies + HZ;
 		add_timer(&ieee->crypt_deinit_timer);
 	}
@@ -146,8 +146,8 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops)
 	spin_unlock_irqrestore(&hcrypt->lock, flags);
 
 	if (del_alg) {
-		pr_dbg("ieee80211_crypt: unregistered algorithm "
-		       "'%s'\n", ops->name);
+		pr_dbg("ieee80211_crypt: unregistered algorithm '%s'\n",
+		       ops->name);
 		kfree(del_alg);
 	}
 
@@ -232,8 +232,8 @@ void __exit ieee80211_crypto_deinit(void)
 		struct ieee80211_crypto_alg *alg =
 			(struct ieee80211_crypto_alg *) ptr;
 		list_del(ptr);
-		pr_dbg("ieee80211_crypt: unregistered algorithm "
-		       "'%s' (deinit)\n", alg->ops->name);
+		pr_dbg("ieee80211_crypt: unregistered algorithm '%s' (deinit)\n",
+		       alg->ops->name);
 		kfree(alg);
 	}
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg

[Julia Lawall]

On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote:

> Convert printk(KERN_DEBUG.. ) to netdev_dbg if its a network driver
> and pr_dbg if its not a driver, to fix the checkpatch.pl warning:

This message is rather confusing.  The patch affects only one file, so it
either is a network driver or it is not.  The issue is that some functions
don't have the right set of arguments that allow you to call the netdev
functions.

julia

> WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
> pr_debug(...  to printk(KERN_DEBUG ...
>
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..e517e81 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
>  	spin_lock_irqsave(&ieee->lock, flags);
>  	ieee80211_crypt_deinit_entries(ieee, 0);
>  	if (!list_empty(&ieee->crypt_deinit_list)) {
> -		printk(KERN_DEBUG "%s: entries remaining in delayed crypt "
> -		       "deletion list\n", ieee->dev->name);
> +		netdev_dbg(ieee->dev, "entries remaining in delayed crypt "
> +		       "deletion list\n");
>  		ieee->crypt_deinit_timer.expires = jiffies + HZ;
>  		add_timer(&ieee->crypt_deinit_timer);
>  	}
> @@ -118,7 +118,7 @@ int ieee80211_register_crypto_ops(struct ieee80211_crypto_ops *ops)
>  	list_add(&alg->list, &hcrypt->algs);
>  	spin_unlock_irqrestore(&hcrypt->lock, flags);
>
> -	printk(KERN_DEBUG "ieee80211_crypt: registered algorithm '%s'\n",
> +	pr_dbg("ieee80211_crypt: registered algorithm '%s'\n",
>  	       ops->name);
>
>  	return 0;
> @@ -146,7 +146,7 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops)
>  	spin_unlock_irqrestore(&hcrypt->lock, flags);
>
>  	if (del_alg) {
> -		printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm "
> +		pr_dbg("ieee80211_crypt: unregistered algorithm "
>  		       "'%s'\n", ops->name);
>  		kfree(del_alg);
>  	}
> @@ -232,7 +232,7 @@ void __exit ieee80211_crypto_deinit(void)
>  		struct ieee80211_crypto_alg *alg =
>  			(struct ieee80211_crypto_alg *) ptr;
>  		list_del(ptr);
> -		printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm "
> +		pr_dbg("ieee80211_crypt: unregistered algorithm "
>  		       "'%s' (deinit)\n", alg->ops->name);
>  		kfree(alg);
>  	}
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/4025a37966c3b0a3a3e210fad8740f0673ab5a92.1424538520.git.navyasri.tech%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] staging: rtl8192u: [PATCH v2 1/4] Convert from printk into netdev_dbg or pr_dbg

[Julia Lawall]

On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote:

> As this is a network driver file, convert printk(KERN_DEBUG.. ) to
> netdev_dbg if the calling function has arguments to support it else
> to pr_dbg , to fix the checkpatch.pl warning:

Much better, thanks.

julia

> WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
> pr_debug(...  to printk(KERN_DEBUG ...
>
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v2:
>     - Correct the commit message to be clearer.
>
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..e517e81 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
>  	spin_lock_irqsave(&ieee->lock, flags);
>  	ieee80211_crypt_deinit_entries(ieee, 0);
>  	if (!list_empty(&ieee->crypt_deinit_list)) {
> -		printk(KERN_DEBUG "%s: entries remaining in delayed crypt "
> -		       "deletion list\n", ieee->dev->name);
> +		netdev_dbg(ieee->dev, "entries remaining in delayed crypt "
> +		       "deletion list\n");
>  		ieee->crypt_deinit_timer.expires = jiffies + HZ;
>  		add_timer(&ieee->crypt_deinit_timer);
>  	}
> @@ -118,7 +118,7 @@ int ieee80211_register_crypto_ops(struct ieee80211_crypto_ops *ops)
>  	list_add(&alg->list, &hcrypt->algs);
>  	spin_unlock_irqrestore(&hcrypt->lock, flags);
>
> -	printk(KERN_DEBUG "ieee80211_crypt: registered algorithm '%s'\n",
> +	pr_dbg("ieee80211_crypt: registered algorithm '%s'\n",
>  	       ops->name);
>
>  	return 0;
> @@ -146,7 +146,7 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops)
>  	spin_unlock_irqrestore(&hcrypt->lock, flags);
>
>  	if (del_alg) {
> -		printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm "
> +		pr_dbg("ieee80211_crypt: unregistered algorithm "
>  		       "'%s'\n", ops->name);
>  		kfree(del_alg);
>  	}
> @@ -232,7 +232,7 @@ void __exit ieee80211_crypto_deinit(void)
>  		struct ieee80211_crypto_alg *alg =
>  			(struct ieee80211_crypto_alg *) ptr;
>  		list_del(ptr);
> -		printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm "
> +		pr_dbg("ieee80211_crypt: unregistered algorithm "
>  		       "'%s' (deinit)\n", alg->ops->name);
>  		kfree(alg);
>  	}
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/4025a37966c3b0a3a3e210fad8740f0673ab5a92.1424538520.git.navyasri.tech%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg

[Navya Sri Nizamkari]

[-- Attachment #1.1: Type: text/plain, Size: 3954 bytes --]



On Saturday, February 21, 2015 at 11:21:21 PM UTC+5:30, Julia Lawall wrote:
>
> On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote: 
>
> > Convert printk(KERN_DEBUG.. ) to netdev_dbg if its a network driver 
> > and pr_dbg if its not a driver, to fix the checkpatch.pl warning: 
>
> This message is rather confusing.  The patch affects only one file, so it 
> either is a network driver or it is not.  The issue is that some functions 
> don't have the right set of arguments that allow you to call the netdev 
> functions. 
>
> julia 
>
> I made the change and sent in v2 of that patch.Should I send the whole 
patchset again ?

Navya

> WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then 
> > pr_debug(...  to printk(KERN_DEBUG ... 
> > 
> > Signed-off-by: Navya Sri Nizamkari <navyas...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 10 +++++----- 
> >  1 file changed, 5 insertions(+), 5 deletions(-) 
> > 
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c 
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c 
> > index 5533221..e517e81 100644 
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c 
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c 
> > @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long 
> data) 
> >          spin_lock_irqsave(&ieee->lock, flags); 
> >          ieee80211_crypt_deinit_entries(ieee, 0); 
> >          if (!list_empty(&ieee->crypt_deinit_list)) { 
> > -                printk(KERN_DEBUG "%s: entries remaining in delayed 
> crypt " 
> > -                       "deletion list\n", ieee->dev->name); 
> > +                netdev_dbg(ieee->dev, "entries remaining in delayed 
> crypt " 
> > +                       "deletion list\n"); 
> >                  ieee->crypt_deinit_timer.expires = jiffies + HZ; 
> >                  add_timer(&ieee->crypt_deinit_timer); 
> >          } 
> > @@ -118,7 +118,7 @@ int ieee80211_register_crypto_ops(struct 
> ieee80211_crypto_ops *ops) 
> >          list_add(&alg->list, &hcrypt->algs); 
> >          spin_unlock_irqrestore(&hcrypt->lock, flags); 
> > 
> > -        printk(KERN_DEBUG "ieee80211_crypt: registered algorithm 
> '%s'\n", 
> > +        pr_dbg("ieee80211_crypt: registered algorithm '%s'\n", 
> >                 ops->name); 
> > 
> >          return 0; 
> > @@ -146,7 +146,7 @@ int ieee80211_unregister_crypto_ops(struct 
> ieee80211_crypto_ops *ops) 
> >          spin_unlock_irqrestore(&hcrypt->lock, flags); 
> > 
> >          if (del_alg) { 
> > -                printk(KERN_DEBUG "ieee80211_crypt: unregistered 
> algorithm " 
> > +                pr_dbg("ieee80211_crypt: unregistered algorithm " 
> >                         "'%s'\n", ops->name); 
> >                  kfree(del_alg); 
> >          } 
> > @@ -232,7 +232,7 @@ void __exit ieee80211_crypto_deinit(void) 
> >                  struct ieee80211_crypto_alg *alg = 
> >                          (struct ieee80211_crypto_alg *) ptr; 
> >                  list_del(ptr); 
> > -                printk(KERN_DEBUG "ieee80211_crypt: unregistered 
> algorithm " 
> > +                pr_dbg("ieee80211_crypt: unregistered algorithm " 
> >                         "'%s' (deinit)\n", alg->ops->name); 
> >                  kfree(alg); 
> >          } 
> > -- 
> > 1.9.1 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/4025a37966c3b0a3a3e210fad8740f0673ab5a92.1424538520.git.navyasri.tech%40gmail.com. 
>
> > For more options, visit https://groups.google.com/d/optout. 
> > 
>

[-- Attachment #1.2: Type: text/html, Size: 7449 bytes --]

Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 818 bytes --]

On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote:

>
>
> On Saturday, February 21, 2015 at 11:21:21 PM UTC+5:30, Julia Lawall wrote:
>       On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote:
>
>       > Convert printk(KERN_DEBUG.. ) to netdev_dbg if its a network
>       driver
>       > and pr_dbg if its not a driver, to fix the checkpatch.pl
>       warning:
>
>       This message is rather confusing.  The patch affects only one
>       file, so it
>       either is a network driver or it is not.  The issue is that some
>       functions
>       don't have the right set of arguments that allow you to call the
>       netdev
>       functions.
>
>       julia
>
> I made the change and sent in v2 of that patch.Should I send the whole
> patchset again ?

Yes.  (Remember to put a space after punctuation)

julia

Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg

[Navya Sri Nizamkari]

[-- Attachment #1.1: Type: text/plain, Size: 1059 bytes --]



On Sunday, February 22, 2015 at 12:05:13 AM UTC+5:30, Julia Lawall wrote:
>
> On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote: 
>
> > 
> > 
> > On Saturday, February 21, 2015 at 11:21:21 PM UTC+5:30, Julia Lawall 
> wrote: 
> >       On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote: 
> > 
> >       > Convert printk(KERN_DEBUG.. ) to netdev_dbg if its a network 
> >       driver 
> >       > and pr_dbg if its not a driver, to fix the checkpatch.pl 
> >       warning: 
> > 
> >       This message is rather confusing.  The patch affects only one 
> >       file, so it 
> >       either is a network driver or it is not.  The issue is that some 
> >       functions 
> >       don't have the right set of arguments that allow you to call the 
> >       netdev 
> >       functions. 
> > 
> >       julia 
> > 
> > I made the change and sent in v2 of that patch.Should I send the whole 
> > patchset again ? 
>
> Yes.  (Remember to put a space after punctuation) 
>
> julia


Sorry about missing the space after punctuation. Thanks for the feedback.

Navya 

[-- Attachment #1.2: Type: text/html, Size: 1609 bytes --]

Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg

[Navya Sri Nizamkari]

[-- Attachment #1.1: Type: text/plain, Size: 1333 bytes --]



On Sunday, February 22, 2015 at 12:11:36 AM UTC+5:30, Navya Sri Nizamkari 
wrote:
>
>
>
> On Sunday, February 22, 2015 at 12:05:13 AM UTC+5:30, Julia Lawall wrote:
>>
>> On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote: 
>>
>> > 
>> > 
>> > On Saturday, February 21, 2015 at 11:21:21 PM UTC+5:30, Julia Lawall 
>> wrote: 
>> >       On Sat, 21 Feb 2015, Navya Sri Nizamkari wrote: 
>> > 
>> >       > Convert printk(KERN_DEBUG.. ) to netdev_dbg if its a network 
>> >       driver 
>> >       > and pr_dbg if its not a driver, to fix the checkpatch.pl 
>> >       warning: 
>> > 
>> >       This message is rather confusing.  The patch affects only one 
>> >       file, so it 
>> >       either is a network driver or it is not.  The issue is that some 
>> >       functions 
>> >       don't have the right set of arguments that allow you to call the 
>> >       netdev 
>> >       functions. 
>> > 
>> >       julia 
>> > 
>> > I made the change and sent in v2 of that patch.Should I send the whole 
>> > patchset again ? 
>>
>> Yes.  (Remember to put a space after punctuation) 
>>
>> julia
>
>
> Sorry about missing the space after punctuation. Thanks for the feedback.
>
> Navya 
>

I added a space after ' : ' in the cover letter of v2 by mistake, I haven't 
sent rest of the patches yet? Do I send a newer version?

Navya   

[-- Attachment #1.2: Type: text/html, Size: 2014 bytes --]

Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg

[Julia Lawall]

> I added a space after ' : ' in the cover letter of v2 by mistake, I haven't
> sent rest of the patches yet? Do I send a newer version?

No, don't bother.  The cover letter is just to be read by someone 
receiving the patches. It is not preserved.

julia

Re: [Outreachy kernel] [PATCH 2/4] staging: rtl8192u: Clean-up comment line style

[Arnd Bergmann]

On Saturday 21 February 2015 23:17:41 Navya Sri Nizamkari wrote:
>   *
>   */
>  
> -//#include <linux/config.h>
> +/* #include <linux/config.h> */
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>

Just remove that line: the linux/config.h file is not used in modern linux
versions, and the comment is just a leftover from someone trying to
work around that.

	Arnd