[PATCH 0/4] Corrected four type checkpatch.pl errors and warning.

[PATCH 0/4] Corrected four type checkpatch.pl errors and warning.

[Gulsah Kose]

This patch fixes following checkpatch.pl errors and warnings in bootp.c:
ERROR: "foo * bar" should be "foo *bar"
ERROR: "(foo*)" should be "(foo *)"
WARNING: braces {} are not necessary for single statement blocks
WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))

Gulsah Kose (4):
  staging: arch: alpha: boot: Deleted unnecessary space.
  staging: arch: alpha: boot: Added missing space before "*"
  staging: arch: alpha: boot: Deleted unnecessary brackets.
  staging: arch: alpha: boot: Replaced __attribute__((aligned(size)))
    with __aligned(size).

 arch/alpha/boot/bootp.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

-- 
1.9.1

[PATCH 1/4] staging: arch: alpha: boot: Deleted unnecessary space.

[Gulsah Kose]

This patch fixes "foo * bar" should be "foo *bar" checkpatch.pl error in bootp.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
---
 arch/alpha/boot/bootp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c
index 2a542a5..3ee529d 100644
--- a/arch/alpha/boot/bootp.c
+++ b/arch/alpha/boot/bootp.c
@@ -23,7 +23,7 @@
 #include "ksize.h"
 
 extern unsigned long switch_to_osf_pal(unsigned long nr,
-	struct pcb_struct * pcb_va, struct pcb_struct * pcb_pa,
+	struct pcb_struct *pcb_va, struct pcb_struct *pcb_pa,
 	unsigned long *vptb);
 
 extern void move_stack(unsigned long new_stack);
@@ -68,8 +68,8 @@ void
 pal_init(void)
 {
 	unsigned long i, rev;
-	struct percpu_struct * percpu;
-	struct pcb_struct * pcb_pa;
+	struct percpu_struct *percpu;
+	struct pcb_struct *pcb_pa;
 
 	/* Create the dummy PCB.  */
 	pcb_va->ksp = 0;
-- 
1.9.1

[PATCH 2/4] staging: arch: alpha: boot: Added missing space before "*"

[Gulsah Kose]

This patch fixes "(foo*)" should be "(foo *)" checkpatch.pl errors in bootp.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
---
 arch/alpha/boot/bootp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c
index 3ee529d..27807f5 100644
--- a/arch/alpha/boot/bootp.c
+++ b/arch/alpha/boot/bootp.c
@@ -203,8 +203,8 @@ start_kernel(void)
         load(START_ADDR+(4*KERNEL_SIZE), KERNEL_ORIGIN, KERNEL_SIZE);
         load(START_ADDR, START_ADDR+(4*KERNEL_SIZE), KERNEL_SIZE);
 
-	memset((char*)ZERO_PGE, 0, PAGE_SIZE);
-	strcpy((char*)ZERO_PGE, envval);
+	memset((char *)ZERO_PGE, 0, PAGE_SIZE);
+	strcpy((char *)ZERO_PGE, envval);
 #ifdef INITRD_IMAGE_SIZE
 	((long *)(ZERO_PGE+256))[0] = initrd_start;
 	((long *)(ZERO_PGE+256))[1] = INITRD_IMAGE_SIZE;
-- 
1.9.1

[PATCH 3/4] staging: arch: alpha: boot: Deleted unnecessary brackets.

[Gulsah Kose]

This patch fixes "braces {} are not necessary for single statement
blocks" checkpatch.pl warnings in bootp.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
---
 arch/alpha/boot/bootp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c
index 27807f5..c66ea3c 100644
--- a/arch/alpha/boot/bootp.c
+++ b/arch/alpha/boot/bootp.c
@@ -177,9 +177,8 @@ start_kernel(void)
 	move_stack(initrd_start - PAGE_SIZE);
 
 	nbytes = callback_getenv(ENV_BOOTED_OSFLAGS, envval, sizeof(envval));
-	if (nbytes < 0 || nbytes >= sizeof(envval)) {
+	if (nbytes < 0 || nbytes >= sizeof(envval))
 		nbytes = 0;
-	}
 	envval[nbytes] = '\0';
 	srm_printk("Loading the kernel...'%s'\n", envval);
 
-- 
1.9.1

[PATCH 4/4] staging: arch: alpha: boot: Replaced __attribute__((aligned(size))) with __aligned(size).

[Gulsah Kose]

This patch fixes " __aligned(size) is preferred over __attribute__((aligned(size)))"
checkpatch.pl warning in bootp.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
---
 arch/alpha/boot/bootp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c
index c66ea3c..f50c5dd 100644
--- a/arch/alpha/boot/bootp.c
+++ b/arch/alpha/boot/bootp.c
@@ -146,7 +146,7 @@ start_kernel(void)
 	 *    seems rather far-fetched.
 	 */
 	static long nbytes;
-	static char envval[256] __attribute__((aligned(8)));
+	static char envval[256] __aligned(8);
 	static unsigned long initrd_start;
 
 	srm_printk("Linux/AXP bootp loader for Linux " UTS_RELEASE "\n");
-- 
1.9.1

Re: [Outreachy kernel] [PATCH 3/4] staging: arch: alpha: boot: Deleted unnecessary brackets.

[Julia Lawall]

On Sat, 21 Feb 2015, Gulsah Kose wrote:

> This patch fixes "braces {} are not necessary for single statement
> blocks" checkpatch.pl warnings in bootp.c

Try to write your commit message in a way that says what you have done, 
rather than just saying that you have fixed something.  Here you could 
say: Remove unneeded braces around a single-statement if branch.

It is not necessary to mention the file name in the commit message.  That 
can be seen easily from the patch.  Likewise, you don't need to put the 
full pathname of the file in the subject line.  You can see the subect 
line that others have used by saying git log --onefile file

Also, you should not be working on files in the arch directory, only on 
files in the drivers/staging directory.  Greg will only take patches on 
drivers/staging.

julia


> Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
> ---
>  arch/alpha/boot/bootp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c
> index 27807f5..c66ea3c 100644
> --- a/arch/alpha/boot/bootp.c
> +++ b/arch/alpha/boot/bootp.c
> @@ -177,9 +177,8 @@ start_kernel(void)
>  	move_stack(initrd_start - PAGE_SIZE);
>  
>  	nbytes = callback_getenv(ENV_BOOTED_OSFLAGS, envval, sizeof(envval));
> -	if (nbytes < 0 || nbytes >= sizeof(envval)) {
> +	if (nbytes < 0 || nbytes >= sizeof(envval))
>  		nbytes = 0;
> -	}
>  	envval[nbytes] = '\0';
>  	srm_printk("Loading the kernel...'%s'\n", envval);
>  
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/41ef579e532df4325288a101ce4f9aff77aa1d93.1424551058.git.gulsah.1004%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH 0/4] Corrected four type checkpatch.pl errors and warning.

[Julia Lawall]

On Sat, 21 Feb 2015, Gulsah Kose wrote:

> This patch fixes following checkpatch.pl errors and warnings in bootp.c:
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "(foo*)" should be "(foo *)"
> WARNING: braces {} are not necessary for single statement blocks
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))

None of these will be taken because they are not in files in 
drivers/staging.

julia

> Gulsah Kose (4):
>   staging: arch: alpha: boot: Deleted unnecessary space.
>   staging: arch: alpha: boot: Added missing space before "*"
>   staging: arch: alpha: boot: Deleted unnecessary brackets.
>   staging: arch: alpha: boot: Replaced __attribute__((aligned(size)))
>     with __aligned(size).
> 
>  arch/alpha/boot/bootp.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1424551058.git.gulsah.1004%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH 3/4] staging: arch: alpha: boot: Deleted unnecessary brackets.

[Gülşah Köse]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hi Julia

2015-02-21 22:50 GMT+02:00 Julia Lawall <julia.lawall@lip6.fr>:

> On Sat, 21 Feb 2015, Gulsah Kose wrote:
>
> Also, you should not be working on files in the arch directory, only on
> files in the drivers/staging directory.
>

I was confusion in the staging directories. Thank you for early warning.

Regards

[-- Attachment #2: Type: text/html, Size: 902 bytes --]