* [PATCH 1/6] staging: rtl8192u: Remove commented header.
2015-02-22 21:39 [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Navya Sri Nizamkari
@ 2015-02-22 21:40 ` Navya Sri Nizamkari
2015-02-22 21:41 ` [PATCH 2/6] " Navya Sri Nizamkari
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-22 21:40 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the commented header <linux/config.h>
as it is not used in modern linux systems.
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
index 143b682..95f5fc7 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
@@ -9,7 +9,6 @@
* more details.
*/
-//#include <linux/config.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/6] staging: rtl8192u: Remove commented header.
2015-02-22 21:39 [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Navya Sri Nizamkari
2015-02-22 21:40 ` [PATCH 1/6] staging: rtl8192u: Remove commented header Navya Sri Nizamkari
@ 2015-02-22 21:41 ` Navya Sri Nizamkari
2015-02-22 21:41 ` [PATCH 3/6] " Navya Sri Nizamkari
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-22 21:41 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the commented header <linux/config.h>
as it is not used in modern linux systems.
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
index fcc90a5..6201712 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
@@ -9,7 +9,6 @@
* more details.
*/
-//#include <linux/config.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/6] staging: rtl8192u: Remove commented header.
2015-02-22 21:39 [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Navya Sri Nizamkari
2015-02-22 21:40 ` [PATCH 1/6] staging: rtl8192u: Remove commented header Navya Sri Nizamkari
2015-02-22 21:41 ` [PATCH 2/6] " Navya Sri Nizamkari
@ 2015-02-22 21:41 ` Navya Sri Nizamkari
2015-02-22 21:42 ` [PATCH 4/6] " Navya Sri Nizamkari
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-22 21:41 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the commented header <linux/config.h>
as it is not used in modern linux systems.
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
index 8c1bf1f..c43d0fe 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
@@ -9,7 +9,6 @@
* more details.
*/
-//#include <linux/config.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/6] staging: rtl8192u: Remove commented header.
2015-02-22 21:39 [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Navya Sri Nizamkari
` (2 preceding siblings ...)
2015-02-22 21:41 ` [PATCH 3/6] " Navya Sri Nizamkari
@ 2015-02-22 21:42 ` Navya Sri Nizamkari
2015-02-22 21:42 ` [PATCH 5/6] " Navya Sri Nizamkari
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-22 21:42 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the commented header <linux/config.h>
as it is not used in modern linux systems.
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index afbd09d..e58fb28 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -31,7 +31,6 @@
*******************************************************************************/
#include <linux/compiler.h>
-//#include <linux/config.h>
#include <linux/errno.h>
#include <linux/if_arp.h>
#include <linux/in6.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/6] staging: rtl8192u: Remove commented header.
2015-02-22 21:39 [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Navya Sri Nizamkari
` (3 preceding siblings ...)
2015-02-22 21:42 ` [PATCH 4/6] " Navya Sri Nizamkari
@ 2015-02-22 21:42 ` Navya Sri Nizamkari
2015-02-22 21:43 ` [PATCH 6/6] " Navya Sri Nizamkari
2015-02-23 9:08 ` [Outreachy kernel] [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Julia Lawall
6 siblings, 0 replies; 9+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-22 21:42 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the commented header <linux/config.h>
as it is not used in modern linux systems.
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index d401dbf..286b71d 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -22,7 +22,6 @@
#include <linux/compiler.h>
-//#include <linux/config.h>
#include <linux/errno.h>
#include <linux/if_arp.h>
#include <linux/in6.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 6/6] staging: rtl8192u: Remove commented header.
2015-02-22 21:39 [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Navya Sri Nizamkari
` (4 preceding siblings ...)
2015-02-22 21:42 ` [PATCH 5/6] " Navya Sri Nizamkari
@ 2015-02-22 21:43 ` Navya Sri Nizamkari
2015-02-23 9:08 ` [Outreachy kernel] [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Julia Lawall
6 siblings, 0 replies; 9+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-22 21:43 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the commented header <linux/config.h>
as it is not used in modern linux systems.
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
index fca73c7..96ab304 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
@@ -32,7 +32,6 @@
******************************************************************************/
#include <linux/compiler.h>
-//#include <linux/config.h>
#include <linux/errno.h>
#include <linux/if_arp.h>
#include <linux/in6.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [Outreachy kernel] [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style.
2015-02-22 21:39 [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Navya Sri Nizamkari
` (5 preceding siblings ...)
2015-02-22 21:43 ` [PATCH 6/6] " Navya Sri Nizamkari
@ 2015-02-23 9:08 ` Julia Lawall
2015-02-23 10:12 ` Arnd Bergmann
6 siblings, 1 reply; 9+ messages in thread
From: Julia Lawall @ 2015-02-23 9:08 UTC (permalink / raw)
To: Navya Sri Nizamkari; +Cc: outreachy-kernel
On Mon, 23 Feb 2015, Navya Sri Nizamkari wrote:
> This patchset improves the code style in files of ieee80211
> by removing the header <linux/config.h> which is commented
> out as it is not used in modern linux system.
> This change was suggested by Arnd Bergmann.
Nice to get rid of them all at once :)
julia
> Navya Sri Nizamkari (6):
> staging: rtl8192u: Remove commented header.
> staging: rtl8192u: Remove commented header.
> staging: rtl8192u: Remove commented header.
> staging: rtl8192u: Remove commented header.
> staging: rtl8192u: Remove commented header.
> staging: rtl8192u: Remove commented header.
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 1 -
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 1 -
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 1 -
> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 -
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 1 -
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 1 -
> 6 files changed, 6 deletions(-)
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1424640704.git.navyasri.tech%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Outreachy kernel] [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style.
2015-02-23 9:08 ` [Outreachy kernel] [PATCH 0/6] staging: rtl8192u: Remove commented header to improve code style Julia Lawall
@ 2015-02-23 10:12 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-02-23 10:12 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Julia Lawall, Navya Sri Nizamkari
On Monday 23 February 2015 10:08:05 Julia Lawall wrote:
> On Mon, 23 Feb 2015, Navya Sri Nizamkari wrote:
>
> > This patchset improves the code style in files of ieee80211
> > by removing the header <linux/config.h> which is commented
> > out as it is not used in modern linux system.
> > This change was suggested by Arnd Bergmann.
>
> Nice to get rid of them all at once
>
All patches:
Acked-by: Arnd Bergmann <arnd@arndb.de>
Since the changes are all identical and trivial, and all in one driver,
I would suggest you do a single combined patch for them, but if Greg
wants to take this version, I'm fine with it too.
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread