From: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
outreachy-kernel@googlegroups.com
Subject: [PATCH v3 0/5] Fix coding style issues
Date: Sun, 1 Mar 2015 03:08:49 +0300 [thread overview]
Message-ID: <cover.1425168388.git.hamohammed.sa@gmail.com> (raw)
This patchset fixes the following coding style issues found by checkpatch.pl:
- Line over 80 charachters.
- Trailing statement should be on next line.
- Extern should be avoided in .c files.
- Else is not useful after return.
- Strings are generally beter as one
Changes in v3:
- Split [PATCH 4/5] and return one removal of else to original, for it produces compilation warning: mixed declaration and code. better resolve in separate patch.
- Edit subject line appropriately
Changes in v2:
- Edit subject line.
Haneen Mohammed (5):
Staging: lustre: Fix line over 80 characters
Staging: lustre: Move trailing statement to next line
Staging: lustre: Fix externs should be avoided in .c
Staging: lustre: Remove unnecessary else after return
Staging: lustre: Concatenate strings into single string
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 9 ++--
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 3 +-
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 3 +-
drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 2 +
drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 4 +-
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 56 ++++++++++++++--------
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 12 +++--
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 20 ++++----
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 12 +++--
9 files changed, 76 insertions(+), 45 deletions(-)
--
1.9.1
next reply other threads:[~2015-03-01 0:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 0:08 Haneen Mohammed [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-02-28 22:04 [PATCH v2 5/5] Staging: lustre: Concatenate strings into single string Haneen Mohammed
2015-03-01 0:16 ` [PATCH v3 0/5] Fix coding style issues Haneen Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1425168388.git.hamohammed.sa@gmail.com \
--to=hamohammed.sa@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.