All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/5] Fix coding style issues
@ 2015-03-01  0:08 Haneen Mohammed
  0 siblings, 0 replies; 2+ messages in thread
From: Haneen Mohammed @ 2015-03-01  0:08 UTC (permalink / raw)
  Cc: Haneen Mohammed, outreachy-kernel

This patchset fixes the following coding style issues found by checkpatch.pl:
- Line over 80 charachters.
- Trailing statement should be on next line.
- Extern should be avoided in .c files.
- Else is not useful after return.
- Strings are generally beter as one

Changes in v3:
- Split [PATCH 4/5] and return one removal of else to original, for it produces compilation warning: mixed declaration and code. better resolve in separate patch.
- Edit subject line appropriately

Changes in v2:
- Edit subject line.
 
Haneen Mohammed (5):
  Staging: lustre: Fix line over 80 characters
  Staging: lustre: Move trailing statement to next line
  Staging: lustre: Fix externs should be avoided in .c
  Staging: lustre: Remove unnecessary else after return
  Staging: lustre: Concatenate strings into single string

 drivers/staging/lustre/lustre/ldlm/interval_tree.c |  9 ++--
 drivers/staging/lustre/lustre/ldlm/ldlm_extent.c   |  3 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_flock.c    |  3 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_internal.h |  2 +
 drivers/staging/lustre/lustre/ldlm/ldlm_lib.c      |  4 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_lock.c     | 56 ++++++++++++++--------
 drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c    | 12 +++--
 drivers/staging/lustre/lustre/ldlm/ldlm_pool.c     | 20 ++++----
 drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 12 +++--
 9 files changed, 76 insertions(+), 45 deletions(-)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 2+ messages in thread
* [PATCH v2 5/5] Staging: lustre: Concatenate strings into single string
@ 2015-02-28 22:04 Haneen Mohammed
  2015-03-01  0:16 ` [PATCH v3 0/5] Fix coding style issues Haneen Mohammed
  0 siblings, 1 reply; 2+ messages in thread
From: Haneen Mohammed @ 2015-02-28 22:04 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Haneen Mohammed

This patch concatenate two consecutive strings into one, addressing checkpatch.pl warning:
 "Consecutive strings are generally better as a single string"

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
 drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index bfdb2b3..0d65d80 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
@@ -688,8 +688,8 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
 			      "  GP:  %d\n",
 			      grant_step, grant_plan);
 	}
-	seq_printf(m, "  GR:  %d\n" "  CR:  %d\n" "  GS:  %d\n"
-		      "  G:   %d\n" "  L:   %d\n",
+	seq_printf(m, "  GR:  %d\n  CR:  %d\n  GS:  %d\n"
+		      "  G:   %d\n  L:   %d\n",
 		      grant_rate, cancel_rate, grant_speed,
 		      granted, limit);
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-01  0:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-01  0:08 [PATCH v3 0/5] Fix coding style issues Haneen Mohammed
  -- strict thread matches above, loose matches on Subject: below --
2015-02-28 22:04 [PATCH v2 5/5] Staging: lustre: Concatenate strings into single string Haneen Mohammed
2015-03-01  0:16 ` [PATCH v3 0/5] Fix coding style issues Haneen Mohammed

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.