* [PATCH 0/3] staging: remove break after return
@ 2015-03-13 7:58 Supriya Karanth
2015-03-13 7:58 ` [PATCH 1/3] staging: rtl8188eu: " Supriya Karanth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Supriya Karanth @ 2015-03-13 7:58 UTC (permalink / raw)
To: iskaranth, outreachy-kernel
This patchset removes the "break" statement after a "return"
statement as it will not get executed.
Found by checkpatch.pl - break is not useful after a goto
or return
Supriya Karanth (3):
staging: rtl8188eu: remove break after return
staging: rtl8192e: remove break after return
staging: rtl8192u: remove break after return
drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 1 -
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 1 -
drivers/staging/rtl8192e/rtllib_softmac.c | 1 -
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 1 -
4 files changed, 4 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] staging: rtl8188eu: remove break after return
2015-03-13 7:58 [PATCH 0/3] staging: remove break after return Supriya Karanth
@ 2015-03-13 7:58 ` Supriya Karanth
2015-03-13 7:58 ` [PATCH 2/3] staging: rtl8192e: " Supriya Karanth
2015-03-13 7:58 ` [PATCH 3/3] staging: rtl8192u: " Supriya Karanth
2 siblings, 0 replies; 4+ messages in thread
From: Supriya Karanth @ 2015-03-13 7:58 UTC (permalink / raw)
To: iskaranth, outreachy-kernel
Remove "break" statement after a "return" statement as
it does not get executed.
Found by checkpatch.pl - break is not useful after a goto
or return
Signed-off-by: Supriya Karanth <iskaranth@gmail.com>
---
drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/pwrseqcmd.c b/drivers/staging/rtl8188eu/hal/pwrseqcmd.c
index be0663e..73e1f8b 100644
--- a/drivers/staging/rtl8188eu/hal/pwrseqcmd.c
+++ b/drivers/staging/rtl8188eu/hal/pwrseqcmd.c
@@ -109,7 +109,6 @@ u8 rtl88eu_pwrseqcmdparsing(struct adapter *padapter, u8 cut_vers, u8 fab_vers,
RT_TRACE(_module_hal_init_c_, _drv_info_,
("rtl88eu_pwrseqcmdparsing: PWR_CMD_END\n"));
return true;
- break;
default:
RT_TRACE(_module_hal_init_c_, _drv_err_,
("rtl88eu_pwrseqcmdparsing: Unknown CMD!!\n"));
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] staging: rtl8192e: remove break after return
2015-03-13 7:58 [PATCH 0/3] staging: remove break after return Supriya Karanth
2015-03-13 7:58 ` [PATCH 1/3] staging: rtl8188eu: " Supriya Karanth
@ 2015-03-13 7:58 ` Supriya Karanth
2015-03-13 7:58 ` [PATCH 3/3] staging: rtl8192u: " Supriya Karanth
2 siblings, 0 replies; 4+ messages in thread
From: Supriya Karanth @ 2015-03-13 7:58 UTC (permalink / raw)
To: iskaranth, outreachy-kernel
Remove "break" statement after a "return" statement as
it does not get executed.
Found by checkpatch.pl - break is not useful after a goto
or return
Signed-off-by: Supriya Karanth <iskaranth@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 1 -
drivers/staging/rtl8192e/rtllib_softmac.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index cd3c662..a369a1f 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -920,7 +920,6 @@ static u8 rtl8192_phy_SwChnlStepByStep(struct net_device *dev, u8 channel,
RT_TRACE(COMP_ERR, "Unknown RFChipID: %d\n",
priv->rf_chip);
return false;
- break;
}
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 16aef7c..2e730b5 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -2450,7 +2450,6 @@ inline int rtllib_rx_frame_softmac(struct rtllib_device *ieee,
break;
default:
return -1;
- break;
}
return 0;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] staging: rtl8192u: remove break after return
2015-03-13 7:58 [PATCH 0/3] staging: remove break after return Supriya Karanth
2015-03-13 7:58 ` [PATCH 1/3] staging: rtl8188eu: " Supriya Karanth
2015-03-13 7:58 ` [PATCH 2/3] staging: rtl8192e: " Supriya Karanth
@ 2015-03-13 7:58 ` Supriya Karanth
2 siblings, 0 replies; 4+ messages in thread
From: Supriya Karanth @ 2015-03-13 7:58 UTC (permalink / raw)
To: iskaranth, outreachy-kernel
Remove "break" statement after a "return" statement as
it does not get executed.
Found by checkpatch.pl - break is not useful after a goto
or return
Signed-off-by: Supriya Karanth <iskaranth@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index 878086a..5106b60 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -2110,7 +2110,6 @@ ieee80211_rx_frame_softmac(struct ieee80211_device *ieee, struct sk_buff *skb,
break;
default:
return -1;
- break;
}
//dev_kfree_skb_any(skb);
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-13 7:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-13 7:58 [PATCH 0/3] staging: remove break after return Supriya Karanth
2015-03-13 7:58 ` [PATCH 1/3] staging: rtl8188eu: " Supriya Karanth
2015-03-13 7:58 ` [PATCH 2/3] staging: rtl8192e: " Supriya Karanth
2015-03-13 7:58 ` [PATCH 3/3] staging: rtl8192u: " Supriya Karanth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.