All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] v2: Fix presentation issues on "all builds" page
@ 2015-09-08  9:47 Elliot Smith
  2015-09-08  9:47 ` [PATCH 1/3] toaster: remove unnecessary white space Elliot Smith
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Elliot Smith @ 2015-09-08  9:47 UTC (permalink / raw)
  To: bitbake-devel

This branch fixes some small presentation issues in the all builds page.

Note that this patch series supersedes the previous one with the same
title, as that one lacked the correct "Signed-off-by" footers.

The following changes since commit c1df471feacaf2590216aa476ce242908dac38cf:

  pseudo_1.7.3.bb: New version of pseudo (2015-09-06 15:26:27 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib elliot/submit/bbarrosp/all-builds
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/submit/bbarrosp/all-builds

Belen Barros Pena (3):
  toaster: remove unnecessary white space
  toaster: fix project names in latest builds
  toaster: replace ETA with % of tasks done

 lib/toaster/toastergui/templates/mrb_section.html | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

--
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] toaster: remove unnecessary white space
  2015-09-08  9:47 [PATCH 0/3] v2: Fix presentation issues on "all builds" page Elliot Smith
@ 2015-09-08  9:47 ` Elliot Smith
  2015-09-08  9:47 ` [PATCH 2/3] toaster: fix project names in latest builds Elliot Smith
  2015-09-08  9:47 ` [PATCH 3/3] toaster: replace ETA with % of tasks done Elliot Smith
  2 siblings, 0 replies; 4+ messages in thread
From: Elliot Smith @ 2015-09-08  9:47 UTC (permalink / raw)
  To: bitbake-devel

From: Belen Barros Pena <belen.barros.pena@intel.com>

There was too much white space above the first
heading in the all builds page. This patch removes
the class that was adding the extra space.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Elliot Smith <elliot.smith@intel.com>
---
 lib/toaster/toastergui/templates/mrb_section.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/toaster/toastergui/templates/mrb_section.html b/lib/toaster/toastergui/templates/mrb_section.html
index d37b694..903635d 100644
--- a/lib/toaster/toastergui/templates/mrb_section.html
+++ b/lib/toaster/toastergui/templates/mrb_section.html
@@ -5,7 +5,7 @@
 
 {%if mru.count > 0%}
 
-  <div class="page-header top-air">
+  <div class="page-header">
       <h1>
           Latest builds
        </h1>
-- 
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] toaster: fix project names in latest builds
  2015-09-08  9:47 [PATCH 0/3] v2: Fix presentation issues on "all builds" page Elliot Smith
  2015-09-08  9:47 ` [PATCH 1/3] toaster: remove unnecessary white space Elliot Smith
@ 2015-09-08  9:47 ` Elliot Smith
  2015-09-08  9:47 ` [PATCH 3/3] toaster: replace ETA with % of tasks done Elliot Smith
  2 siblings, 0 replies; 4+ messages in thread
From: Elliot Smith @ 2015-09-08  9:47 UTC (permalink / raw)
  To: bitbake-devel

From: Belen Barros Pena <belen.barros.pena@intel.com>

Make sure that the project name we show for each build
in the latest builds section of the all builds page:

* Has the same styles as the build, depending on the
build status (in progress, failed or success)

* Links to the project page

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Elliot Smith <elliot.smith@intel.com>
---
 lib/toaster/toastergui/templates/mrb_section.html | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/toaster/toastergui/templates/mrb_section.html b/lib/toaster/toastergui/templates/mrb_section.html
index 903635d..57a6f9b 100644
--- a/lib/toaster/toastergui/templates/mrb_section.html
+++ b/lib/toaster/toastergui/templates/mrb_section.html
@@ -13,7 +13,11 @@
   <div id="latest-builds">
   {% for build in mru %}
     <div class="alert {%if build.outcome == build.SUCCEEDED%}alert-success{%elif build.outcome == build.FAILED%}alert-error{%else%}alert-info{%endif%} project-name ">
-       <span class="label {%if build.outcome == build.SUCCEEDED%}label-success{%elif build.outcome == build.FAILED%}label-danger{%else%}label-info{%endif%}"> {{build.project.name}} </span>
+       <span class="label {%if build.outcome == build.SUCCEEDED%}label-success{%elif build.outcome == build.FAILED%}label-important{%else%}label-info{%endif%}">
+         <a href={% url 'project' build.project.pk %}>
+           {{build.project.name}}
+         </a>
+       </span>
 
         <div class="row-fluid">
             <div class="span3 lead">
-- 
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] toaster: replace ETA with % of tasks done
  2015-09-08  9:47 [PATCH 0/3] v2: Fix presentation issues on "all builds" page Elliot Smith
  2015-09-08  9:47 ` [PATCH 1/3] toaster: remove unnecessary white space Elliot Smith
  2015-09-08  9:47 ` [PATCH 2/3] toaster: fix project names in latest builds Elliot Smith
@ 2015-09-08  9:47 ` Elliot Smith
  2 siblings, 0 replies; 4+ messages in thread
From: Elliot Smith @ 2015-09-08  9:47 UTC (permalink / raw)
  To: bitbake-devel

From: Belen Barros Pena <belen.barros.pena@intel.com>

The ETA we show for builds in progress is woefully
inaccurate. In the 1.8 release we replaced it with
the % of tasks completed. Somehow, we regressed to
the ETA, so bringing the task % back.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Elliot Smith <elliot.smith@intel.com>
---
 lib/toaster/toastergui/templates/mrb_section.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/toaster/toastergui/templates/mrb_section.html b/lib/toaster/toastergui/templates/mrb_section.html
index 57a6f9b..396fb8e 100644
--- a/lib/toaster/toastergui/templates/mrb_section.html
+++ b/lib/toaster/toastergui/templates/mrb_section.html
@@ -84,7 +84,7 @@
                     <div style="width: {{build.completeper}}%;" class="bar"></div>
                 </div>
             </div>
-            <div class="lead pull-right">ETA: in {{build.eta|naturaltime}}</div>
+            <div class="lead pull-right">{{build.completeper}}% of tasks complete</div>
     {%endif%}
         </div>
     </div>
-- 
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-08  9:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-08  9:47 [PATCH 0/3] v2: Fix presentation issues on "all builds" page Elliot Smith
2015-09-08  9:47 ` [PATCH 1/3] toaster: remove unnecessary white space Elliot Smith
2015-09-08  9:47 ` [PATCH 2/3] toaster: fix project names in latest builds Elliot Smith
2015-09-08  9:47 ` [PATCH 3/3] toaster: replace ETA with % of tasks done Elliot Smith

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.