* [PATCH 0/2] Fix coding style issues and a consistence change.
@ 2015-09-09 18:00 Maitesin
2015-09-09 18:00 ` [PATCH 1/2] fs: isofs: Fix a coding style issue and change conditional to make it consistence Maitesin
2015-09-09 18:00 ` [PATCH 2/2] fs: isofs: Fix several coding style issues Maitesin
0 siblings, 2 replies; 3+ messages in thread
From: Maitesin @ 2015-09-09 18:00 UTC (permalink / raw)
To: linux-kernel; +Cc: Maitesin
Some fixes for coding style issues and consistence in a conditional.
Maitesin (2):
fs: isofs: Fix a coding style issue and change conditional to make it
consistence
fs: isofs: Fix several coding style issues
fs/isofs/compress.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 1/2] fs: isofs: Fix a coding style issue and change conditional to make it consistence 2015-09-09 18:00 [PATCH 0/2] Fix coding style issues and a consistence change Maitesin @ 2015-09-09 18:00 ` Maitesin 2015-09-09 18:00 ` [PATCH 2/2] fs: isofs: Fix several coding style issues Maitesin 1 sibling, 0 replies; 3+ messages in thread From: Maitesin @ 2015-09-09 18:00 UTC (permalink / raw) To: linux-kernel; +Cc: Maitesin, Oscar Forner Martinez The coding style issue is the white spaces after and before the brackets in the for. The change in the conditional is to make it consistence with the other ones in the file. All other conditionals are tested like that. Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com> --- fs/isofs/compress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c index f311bf0..5750830 100644 --- a/fs/isofs/compress.c +++ b/fs/isofs/compress.c @@ -66,8 +66,8 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, return 0; } /* Empty block? */ - if (block_size == 0) { - for ( i = 0 ; i < pcount ; i++ ) { + if (!block_size) { + for (i = 0 ; i < pcount ; i++) { if (!pages[i]) continue; memset(page_address(pages[i]), 0, PAGE_CACHE_SIZE); -- 2.5.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] fs: isofs: Fix several coding style issues 2015-09-09 18:00 [PATCH 0/2] Fix coding style issues and a consistence change Maitesin 2015-09-09 18:00 ` [PATCH 1/2] fs: isofs: Fix a coding style issue and change conditional to make it consistence Maitesin @ 2015-09-09 18:00 ` Maitesin 1 sibling, 0 replies; 3+ messages in thread From: Maitesin @ 2015-09-09 18:00 UTC (permalink / raw) To: linux-kernel; +Cc: Maitesin, Oscar Forner Martinez As recommended I fixed several coding style issues related with whitespaces. Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com> --- fs/isofs/compress.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c index 5750830..107a078 100644 --- a/fs/isofs/compress.c +++ b/fs/isofs/compress.c @@ -67,7 +67,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, } /* Empty block? */ if (!block_size) { - for (i = 0 ; i < pcount ; i++) { + for (i = 0; i < pcount; i++) { if (!pages[i]) continue; memset(page_address(pages[i]), 0, PAGE_CACHE_SIZE); @@ -103,7 +103,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, stream.workspace = zisofs_zlib_workspace; mutex_lock(&zisofs_zlib_lock); - + zerr = zlib_inflateInit(&stream); if (zerr != Z_OK) { if (zerr == Z_MEM_ERROR) @@ -134,7 +134,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, *errp = -EIO; break; } - stream.next_in = bhs[curbh]->b_data + + stream.next_in = bhs[curbh]->b_data + (block_start & bufmask); stream.avail_in = min_t(unsigned, bufsize - (block_start & bufmask), @@ -353,7 +353,7 @@ static int zisofs_readpage(struct file *file, struct page *page) if (i != full_page) page_cache_release(pages[i]); } - } + } /* At this point, err contains 0 or -EIO depending on the "critical" page */ return err; @@ -368,9 +368,8 @@ const struct address_space_operations zisofs_aops = { int __init zisofs_init(void) { zisofs_zlib_workspace = vmalloc(zlib_inflate_workspacesize()); - if ( !zisofs_zlib_workspace ) + if (!zisofs_zlib_workspace) return -ENOMEM; - return 0; } -- 2.5.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-09 18:01 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-09-09 18:00 [PATCH 0/2] Fix coding style issues and a consistence change Maitesin 2015-09-09 18:00 ` [PATCH 1/2] fs: isofs: Fix a coding style issue and change conditional to make it consistence Maitesin 2015-09-09 18:00 ` [PATCH 2/2] fs: isofs: Fix several coding style issues Maitesin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.