[PATCH 0/3] Fix multiple checkpatch issues

[PATCH 0/3] Fix multiple checkpatch issues

[Amitoj Kaur Chawla]

This patchset fixes multiple issues found using checkpatch.pl

Amitoj Kaur Chawla (3):
  staging: sm750fb: Remove space after cast
  staging: sm750fb: Remove space before closing brace
  staging: sm750fb: Remove space after opening brace

 drivers/staging/sm750fb/ddk750_chip.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
1.9.1

[PATCH 1/3] staging: sm750fb: Remove space after cast

[Amitoj Kaur Chawla]

Remove unnecessary space after cast. Problem found using checkpatch.pl
CHECK: No space is necessary after a cast

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 270d10b..e797b5b 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -133,7 +133,7 @@ static void setMemoryClock(unsigned int frequency)
 			frequency = MHz(336);
 
 		/* Calculate the divisor */
-		divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+		divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		ulReg = PEEK32(CURRENT_GATE);
@@ -180,7 +180,7 @@ static void setMasterClock(unsigned int frequency)
 			frequency = MHz(190);
 
 		/* Calculate the divisor */
-		divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+		divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		ulReg = PEEK32(CURRENT_GATE);
-- 
1.9.1

[PATCH 2/3] staging: sm750fb: Remove space before closing brace

[Amitoj Kaur Chawla]

Remove space before closing brace '}'. Problem found using
checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index e797b5b..ebc3242 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -234,7 +234,6 @@ unsigned int ddk750_getVMSize(void)
 		break;
 	}
 	return data;
-
 }
 
 int ddk750_initHw(initchip_param_t *pInitParam)
-- 
1.9.1

[PATCH 3/3] staging: sm750fb: Remove space after opening brace

[Amitoj Kaur Chawla]

Remove space after opening brace '{'. Problem found using
checkpatch.pl
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index ebc3242..6f05f78 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
 
 int ddk750_initHw(initchip_param_t *pInitParam)
 {
-
 	unsigned int ulReg;
 
 <<<<<<< HEAD
-- 
1.9.1

Re: [Outreachy kernel] [PATCH 3/3] staging: sm750fb: Remove space after opening brace

[Julia Lawall]

On Fri, 9 Oct 2015, Amitoj Kaur Chawla wrote:

> Remove space after opening brace '{'. Problem found using
> checkpatch.pl
> CHECK: Blank lines aren't necessary after an open brace '{'
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index ebc3242..6f05f78 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
>  
>  int ddk750_initHw(initchip_param_t *pInitParam)
>  {
> -
>  	unsigned int ulReg;
>  
>  <<<<<<< HEAD

Something went wrong here.

julia

> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/65d703974d96550d8802203b4243da28797ae8bf.1444332001.git.amitoj1606%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH 3/3] staging: sm750fb: Remove space after opening brace

[Amitoj Kaur Chawla]

On Fri, Oct 9, 2015 at 1:03 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Fri, 9 Oct 2015, Amitoj Kaur Chawla wrote:
>
>> Remove space after opening brace '{'. Problem found using
>> checkpatch.pl
>> CHECK: Blank lines aren't necessary after an open brace '{'
>>
>> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>> ---
>>  drivers/staging/sm750fb/ddk750_chip.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
>> index ebc3242..6f05f78 100644
>> --- a/drivers/staging/sm750fb/ddk750_chip.c
>> +++ b/drivers/staging/sm750fb/ddk750_chip.c
>> @@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
>>
>>  int ddk750_initHw(initchip_param_t *pInitParam)
>>  {
>> -
>>       unsigned int ulReg;
>>
>>  <<<<<<< HEAD
>
> Something went wrong here.
>

I just saw. This last line. HEAD. I'll look into this!

Thanks,

Amitoj

[PATCH 0/3] Fix multiple checkpatch issues

[Gargi Sharma]

This file fixes multiple checkpatch issues in pid_namespace.c file.

Gargi Sharma (3):
  kernel: pid_namespace: Remove return statement from void function
  kernel: pid_namespace: Fix line over 80 characters
  kernel: pid_namespace: Do not initialise statics to 0

 kernel/pid_namespace.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.7.4