* [PATCH v2 0/3] Fix multiple checkpatch issues
@ 2015-10-08 21:37 Amitoj Kaur Chawla
2015-10-08 21:40 ` [PATCH v2 1/3] staging: sm750fb: Remove space after cast Amitoj Kaur Chawla
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-08 21:37 UTC (permalink / raw)
To: outreachy-kernel
This patchset fixes multiple issues found using checkpatch.pl
Amitoj Kaur Chawla (3):
staging: sm750fb: Remove space after cast
staging: sm750fb: Remove space before closing brace
staging: sm750fb: Remove space after opening brace
drivers/staging/sm750fb/ddk750_chip.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/3] staging: sm750fb: Remove space after cast
2015-10-08 21:37 [PATCH v2 0/3] Fix multiple checkpatch issues Amitoj Kaur Chawla
@ 2015-10-08 21:40 ` Amitoj Kaur Chawla
2015-10-08 21:41 ` [PATCH v2 2/3] staging: sm750fb: Remove space before closing brace Amitoj Kaur Chawla
2015-10-08 21:45 ` [PATCH v2 3/3] staging: sm750fb: Remove space after opening brace Amitoj Kaur Chawla
2 siblings, 0 replies; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-08 21:40 UTC (permalink / raw)
To: outreachy-kernel
Remove unnecessary space after cast. Problem found using checkpatch.pl
CHECK: No space is necessary after a cast
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2
-None
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 0734044..fe0e25a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -133,7 +133,7 @@ static void setMemoryClock(unsigned int frequency)
frequency = MHz(336);
/* Calculate the divisor */
- divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+ divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
/* Set the corresponding divisor in the register. */
ulReg = PEEK32(CURRENT_GATE);
@@ -180,7 +180,7 @@ static void setMasterClock(unsigned int frequency)
frequency = MHz(190);
/* Calculate the divisor */
- divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+ divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
/* Set the corresponding divisor in the register. */
ulReg = PEEK32(CURRENT_GATE);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 2/3] staging: sm750fb: Remove space before closing brace
2015-10-08 21:37 [PATCH v2 0/3] Fix multiple checkpatch issues Amitoj Kaur Chawla
2015-10-08 21:40 ` [PATCH v2 1/3] staging: sm750fb: Remove space after cast Amitoj Kaur Chawla
@ 2015-10-08 21:41 ` Amitoj Kaur Chawla
2015-10-08 21:45 ` [PATCH v2 3/3] staging: sm750fb: Remove space after opening brace Amitoj Kaur Chawla
2 siblings, 0 replies; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-08 21:41 UTC (permalink / raw)
To: outreachy-kernel
Remove space before closing brace '}'. Problem found using
checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
-None
drivers/staging/sm750fb/ddk750_chip.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index fe0e25a..deee227 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -234,7 +234,6 @@ unsigned int ddk750_getVMSize(void)
break;
}
return data;
-
}
int ddk750_initHw(initchip_param_t *pInitParam)
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 3/3] staging: sm750fb: Remove space after opening brace
2015-10-08 21:37 [PATCH v2 0/3] Fix multiple checkpatch issues Amitoj Kaur Chawla
2015-10-08 21:40 ` [PATCH v2 1/3] staging: sm750fb: Remove space after cast Amitoj Kaur Chawla
2015-10-08 21:41 ` [PATCH v2 2/3] staging: sm750fb: Remove space before closing brace Amitoj Kaur Chawla
@ 2015-10-08 21:45 ` Amitoj Kaur Chawla
2 siblings, 0 replies; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-08 21:45 UTC (permalink / raw)
To: outreachy-kernel
Remove space after opening brace '{'. Problem found using
checkpatch.pl
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
-Updated kernel tree to remove error
drivers/staging/sm750fb/ddk750_chip.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index deee227..a15bcd1 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
int ddk750_initHw(initchip_param_t *pInitParam)
{
-
unsigned int ulReg;
if (pInitParam->powerMode != 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 0/3] Fix multiple checkpatch issues
@ 2017-03-27 19:45 Gargi Sharma
0 siblings, 0 replies; 5+ messages in thread
From: Gargi Sharma @ 2017-03-27 19:45 UTC (permalink / raw)
To: mawilcox; +Cc: outreachy-kernel, Gargi Sharma
This patchset fixes multiple checkpatch issues
in pid_namespace.c file.
---
Changes in v2:
Patch 1
- Fix splitting of line for better readablilty.
Gargi Sharma (3):
kernel: pid_namespace: Fix line over 80 characters
kernel: pid_namespace: Do not initialise statics to 0
kernel: pid_namespace: Remove return statement from void function
kernel/pid_namespace.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-27 19:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-08 21:37 [PATCH v2 0/3] Fix multiple checkpatch issues Amitoj Kaur Chawla
2015-10-08 21:40 ` [PATCH v2 1/3] staging: sm750fb: Remove space after cast Amitoj Kaur Chawla
2015-10-08 21:41 ` [PATCH v2 2/3] staging: sm750fb: Remove space before closing brace Amitoj Kaur Chawla
2015-10-08 21:45 ` [PATCH v2 3/3] staging: sm750fb: Remove space after opening brace Amitoj Kaur Chawla
-- strict thread matches above, loose matches on Subject: below --
2017-03-27 19:45 [PATCH v2 0/3] Fix multiple checkpatch issues Gargi Sharma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.