[PATCH v2 0/2] Fix coding style

[PATCH v2 0/2] Fix coding style

[Shivani Bhardwaj]

This patch fixes the warnings and errors generated by checkpatch
about extra/missing characters.
After applying this patch, file has less warnings and errors.

Changes in v2:
	-Make the commit message better and clearer.

Shivani Bhardwaj (2):
  Staging: vt6655: rxtx: Remove unnecessary space character
  Staging: vt6655: rxtx: Remove unnecessary parentheses

 drivers/staging/vt6655/rxtx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.1.0

[PATCH v2 1/2] Staging: vt6655: rxtx: Remove unnecessary space character

[Shivani Bhardwaj]

Remove unnecessary space character after the variable RATE_16M.
Fixes the warning by checkpatch : space prohibited before
that ',' (ctx:WxW)

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
Changes in v2:
	-Make the commit message better and clearer.

 drivers/staging/vt6655/rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 5875d65..a909128 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
 };
 static const unsigned short wFB_Opt1[2][5] = {
 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
-	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+	{RATE_6M, RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
 };
 
 #define RTSDUR_BB       0
-- 
2.1.0

[PATCH v2 2/2] Staging: vt6655: rxtx: Remove unnecessary parentheses

[Shivani Bhardwaj]

Remove extra parentheses around if test expressions.
Fixes checkpatch warning : unnecessary parentheses

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
Changes in v2:
	-Make the commit message better and clearer.

 drivers/staging/vt6655/rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index a909128..3eb8f29 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -566,7 +566,7 @@ s_uFillDataHead(
 			return buf->duration_a;
 		} /* if (byFBOption == AUTO_FB_NONE) */
 	} else if (byPktType == PK_TYPE_11A) {
-		if ((byFBOption != AUTO_FB_NONE)) {
+		if (byFBOption != AUTO_FB_NONE) {
 			/* Auto Fallback */
 			struct vnt_tx_datahead_a_fb *buf = pTxDataHead;
 			/* Get SignalField, ServiceField & Length */
@@ -1008,7 +1008,7 @@ s_vGenerateTxParameter(
 			buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11A, cbFrameSize, wCurrentRate, bNeedACK);
 		}
 	} else if (byPktType == PK_TYPE_11B) {
-		if ((pvRTS != NULL)) {/* RTS_need, non PCF mode */
+		if (pvRTS != NULL) {/* RTS_need, non PCF mode */
 			struct vnt_rrv_time_ab *buf = pvRrvTime;
 
 			buf->rts_rrv_time = s_uGetRTSCTSRsvTime(pDevice, 0, byPktType, cbFrameSize, wCurrentRate);
-- 
2.1.0

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: vt6655: rxtx: Remove unnecessary space character

[Julia Lawall]

On Sat, 10 Oct 2015, Shivani Bhardwaj wrote:

> Remove unnecessary space character after the variable RATE_16M.
> Fixes the warning by checkpatch : space prohibited before
> that ',' (ctx:WxW)
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> Changes in v2:
> 	-Make the commit message better and clearer.
> 
>  drivers/staging/vt6655/rxtx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 5875d65..a909128 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
>  };
>  static const unsigned short wFB_Opt1[2][5] = {
>  	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
> -	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> +	{RATE_6M, RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */

It looks lik ethere was a goal to get the constants and comment to line 
up, which doesn't seem to occur any more.  Maybe you could move the comma 
without breaking the alignment.

julia

>  };
>  
>  #define RTSDUR_BB       0
> -- 
> 2.1.0
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0e904876eb0c4ce2c937f9b1c54afb1039ac83c6.1444469447.git.shivanib134%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: vt6655: rxtx: Remove unnecessary space character

[Shivani Bhardwaj]

On Sat, Oct 10, 2015 at 3:53 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Sat, 10 Oct 2015, Shivani Bhardwaj wrote:
>
>> Remove unnecessary space character after the variable RATE_16M.
>> Fixes the warning by checkpatch : space prohibited before
>> that ',' (ctx:WxW)
>>
>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> ---
>> Changes in v2:
>>       -Make the commit message better and clearer.
>>
>>  drivers/staging/vt6655/rxtx.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
>> index 5875d65..a909128 100644
>> --- a/drivers/staging/vt6655/rxtx.c
>> +++ b/drivers/staging/vt6655/rxtx.c
>> @@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
>>  };
>>  static const unsigned short wFB_Opt1[2][5] = {
>>       {RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
>> -     {RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
>> +     {RATE_6M, RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
>
> It looks lik ethere was a goal to get the constants and comment to line
> up, which doesn't seem to occur any more.  Maybe you could move the comma
> without breaking the alignment.
>
> julia
>

How has the alignment been disturbed here, I do not understand. Can
you please tell, Julia?

>>  };
>>
>>  #define RTSDUR_BB       0
>> --
>> 2.1.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0e904876eb0c4ce2c937f9b1c54afb1039ac83c6.1444469447.git.shivanib134%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: vt6655: rxtx: Remove unnecessary space character

[Julia Lawall]

On Sun, 11 Oct 2015, Shivani Bhardwaj wrote:

> On Sat, Oct 10, 2015 at 3:53 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > On Sat, 10 Oct 2015, Shivani Bhardwaj wrote:
> >
> >> Remove unnecessary space character after the variable RATE_16M.
> >> Fixes the warning by checkpatch : space prohibited before
> >> that ',' (ctx:WxW)
> >>
> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> >> ---
> >> Changes in v2:
> >>       -Make the commit message better and clearer.
> >>
> >>  drivers/staging/vt6655/rxtx.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> >> index 5875d65..a909128 100644
> >> --- a/drivers/staging/vt6655/rxtx.c
> >> +++ b/drivers/staging/vt6655/rxtx.c
> >> @@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
> >>  };
> >>  static const unsigned short wFB_Opt1[2][5] = {
> >>       {RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
> >> -     {RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> >> +     {RATE_6M, RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> >
> > It looks lik ethere was a goal to get the constants and comment to line
> > up, which doesn't seem to occur any more.  Maybe you could move the comma
> > without breaking the alignment.
> >
> > julia
> >
> 
> How has the alignment been disturbed here, I do not understand. Can
> you please tell, Julia?

In the old code, the R of the second RATE_6M was aligned with the R of the 
RATE_18M just above.  Now the R of the second RATE_6M is one character to 
the left.  Before at the place you corrected, there was " , ", and you
changed it to ", ".  But to preserve the alignment, you could change it to 
",  ".  Then all the RATEs will line up and the comment will line up.

You could also consider that this alignment is not important.  But then 
there should be ", " in every case, not sometimes ",  ".

julia

> 
> >>  };
> >>
> >>  #define RTSDUR_BB       0
> >> --
> >> 2.1.0
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0e904876eb0c4ce2c937f9b1c54afb1039ac83c6.1444469447.git.shivanib134%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGXQNjUy4Jgjftjb4dYotgE44vTdHbpHTjocUuro%3DtwOg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: vt6655: rxtx: Remove unnecessary space character

[Shivani Bhardwaj]

On Sun, Oct 11, 2015 at 3:31 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 11 Oct 2015, Shivani Bhardwaj wrote:
>
>> On Sat, Oct 10, 2015 at 3:53 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> > On Sat, 10 Oct 2015, Shivani Bhardwaj wrote:
>> >
>> >> Remove unnecessary space character after the variable RATE_16M.
>> >> Fixes the warning by checkpatch : space prohibited before
>> >> that ',' (ctx:WxW)
>> >>
>> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> >> ---
>> >> Changes in v2:
>> >>       -Make the commit message better and clearer.
>> >>
>> >>  drivers/staging/vt6655/rxtx.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
>> >> index 5875d65..a909128 100644
>> >> --- a/drivers/staging/vt6655/rxtx.c
>> >> +++ b/drivers/staging/vt6655/rxtx.c
>> >> @@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
>> >>  };
>> >>  static const unsigned short wFB_Opt1[2][5] = {
>> >>       {RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
>> >> -     {RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
>> >> +     {RATE_6M, RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
>> >
>> > It looks lik ethere was a goal to get the constants and comment to line
>> > up, which doesn't seem to occur any more.  Maybe you could move the comma
>> > without breaking the alignment.
>> >
>> > julia
>> >
>>
>> How has the alignment been disturbed here, I do not understand. Can
>> you please tell, Julia?
>
> In the old code, the R of the second RATE_6M was aligned with the R of the
> RATE_18M just above.  Now the R of the second RATE_6M is one character to
> the left.  Before at the place you corrected, there was " , ", and you
> changed it to ", ".  But to preserve the alignment, you could change it to
> ",  ".  Then all the RATEs will line up and the comment will line up.
>
> You could also consider that this alignment is not important.  But then
> there should be ", " in every case, not sometimes ",  ".
>
> julia
>

Thank you, Julia! I'm fixing this.

>>
>> >>  };
>> >>
>> >>  #define RTSDUR_BB       0
>> >> --
>> >> 2.1.0
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0e904876eb0c4ce2c937f9b1c54afb1039ac83c6.1444469447.git.shivanib134%40gmail.com.
>> >> For more options, visit https://groups.google.com/d/optout.
>> >>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGXQNjUy4Jgjftjb4dYotgE44vTdHbpHTjocUuro%3DtwOg%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>