* [PATCH v2 0/3] Remove useless cast on void pointer
@ 2015-10-13 8:33 Amitoj Kaur Chawla
2015-10-13 8:35 ` [PATCH v2 1/3] staging: rtl8712: " Amitoj Kaur Chawla
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-13 8:33 UTC (permalink / raw)
To: outreachy-kernel
This patchset removes multiple useless cast on void pointer.
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Amitoj Kaur Chawla (3):
staging: rtl8712: Remove useless cast on void pointer
staging: rtl8712: Remove useless cast on void pointer
staging: rtl8712: Remove useless cast on void pointer
Changes in v2:
-Remove unnecessary parentheses
drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
drivers/staging/rtl8712/rtl8712_recv.c | 9 ++-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 105 ++++++++++-------------------
3 files changed, 40 insertions(+), 76 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] staging: rtl8712: Remove useless cast on void pointer
2015-10-13 8:33 [PATCH v2 0/3] Remove useless cast on void pointer Amitoj Kaur Chawla
@ 2015-10-13 8:35 ` Amitoj Kaur Chawla
2015-10-13 8:36 ` [PATCH v2 2/3] " Amitoj Kaur Chawla
2015-10-13 8:38 ` [PATCH v2 3/3] " Amitoj Kaur Chawla
2 siblings, 0 replies; 6+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-13 8:35 UTC (permalink / raw)
To: outreachy-kernel
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
-None
drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c
index b755ab4..9453975 100644
--- a/drivers/staging/rtl8712/rtl8712_cmd.c
+++ b/drivers/staging/rtl8712/rtl8712_cmd.c
@@ -317,7 +317,7 @@ int r8712_cmd_thread(void *context)
unsigned int cmdsz, wr_sz, *pcmdbuf;
struct tx_desc *pdesc;
void (*pcmd_callback)(struct _adapter *dev, struct cmd_obj *pcmd);
- struct _adapter *padapter = (struct _adapter *)context;
+ struct _adapter *padapter = context;
struct cmd_priv *pcmdpriv = &(padapter->cmdpriv);
allow_signal(SIGTERM);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] staging: rtl8712: Remove useless cast on void pointer
2015-10-13 8:33 [PATCH v2 0/3] Remove useless cast on void pointer Amitoj Kaur Chawla
2015-10-13 8:35 ` [PATCH v2 1/3] staging: rtl8712: " Amitoj Kaur Chawla
@ 2015-10-13 8:36 ` Amitoj Kaur Chawla
2015-10-13 8:38 ` [PATCH v2 3/3] " Amitoj Kaur Chawla
2 siblings, 0 replies; 6+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-13 8:36 UTC (permalink / raw)
To: outreachy-kernel
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
-None
drivers/staging/rtl8712/rtl8712_recv.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index 4fa2540..fae06d9 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -434,7 +434,7 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void *prxcmdbuf)
poffset = (u8 *)prxcmdbuf;
voffset = *(uint *)poffset;
- prxstat = (struct recv_stat *)prxcmdbuf;
+ prxstat = prxcmdbuf;
drvinfo_sz = (le32_to_cpu(prxstat->rxdw0) & 0x000f0000) >> 16;
drvinfo_sz <<= 3;
poffset += RXDESC_SIZE + drvinfo_sz;
@@ -620,8 +620,7 @@ _err_exit:
void r8712_reordering_ctrl_timeout_handler(void *pcontext)
{
unsigned long irql;
- struct recv_reorder_ctrl *preorder_ctrl =
- (struct recv_reorder_ctrl *)pcontext;
+ struct recv_reorder_ctrl *preorder_ctrl = pcontext;
struct _adapter *padapter = preorder_ctrl->padapter;
struct __queue *ppending_recvframe_queue =
&preorder_ctrl->pending_recvframe_queue;
@@ -959,7 +958,7 @@ int recv_func(struct _adapter *padapter, void *pcontext)
struct __queue *pfree_recv_queue = &padapter->recvpriv.free_recv_queue;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- prframe = (union recv_frame *)pcontext;
+ prframe = pcontext;
orig_prframe = prframe;
pattrib = &prframe->u.hdr.attrib;
if (check_fwstate(pmlmepriv, WIFI_MP_STATE) == true) {
@@ -1103,7 +1102,7 @@ _exit_recvbuf2recvframe:
static void recv_tasklet(void *priv)
{
struct sk_buff *pskb;
- struct _adapter *padapter = (struct _adapter *)priv;
+ struct _adapter *padapter = priv;
struct recv_priv *precvpriv = &padapter->recvpriv;
while (NULL != (pskb = skb_dequeue(&precvpriv->rx_skb_queue))) {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] staging: rtl8712: Remove useless cast on void pointer
2015-10-13 8:33 [PATCH v2 0/3] Remove useless cast on void pointer Amitoj Kaur Chawla
2015-10-13 8:35 ` [PATCH v2 1/3] staging: rtl8712: " Amitoj Kaur Chawla
2015-10-13 8:36 ` [PATCH v2 2/3] " Amitoj Kaur Chawla
@ 2015-10-13 8:38 ` Amitoj Kaur Chawla
2015-10-13 8:38 ` [Outreachy kernel] " Julia Lawall
2 siblings, 1 reply; 6+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-13 8:38 UTC (permalink / raw)
To: outreachy-kernel
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
-Remove unnecessary parentheses
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 105 ++++++++++-------------------
1 file changed, 35 insertions(+), 70 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
index 77f01bf..b76b7c4 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
@@ -41,8 +41,7 @@ uint oid_null_function(struct oid_par_priv *poid_par_priv)
uint oid_rt_wireless_mode_hdl(struct oid_par_priv *poid_par_priv)
{
uint status = RNDIS_STATUS_SUCCESS;
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid == SET_OID) {
if (poid_par_priv->information_buf_len >= sizeof(u8))
@@ -66,8 +65,7 @@ uint oid_rt_wireless_mode_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_write_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
struct bb_reg_param *pbbreg;
u16 offset;
u32 value;
@@ -87,8 +85,7 @@ uint oid_rt_pro_write_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_read_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
struct bb_reg_param *pbbreg;
u16 offset;
u32 value;
@@ -109,8 +106,7 @@ uint oid_rt_pro_read_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_write_rf_reg_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
struct rf_reg_param *pbbreg;
u8 path;
u8 offset;
@@ -132,8 +128,7 @@ uint oid_rt_pro_write_rf_reg_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_read_rf_reg_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
struct rf_reg_param *pbbreg;
u8 path;
u8 offset;
@@ -260,8 +255,7 @@ int mp_start_joinbss(struct _adapter *padapter, struct ndis_802_11_ssid *pssid)
uint oid_rt_pro_set_data_rate_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 ratevalue;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -278,8 +272,7 @@ uint oid_rt_pro_set_data_rate_hdl(struct oid_par_priv
uint oid_rt_pro_start_test_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
uint status = RNDIS_STATUS_SUCCESS;
u32 mode;
u8 val8;
@@ -307,8 +300,7 @@ uint oid_rt_pro_start_test_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_stop_test_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
uint status = RNDIS_STATUS_SUCCESS;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -321,8 +313,7 @@ uint oid_rt_pro_stop_test_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_set_channel_direct_call_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 Channel;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -339,8 +330,7 @@ uint oid_rt_pro_set_channel_direct_call_hdl(struct oid_par_priv
uint oid_rt_pro_set_antenna_bb_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 antenna;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -357,8 +347,7 @@ uint oid_rt_pro_set_antenna_bb_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_set_tx_power_control_hdl(
struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 tx_pwr_idx;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -377,8 +366,7 @@ uint oid_rt_pro_query_tx_packet_sent_hdl(
struct oid_par_priv *poid_par_priv)
{
uint status = RNDIS_STATUS_SUCCESS;
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID) {
status = RNDIS_STATUS_NOT_ACCEPTED;
@@ -397,8 +385,7 @@ uint oid_rt_pro_query_rx_packet_received_hdl(
struct oid_par_priv *poid_par_priv)
{
uint status = RNDIS_STATUS_SUCCESS;
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID) {
status = RNDIS_STATUS_NOT_ACCEPTED;
@@ -417,8 +404,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl(
struct oid_par_priv *poid_par_priv)
{
uint status = RNDIS_STATUS_SUCCESS;
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID) {
status = RNDIS_STATUS_NOT_ACCEPTED;
@@ -436,8 +422,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl(
uint oid_rt_pro_reset_tx_packet_sent_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != SET_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -449,8 +434,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_priv
*poid_par_priv)
{
uint status = RNDIS_STATUS_SUCCESS;
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != SET_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -465,8 +449,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_priv
uint oid_rt_reset_phy_rx_packet_count_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != SET_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -477,8 +460,7 @@ uint oid_rt_reset_phy_rx_packet_count_hdl(struct oid_par_priv
uint oid_rt_get_phy_rx_packet_received_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -493,8 +475,7 @@ uint oid_rt_get_phy_rx_packet_received_hdl(struct oid_par_priv
uint oid_rt_get_phy_rx_packet_crc32_error_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -509,8 +490,7 @@ uint oid_rt_get_phy_rx_packet_crc32_error_hdl(struct oid_par_priv
uint oid_rt_pro_set_modulation_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != SET_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -522,8 +502,7 @@ uint oid_rt_pro_set_modulation_hdl(struct oid_par_priv
uint oid_rt_pro_set_continuous_tx_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 bStartTest;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -536,8 +515,7 @@ uint oid_rt_pro_set_continuous_tx_hdl(struct oid_par_priv
uint oid_rt_pro_set_single_carrier_tx_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 bStartTest;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -550,8 +528,7 @@ uint oid_rt_pro_set_single_carrier_tx_hdl(struct oid_par_priv
uint oid_rt_pro_set_carrier_suppression_tx_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 bStartTest;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -564,8 +541,7 @@ uint oid_rt_pro_set_carrier_suppression_tx_hdl(struct oid_par_priv
uint oid_rt_pro_set_single_tone_tx_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 bStartTest;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -578,8 +554,7 @@ uint oid_rt_pro_set_single_tone_tx_hdl(struct oid_par_priv
uint oid_rt_pro_read_register_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
uint status = RNDIS_STATUS_SUCCESS;
struct mp_rw_reg *RegRWStruct;
u16 offset;
@@ -618,8 +593,7 @@ uint oid_rt_pro_read_register_hdl(struct oid_par_priv
uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
uint status = RNDIS_STATUS_SUCCESS;
struct mp_rw_reg *RegRWStruct;
u16 offset;
@@ -678,8 +652,7 @@ uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_get_thermal_meter_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -706,8 +679,7 @@ uint oid_rt_get_thermal_meter_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_read_efuse_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
uint status = RNDIS_STATUS_SUCCESS;
@@ -736,8 +708,7 @@ uint oid_rt_pro_read_efuse_hdl(struct oid_par_priv *poid_par_priv)
/*------------------------------------------------------------------------*/
uint oid_rt_pro_write_efuse_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
uint status = RNDIS_STATUS_SUCCESS;
@@ -765,8 +736,7 @@ uint oid_rt_pro_write_efuse_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_get_efuse_current_size_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -782,8 +752,7 @@ uint oid_rt_get_efuse_current_size_hdl(struct oid_par_priv
uint oid_rt_get_efuse_max_size_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
@@ -808,8 +777,7 @@ uint oid_rt_pro_efuse_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_pro_efuse_map_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
uint status = RNDIS_STATUS_SUCCESS;
u8 *data;
@@ -840,8 +808,7 @@ uint oid_rt_pro_efuse_map_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_set_bandwidth_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u32 bandwidth;
if (poid_par_priv->type_of_oid != SET_OID)
@@ -859,8 +826,7 @@ uint oid_rt_set_bandwidth_hdl(struct oid_par_priv *poid_par_priv)
uint oid_rt_set_rx_packet_type_hdl(struct oid_par_priv
*poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
u8 rx_pkt_type;
u32 rcr_val32;
@@ -915,8 +881,7 @@ uint oid_rt_set_power_down_hdl(struct oid_par_priv *poid_par_priv)
/*-------------------------------------------------------------------------- */
uint oid_rt_get_power_mode_hdl(struct oid_par_priv *poid_par_priv)
{
- struct _adapter *Adapter = (struct _adapter *)
- (poid_par_priv->adapter_context);
+ struct _adapter *Adapter = poid_par_priv->adapter_context;
if (poid_par_priv->type_of_oid != QUERY_OID)
return RNDIS_STATUS_NOT_ACCEPTED;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 3/3] staging: rtl8712: Remove useless cast on void pointer
2015-10-13 8:38 ` [PATCH v2 3/3] " Amitoj Kaur Chawla
@ 2015-10-13 8:38 ` Julia Lawall
2015-10-13 8:49 ` Amitoj Kaur Chawla
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2015-10-13 8:38 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: outreachy-kernel
On Tue, 13 Oct 2015, Amitoj Kaur Chawla wrote:
> The semantic patch used to find this is:
>
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
>
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T *)x)->f
> |
> - (T *)
> e
> )
When you make a change by hand beyond what the semantic patch does, it
should be mentioned up here, not just below the ---.
julia
>
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
> -Remove unnecessary parentheses
>
> drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 105 ++++++++++-------------------
> 1 file changed, 35 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> index 77f01bf..b76b7c4 100644
> --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> @@ -41,8 +41,7 @@ uint oid_null_function(struct oid_par_priv *poid_par_priv)
> uint oid_rt_wireless_mode_hdl(struct oid_par_priv *poid_par_priv)
> {
> uint status = RNDIS_STATUS_SUCCESS;
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid == SET_OID) {
> if (poid_par_priv->information_buf_len >= sizeof(u8))
> @@ -66,8 +65,7 @@ uint oid_rt_wireless_mode_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_pro_write_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> struct bb_reg_param *pbbreg;
> u16 offset;
> u32 value;
> @@ -87,8 +85,7 @@ uint oid_rt_pro_write_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_pro_read_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> struct bb_reg_param *pbbreg;
> u16 offset;
> u32 value;
> @@ -109,8 +106,7 @@ uint oid_rt_pro_read_bb_reg_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_pro_write_rf_reg_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> struct rf_reg_param *pbbreg;
> u8 path;
> u8 offset;
> @@ -132,8 +128,7 @@ uint oid_rt_pro_write_rf_reg_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_pro_read_rf_reg_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> struct rf_reg_param *pbbreg;
> u8 path;
> u8 offset;
> @@ -260,8 +255,7 @@ int mp_start_joinbss(struct _adapter *padapter, struct ndis_802_11_ssid *pssid)
> uint oid_rt_pro_set_data_rate_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 ratevalue;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -278,8 +272,7 @@ uint oid_rt_pro_set_data_rate_hdl(struct oid_par_priv
>
> uint oid_rt_pro_start_test_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> uint status = RNDIS_STATUS_SUCCESS;
> u32 mode;
> u8 val8;
> @@ -307,8 +300,7 @@ uint oid_rt_pro_start_test_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_pro_stop_test_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> uint status = RNDIS_STATUS_SUCCESS;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -321,8 +313,7 @@ uint oid_rt_pro_stop_test_hdl(struct oid_par_priv *poid_par_priv)
> uint oid_rt_pro_set_channel_direct_call_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 Channel;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -339,8 +330,7 @@ uint oid_rt_pro_set_channel_direct_call_hdl(struct oid_par_priv
>
> uint oid_rt_pro_set_antenna_bb_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 antenna;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -357,8 +347,7 @@ uint oid_rt_pro_set_antenna_bb_hdl(struct oid_par_priv *poid_par_priv)
> uint oid_rt_pro_set_tx_power_control_hdl(
> struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 tx_pwr_idx;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -377,8 +366,7 @@ uint oid_rt_pro_query_tx_packet_sent_hdl(
> struct oid_par_priv *poid_par_priv)
> {
> uint status = RNDIS_STATUS_SUCCESS;
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID) {
> status = RNDIS_STATUS_NOT_ACCEPTED;
> @@ -397,8 +385,7 @@ uint oid_rt_pro_query_rx_packet_received_hdl(
> struct oid_par_priv *poid_par_priv)
> {
> uint status = RNDIS_STATUS_SUCCESS;
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID) {
> status = RNDIS_STATUS_NOT_ACCEPTED;
> @@ -417,8 +404,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl(
> struct oid_par_priv *poid_par_priv)
> {
> uint status = RNDIS_STATUS_SUCCESS;
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID) {
> status = RNDIS_STATUS_NOT_ACCEPTED;
> @@ -436,8 +422,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl(
> uint oid_rt_pro_reset_tx_packet_sent_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -449,8 +434,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> uint status = RNDIS_STATUS_SUCCESS;
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -465,8 +449,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_priv
> uint oid_rt_reset_phy_rx_packet_count_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -477,8 +460,7 @@ uint oid_rt_reset_phy_rx_packet_count_hdl(struct oid_par_priv
> uint oid_rt_get_phy_rx_packet_received_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -493,8 +475,7 @@ uint oid_rt_get_phy_rx_packet_received_hdl(struct oid_par_priv
> uint oid_rt_get_phy_rx_packet_crc32_error_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -509,8 +490,7 @@ uint oid_rt_get_phy_rx_packet_crc32_error_hdl(struct oid_par_priv
> uint oid_rt_pro_set_modulation_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -522,8 +502,7 @@ uint oid_rt_pro_set_modulation_hdl(struct oid_par_priv
> uint oid_rt_pro_set_continuous_tx_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 bStartTest;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -536,8 +515,7 @@ uint oid_rt_pro_set_continuous_tx_hdl(struct oid_par_priv
> uint oid_rt_pro_set_single_carrier_tx_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 bStartTest;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -550,8 +528,7 @@ uint oid_rt_pro_set_single_carrier_tx_hdl(struct oid_par_priv
> uint oid_rt_pro_set_carrier_suppression_tx_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 bStartTest;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -564,8 +541,7 @@ uint oid_rt_pro_set_carrier_suppression_tx_hdl(struct oid_par_priv
> uint oid_rt_pro_set_single_tone_tx_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 bStartTest;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -578,8 +554,7 @@ uint oid_rt_pro_set_single_tone_tx_hdl(struct oid_par_priv
> uint oid_rt_pro_read_register_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> uint status = RNDIS_STATUS_SUCCESS;
> struct mp_rw_reg *RegRWStruct;
> u16 offset;
> @@ -618,8 +593,7 @@ uint oid_rt_pro_read_register_hdl(struct oid_par_priv
>
> uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> uint status = RNDIS_STATUS_SUCCESS;
> struct mp_rw_reg *RegRWStruct;
> u16 offset;
> @@ -678,8 +652,7 @@ uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_get_thermal_meter_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -706,8 +679,7 @@ uint oid_rt_get_thermal_meter_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_pro_read_efuse_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> uint status = RNDIS_STATUS_SUCCESS;
>
> @@ -736,8 +708,7 @@ uint oid_rt_pro_read_efuse_hdl(struct oid_par_priv *poid_par_priv)
> /*------------------------------------------------------------------------*/
> uint oid_rt_pro_write_efuse_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> uint status = RNDIS_STATUS_SUCCESS;
>
> @@ -765,8 +736,7 @@ uint oid_rt_pro_write_efuse_hdl(struct oid_par_priv *poid_par_priv)
> uint oid_rt_get_efuse_current_size_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -782,8 +752,7 @@ uint oid_rt_get_efuse_current_size_hdl(struct oid_par_priv
>
> uint oid_rt_get_efuse_max_size_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> @@ -808,8 +777,7 @@ uint oid_rt_pro_efuse_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_pro_efuse_map_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> uint status = RNDIS_STATUS_SUCCESS;
> u8 *data;
>
> @@ -840,8 +808,7 @@ uint oid_rt_pro_efuse_map_hdl(struct oid_par_priv *poid_par_priv)
>
> uint oid_rt_set_bandwidth_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u32 bandwidth;
>
> if (poid_par_priv->type_of_oid != SET_OID)
> @@ -859,8 +826,7 @@ uint oid_rt_set_bandwidth_hdl(struct oid_par_priv *poid_par_priv)
> uint oid_rt_set_rx_packet_type_hdl(struct oid_par_priv
> *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
> u8 rx_pkt_type;
> u32 rcr_val32;
>
> @@ -915,8 +881,7 @@ uint oid_rt_set_power_down_hdl(struct oid_par_priv *poid_par_priv)
> /*-------------------------------------------------------------------------- */
> uint oid_rt_get_power_mode_hdl(struct oid_par_priv *poid_par_priv)
> {
> - struct _adapter *Adapter = (struct _adapter *)
> - (poid_par_priv->adapter_context);
> + struct _adapter *Adapter = poid_par_priv->adapter_context;
>
> if (poid_par_priv->type_of_oid != QUERY_OID)
> return RNDIS_STATUS_NOT_ACCEPTED;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2109e4a1c74989232680cf926b8473370a801818.1444725049.git.amitoj1606%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 3/3] staging: rtl8712: Remove useless cast on void pointer
2015-10-13 8:38 ` [Outreachy kernel] " Julia Lawall
@ 2015-10-13 8:49 ` Amitoj Kaur Chawla
0 siblings, 0 replies; 6+ messages in thread
From: Amitoj Kaur Chawla @ 2015-10-13 8:49 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
On Tue, Oct 13, 2015 at 2:08 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Tue, 13 Oct 2015, Amitoj Kaur Chawla wrote:
>
>> The semantic patch used to find this is:
>>
>> @r@
>> expression x;
>> void* e;
>> type T;
>> identifier f;
>> @@
>>
>> (
>> *((T *)e)
>> |
>> ((T *)x)[...]
>> |
>> ((T *)x)->f
>> |
>> - (T *)
>> e
>> )
>
> When you make a change by hand beyond what the semantic patch does, it
> should be mentioned up here, not just below the ---.
>
Oh, okay. Will keep that in mind for the future.
Thanks for the feedback,
Amitoj
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-13 8:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 8:33 [PATCH v2 0/3] Remove useless cast on void pointer Amitoj Kaur Chawla
2015-10-13 8:35 ` [PATCH v2 1/3] staging: rtl8712: " Amitoj Kaur Chawla
2015-10-13 8:36 ` [PATCH v2 2/3] " Amitoj Kaur Chawla
2015-10-13 8:38 ` [PATCH v2 3/3] " Amitoj Kaur Chawla
2015-10-13 8:38 ` [Outreachy kernel] " Julia Lawall
2015-10-13 8:49 ` Amitoj Kaur Chawla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.