* [PATCH 0/2] Remove wrapper functions and clean up the code @ 2015-10-28 10:56 Shivani Bhardwaj 2015-10-28 10:57 ` [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions Shivani Bhardwaj 2015-10-28 10:57 ` [PATCH 2/2] Staging: wilc1000: linux_wlan: Replace function calls Shivani Bhardwaj 0 siblings, 2 replies; 7+ messages in thread From: Shivani Bhardwaj @ 2015-10-28 10:56 UTC (permalink / raw) To: outreachy-kernel; +Cc: outreachy-kernel This patchset removes the wrapper functions which are not required and replaces their calls with appropriate functions. Also, some definitions are swapped between files in accordance with the functions that needed them. After applying this patch, code becomes cleaner. Shivani Bhardwaj (2): Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions Staging: wilc1000: linux_wlan: Replace function calls drivers/staging/wilc1000/linux_wlan.c | 15 +++++++++-- drivers/staging/wilc1000/linux_wlan_sdio.c | 42 +++--------------------------- 2 files changed, 17 insertions(+), 40 deletions(-) -- 2.1.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions 2015-10-28 10:56 [PATCH 0/2] Remove wrapper functions and clean up the code Shivani Bhardwaj @ 2015-10-28 10:57 ` Shivani Bhardwaj 2015-10-28 11:00 ` [Outreachy kernel] " Julia Lawall 2015-10-28 10:57 ` [PATCH 2/2] Staging: wilc1000: linux_wlan: Replace function calls Shivani Bhardwaj 1 sibling, 1 reply; 7+ messages in thread From: Shivani Bhardwaj @ 2015-10-28 10:57 UTC (permalink / raw) To: outreachy-kernel; +Cc: outreachy-kernel Remove the functions linux_sdio_get_speed(), linux_sdio_set_max_speed() and linux_sdio_set_default_speed(). Replace their calls with appropriate functions. Also, definitions associated with these functions should be removed. Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> --- drivers/staging/wilc1000/linux_wlan_sdio.c | 42 +++--------------------------- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_sdio.c b/drivers/staging/wilc1000/linux_wlan_sdio.c index 1f8d874..d58baf2 100644 --- a/drivers/staging/wilc1000/linux_wlan_sdio.c +++ b/drivers/staging/wilc1000/linux_wlan_sdio.c @@ -1,26 +1,12 @@ #include "wilc_wfi_netdevice.h" - #include <linux/mmc/sdio_func.h> #include <linux/mmc/card.h> #include <linux/mmc/sdio_ids.h> #include <linux/mmc/sdio.h> #include <linux/mmc/host.h> - - #define SDIO_MODALIAS "wilc1000_sdio" -#if defined(CUSTOMER_PLATFORM) -/* TODO : User have to stable bus clock as user's environment. */ - #ifdef MAX_BUS_SPEED - #define MAX_SPEED MAX_BUS_SPEED - #else - #define MAX_SPEED 50000000 - #endif -#else - #define MAX_SPEED (6 * 1000000) /* Max 50M */ -#endif - struct wilc_sdio { struct sdio_func *func; struct wilc *wilc; @@ -104,7 +90,6 @@ int linux_sdio_cmd53(sdio_cmd53_t *cmd) sdio_release_host(func); - if (ret < 0) { PRINT_ER("wilc_sdio_cmd53..failed, err(%d)\n", ret); return 0; @@ -206,11 +191,6 @@ static int linux_sdio_set_speed(int speed) return 1; } -static int linux_sdio_get_speed(void) -{ - return local_sdio_func->card->host->ios.clock; -} - int linux_sdio_init(void *pv) { @@ -219,30 +199,16 @@ int linux_sdio_init(void *pv) **/ - sdio_default_speed = linux_sdio_get_speed(); + sdio_default_speed = local_sdio_func->card->host->ios.clock; return 1; } void linux_sdio_deinit(void *pv) { - - /** - * TODO : - **/ - + /** + * TODO : + **/ sdio_unregister_driver(&wilc_bus); } -int linux_sdio_set_max_speed(void) -{ - return linux_sdio_set_speed(MAX_SPEED); -} - -int linux_sdio_set_default_speed(void) -{ - return linux_sdio_set_speed(sdio_default_speed); -} - - - -- 2.1.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions 2015-10-28 10:57 ` [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions Shivani Bhardwaj @ 2015-10-28 11:00 ` Julia Lawall 2015-10-28 11:02 ` Shivani Bhardwaj 0 siblings, 1 reply; 7+ messages in thread From: Julia Lawall @ 2015-10-28 11:00 UTC (permalink / raw) To: Shivani Bhardwaj; +Cc: outreachy-kernel On Wed, 28 Oct 2015, Shivani Bhardwaj wrote: > Remove the functions linux_sdio_get_speed(), linux_sdio_set_max_speed() > and linux_sdio_set_default_speed(). Replace their calls with appropriate > functions. Also, definitions associated with these functions should be removed. > > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > --- > drivers/staging/wilc1000/linux_wlan_sdio.c | 42 +++--------------------------- > 1 file changed, 4 insertions(+), 38 deletions(-) > > diff --git a/drivers/staging/wilc1000/linux_wlan_sdio.c b/drivers/staging/wilc1000/linux_wlan_sdio.c > index 1f8d874..d58baf2 100644 > --- a/drivers/staging/wilc1000/linux_wlan_sdio.c > +++ b/drivers/staging/wilc1000/linux_wlan_sdio.c > @@ -1,26 +1,12 @@ > #include "wilc_wfi_netdevice.h" > - > #include <linux/mmc/sdio_func.h> > #include <linux/mmc/card.h> > #include <linux/mmc/sdio_ids.h> > #include <linux/mmc/sdio.h> > #include <linux/mmc/host.h> > > - > - Not clear why these blank lines are removed. They are not needed, but they are not part of what is described in the commit message either. > #define SDIO_MODALIAS "wilc1000_sdio" > > -#if defined(CUSTOMER_PLATFORM) > -/* TODO : User have to stable bus clock as user's environment. */ > - #ifdef MAX_BUS_SPEED > - #define MAX_SPEED MAX_BUS_SPEED > - #else > - #define MAX_SPEED 50000000 > - #endif > -#else > - #define MAX_SPEED (6 * 1000000) /* Max 50M */ > -#endif > - > struct wilc_sdio { > struct sdio_func *func; > struct wilc *wilc; > @@ -104,7 +90,6 @@ int linux_sdio_cmd53(sdio_cmd53_t *cmd) > > sdio_release_host(func); > > - Sane for this one. julia > if (ret < 0) { > PRINT_ER("wilc_sdio_cmd53..failed, err(%d)\n", ret); > return 0; > @@ -206,11 +191,6 @@ static int linux_sdio_set_speed(int speed) > return 1; > } > > -static int linux_sdio_get_speed(void) > -{ > - return local_sdio_func->card->host->ios.clock; > -} > - > int linux_sdio_init(void *pv) > { > > @@ -219,30 +199,16 @@ int linux_sdio_init(void *pv) > **/ > > > - sdio_default_speed = linux_sdio_get_speed(); > + sdio_default_speed = local_sdio_func->card->host->ios.clock; > return 1; > } > > void linux_sdio_deinit(void *pv) > { > - > - /** > - * TODO : > - **/ > - > + /** > + * TODO : > + **/ > > sdio_unregister_driver(&wilc_bus); > } > > -int linux_sdio_set_max_speed(void) > -{ > - return linux_sdio_set_speed(MAX_SPEED); > -} > - > -int linux_sdio_set_default_speed(void) > -{ > - return linux_sdio_set_speed(sdio_default_speed); > -} > - > - > - > -- > 2.1.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/16ce4db27490fbed8cbe035c6bf7bc6993b19c80.1446029550.git.shivanib134%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions 2015-10-28 11:00 ` [Outreachy kernel] " Julia Lawall @ 2015-10-28 11:02 ` Shivani Bhardwaj 2015-10-28 11:04 ` Julia Lawall 0 siblings, 1 reply; 7+ messages in thread From: Shivani Bhardwaj @ 2015-10-28 11:02 UTC (permalink / raw) To: Julia Lawall; +Cc: outreachy-kernel On Wed, Oct 28, 2015 at 4:30 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: > On Wed, 28 Oct 2015, Shivani Bhardwaj wrote: > >> Remove the functions linux_sdio_get_speed(), linux_sdio_set_max_speed() >> and linux_sdio_set_default_speed(). Replace their calls with appropriate >> functions. Also, definitions associated with these functions should be removed. >> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> >> --- >> drivers/staging/wilc1000/linux_wlan_sdio.c | 42 +++--------------------------- >> 1 file changed, 4 insertions(+), 38 deletions(-) >> >> diff --git a/drivers/staging/wilc1000/linux_wlan_sdio.c b/drivers/staging/wilc1000/linux_wlan_sdio.c >> index 1f8d874..d58baf2 100644 >> --- a/drivers/staging/wilc1000/linux_wlan_sdio.c >> +++ b/drivers/staging/wilc1000/linux_wlan_sdio.c >> @@ -1,26 +1,12 @@ >> #include "wilc_wfi_netdevice.h" >> - >> #include <linux/mmc/sdio_func.h> >> #include <linux/mmc/card.h> >> #include <linux/mmc/sdio_ids.h> >> #include <linux/mmc/sdio.h> >> #include <linux/mmc/host.h> >> >> - >> - > > Not clear why these blank lines are removed. They are not needed, but > they are not part of what is described in the commit message either. > >> #define SDIO_MODALIAS "wilc1000_sdio" >> >> -#if defined(CUSTOMER_PLATFORM) >> -/* TODO : User have to stable bus clock as user's environment. */ >> - #ifdef MAX_BUS_SPEED >> - #define MAX_SPEED MAX_BUS_SPEED >> - #else >> - #define MAX_SPEED 50000000 >> - #endif >> -#else >> - #define MAX_SPEED (6 * 1000000) /* Max 50M */ >> -#endif >> - >> struct wilc_sdio { >> struct sdio_func *func; >> struct wilc *wilc; >> @@ -104,7 +90,6 @@ int linux_sdio_cmd53(sdio_cmd53_t *cmd) >> >> sdio_release_host(func); >> >> - > > Sane for this one. > > julia > Should I just update the commit message or do it as a different patch in the series? Thank you >> if (ret < 0) { >> PRINT_ER("wilc_sdio_cmd53..failed, err(%d)\n", ret); >> return 0; >> @@ -206,11 +191,6 @@ static int linux_sdio_set_speed(int speed) >> return 1; >> } >> >> -static int linux_sdio_get_speed(void) >> -{ >> - return local_sdio_func->card->host->ios.clock; >> -} >> - >> int linux_sdio_init(void *pv) >> { >> >> @@ -219,30 +199,16 @@ int linux_sdio_init(void *pv) >> **/ >> >> >> - sdio_default_speed = linux_sdio_get_speed(); >> + sdio_default_speed = local_sdio_func->card->host->ios.clock; >> return 1; >> } >> >> void linux_sdio_deinit(void *pv) >> { >> - >> - /** >> - * TODO : >> - **/ >> - >> + /** >> + * TODO : >> + **/ >> >> sdio_unregister_driver(&wilc_bus); >> } >> >> -int linux_sdio_set_max_speed(void) >> -{ >> - return linux_sdio_set_speed(MAX_SPEED); >> -} >> - >> -int linux_sdio_set_default_speed(void) >> -{ >> - return linux_sdio_set_speed(sdio_default_speed); >> -} >> - >> - >> - >> -- >> 2.1.0 >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/16ce4db27490fbed8cbe035c6bf7bc6993b19c80.1446029550.git.shivanib134%40gmail.com. >> For more options, visit https://groups.google.com/d/optout. >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions 2015-10-28 11:02 ` Shivani Bhardwaj @ 2015-10-28 11:04 ` Julia Lawall 2015-10-28 11:04 ` Shivani Bhardwaj 0 siblings, 1 reply; 7+ messages in thread From: Julia Lawall @ 2015-10-28 11:04 UTC (permalink / raw) To: Shivani Bhardwaj; +Cc: outreachy-kernel On Wed, 28 Oct 2015, Shivani Bhardwaj wrote: > On Wed, Oct 28, 2015 at 4:30 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > On Wed, 28 Oct 2015, Shivani Bhardwaj wrote: > > > >> Remove the functions linux_sdio_get_speed(), linux_sdio_set_max_speed() > >> and linux_sdio_set_default_speed(). Replace their calls with appropriate > >> functions. Also, definitions associated with these functions should be removed. > >> > >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > >> --- > >> drivers/staging/wilc1000/linux_wlan_sdio.c | 42 +++--------------------------- > >> 1 file changed, 4 insertions(+), 38 deletions(-) > >> > >> diff --git a/drivers/staging/wilc1000/linux_wlan_sdio.c b/drivers/staging/wilc1000/linux_wlan_sdio.c > >> index 1f8d874..d58baf2 100644 > >> --- a/drivers/staging/wilc1000/linux_wlan_sdio.c > >> +++ b/drivers/staging/wilc1000/linux_wlan_sdio.c > >> @@ -1,26 +1,12 @@ > >> #include "wilc_wfi_netdevice.h" > >> - > >> #include <linux/mmc/sdio_func.h> > >> #include <linux/mmc/card.h> > >> #include <linux/mmc/sdio_ids.h> > >> #include <linux/mmc/sdio.h> > >> #include <linux/mmc/host.h> > >> > >> - > >> - > > > > Not clear why these blank lines are removed. They are not needed, but > > they are not part of what is described in the commit message either. > > > >> #define SDIO_MODALIAS "wilc1000_sdio" > >> > >> -#if defined(CUSTOMER_PLATFORM) > >> -/* TODO : User have to stable bus clock as user's environment. */ > >> - #ifdef MAX_BUS_SPEED > >> - #define MAX_SPEED MAX_BUS_SPEED > >> - #else > >> - #define MAX_SPEED 50000000 > >> - #endif > >> -#else > >> - #define MAX_SPEED (6 * 1000000) /* Max 50M */ > >> -#endif > >> - > >> struct wilc_sdio { > >> struct sdio_func *func; > >> struct wilc *wilc; > >> @@ -104,7 +90,6 @@ int linux_sdio_cmd53(sdio_cmd53_t *cmd) > >> > >> sdio_release_host(func); > >> > >> - > > > > Sane for this one. > > > > julia > > > > Should I just update the commit message or do it as a different patch > in the series? Do it as a different patch. julia > Thank you > > >> if (ret < 0) { > >> PRINT_ER("wilc_sdio_cmd53..failed, err(%d)\n", ret); > >> return 0; > >> @@ -206,11 +191,6 @@ static int linux_sdio_set_speed(int speed) > >> return 1; > >> } > >> > >> -static int linux_sdio_get_speed(void) > >> -{ > >> - return local_sdio_func->card->host->ios.clock; > >> -} > >> - > >> int linux_sdio_init(void *pv) > >> { > >> > >> @@ -219,30 +199,16 @@ int linux_sdio_init(void *pv) > >> **/ > >> > >> > >> - sdio_default_speed = linux_sdio_get_speed(); > >> + sdio_default_speed = local_sdio_func->card->host->ios.clock; > >> return 1; > >> } > >> > >> void linux_sdio_deinit(void *pv) > >> { > >> - > >> - /** > >> - * TODO : > >> - **/ > >> - > >> + /** > >> + * TODO : > >> + **/ > >> > >> sdio_unregister_driver(&wilc_bus); > >> } > >> > >> -int linux_sdio_set_max_speed(void) > >> -{ > >> - return linux_sdio_set_speed(MAX_SPEED); > >> -} > >> - > >> -int linux_sdio_set_default_speed(void) > >> -{ > >> - return linux_sdio_set_speed(sdio_default_speed); > >> -} > >> - > >> - > >> - > >> -- > >> 2.1.0 > >> > >> -- > >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > >> To post to this group, send email to outreachy-kernel@googlegroups.com. > >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/16ce4db27490fbed8cbe035c6bf7bc6993b19c80.1446029550.git.shivanib134%40gmail.com. > >> For more options, visit https://groups.google.com/d/optout. > >> > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGXZsPEYowxdDUjw741pDbCQ3-ewrYoAzMTR4ARZY%2Bv3g%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions 2015-10-28 11:04 ` Julia Lawall @ 2015-10-28 11:04 ` Shivani Bhardwaj 0 siblings, 0 replies; 7+ messages in thread From: Shivani Bhardwaj @ 2015-10-28 11:04 UTC (permalink / raw) To: Julia Lawall; +Cc: outreachy-kernel On Wed, Oct 28, 2015 at 4:34 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: > On Wed, 28 Oct 2015, Shivani Bhardwaj wrote: > >> On Wed, Oct 28, 2015 at 4:30 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: >> > On Wed, 28 Oct 2015, Shivani Bhardwaj wrote: >> > >> >> Remove the functions linux_sdio_get_speed(), linux_sdio_set_max_speed() >> >> and linux_sdio_set_default_speed(). Replace their calls with appropriate >> >> functions. Also, definitions associated with these functions should be removed. >> >> >> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> >> >> --- >> >> drivers/staging/wilc1000/linux_wlan_sdio.c | 42 +++--------------------------- >> >> 1 file changed, 4 insertions(+), 38 deletions(-) >> >> >> >> diff --git a/drivers/staging/wilc1000/linux_wlan_sdio.c b/drivers/staging/wilc1000/linux_wlan_sdio.c >> >> index 1f8d874..d58baf2 100644 >> >> --- a/drivers/staging/wilc1000/linux_wlan_sdio.c >> >> +++ b/drivers/staging/wilc1000/linux_wlan_sdio.c >> >> @@ -1,26 +1,12 @@ >> >> #include "wilc_wfi_netdevice.h" >> >> - >> >> #include <linux/mmc/sdio_func.h> >> >> #include <linux/mmc/card.h> >> >> #include <linux/mmc/sdio_ids.h> >> >> #include <linux/mmc/sdio.h> >> >> #include <linux/mmc/host.h> >> >> >> >> - >> >> - >> > >> > Not clear why these blank lines are removed. They are not needed, but >> > they are not part of what is described in the commit message either. >> > >> >> #define SDIO_MODALIAS "wilc1000_sdio" >> >> >> >> -#if defined(CUSTOMER_PLATFORM) >> >> -/* TODO : User have to stable bus clock as user's environment. */ >> >> - #ifdef MAX_BUS_SPEED >> >> - #define MAX_SPEED MAX_BUS_SPEED >> >> - #else >> >> - #define MAX_SPEED 50000000 >> >> - #endif >> >> -#else >> >> - #define MAX_SPEED (6 * 1000000) /* Max 50M */ >> >> -#endif >> >> - >> >> struct wilc_sdio { >> >> struct sdio_func *func; >> >> struct wilc *wilc; >> >> @@ -104,7 +90,6 @@ int linux_sdio_cmd53(sdio_cmd53_t *cmd) >> >> >> >> sdio_release_host(func); >> >> >> >> - >> > >> > Sane for this one. >> > >> > julia >> > >> >> Should I just update the commit message or do it as a different patch >> in the series? > > Do it as a different patch. > > julia > Alright. Thank you >> Thank you >> >> >> if (ret < 0) { >> >> PRINT_ER("wilc_sdio_cmd53..failed, err(%d)\n", ret); >> >> return 0; >> >> @@ -206,11 +191,6 @@ static int linux_sdio_set_speed(int speed) >> >> return 1; >> >> } >> >> >> >> -static int linux_sdio_get_speed(void) >> >> -{ >> >> - return local_sdio_func->card->host->ios.clock; >> >> -} >> >> - >> >> int linux_sdio_init(void *pv) >> >> { >> >> >> >> @@ -219,30 +199,16 @@ int linux_sdio_init(void *pv) >> >> **/ >> >> >> >> >> >> - sdio_default_speed = linux_sdio_get_speed(); >> >> + sdio_default_speed = local_sdio_func->card->host->ios.clock; >> >> return 1; >> >> } >> >> >> >> void linux_sdio_deinit(void *pv) >> >> { >> >> - >> >> - /** >> >> - * TODO : >> >> - **/ >> >> - >> >> + /** >> >> + * TODO : >> >> + **/ >> >> >> >> sdio_unregister_driver(&wilc_bus); >> >> } >> >> >> >> -int linux_sdio_set_max_speed(void) >> >> -{ >> >> - return linux_sdio_set_speed(MAX_SPEED); >> >> -} >> >> - >> >> -int linux_sdio_set_default_speed(void) >> >> -{ >> >> - return linux_sdio_set_speed(sdio_default_speed); >> >> -} >> >> - >> >> - >> >> - >> >> -- >> >> 2.1.0 >> >> >> >> -- >> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/16ce4db27490fbed8cbe035c6bf7bc6993b19c80.1446029550.git.shivanib134%40gmail.com. >> >> For more options, visit https://groups.google.com/d/optout. >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGXZsPEYowxdDUjw741pDbCQ3-ewrYoAzMTR4ARZY%2Bv3g%40mail.gmail.com. >> For more options, visit https://groups.google.com/d/optout. >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] Staging: wilc1000: linux_wlan: Replace function calls 2015-10-28 10:56 [PATCH 0/2] Remove wrapper functions and clean up the code Shivani Bhardwaj 2015-10-28 10:57 ` [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions Shivani Bhardwaj @ 2015-10-28 10:57 ` Shivani Bhardwaj 1 sibling, 0 replies; 7+ messages in thread From: Shivani Bhardwaj @ 2015-10-28 10:57 UTC (permalink / raw) To: outreachy-kernel; +Cc: outreachy-kernel Replace calls to wrapper functions with the actual functions called by wrapper functions. Definitions needed to make those calls should also be added. Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> --- drivers/staging/wilc1000/linux_wlan.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 9f899da..fbc3584 100644 --- a/drivers/staging/wilc1000/linux_wlan.c +++ b/drivers/staging/wilc1000/linux_wlan.c @@ -45,6 +45,17 @@ #define _linux_wlan_device_removal() {} #endif +#if defined(CUSTOMER_PLATFORM) +/* TODO : User have to stable bus clock as user's environment. */ +#ifdef MAX_BUS_SPEED +#define MAX_SPEED MAX_BUS_SPEED +#else +#define MAX_SPEED 50000000 +#endif +#else +#define MAX_SPEED (6 * 1000000) /* Max 50M */ +#endif + extern bool g_obtainingIP; extern u16 Set_machw_change_vir_if(bool bValue); extern void resolve_disconnect_aberration(void *drvHandler); @@ -976,8 +987,8 @@ void linux_to_wlan(wilc_wlan_inp_t *nwi, struct wilc *nic) nwi->io_func.io_deinit = linux_sdio_deinit; nwi->io_func.u.sdio.sdio_cmd52 = linux_sdio_cmd52; nwi->io_func.u.sdio.sdio_cmd53 = linux_sdio_cmd53; - nwi->io_func.u.sdio.sdio_set_max_speed = linux_sdio_set_max_speed; - nwi->io_func.u.sdio.sdio_set_default_speed = linux_sdio_set_default_speed; + nwi->io_func.u.sdio.sdio_set_max_speed = linux_sdio_set_speed(MAX_SPEED); + nwi->io_func.u.sdio.sdio_set_default_speed = linux_sdio_set_speed(sdio_default_speed); #else nwi->io_func.io_type = HIF_SPI; nwi->io_func.io_init = linux_spi_init; -- 2.1.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-28 11:04 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-28 10:56 [PATCH 0/2] Remove wrapper functions and clean up the code Shivani Bhardwaj 2015-10-28 10:57 ` [PATCH 1/2] Staging: wilc1000: linux_wlan_sdio: Drop unnecessary wrapper functions Shivani Bhardwaj 2015-10-28 11:00 ` [Outreachy kernel] " Julia Lawall 2015-10-28 11:02 ` Shivani Bhardwaj 2015-10-28 11:04 ` Julia Lawall 2015-10-28 11:04 ` Shivani Bhardwaj 2015-10-28 10:57 ` [PATCH 2/2] Staging: wilc1000: linux_wlan: Replace function calls Shivani Bhardwaj
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.