[PATCH v2 0/2] remove SDKMACHINE variable

[PATCH v2 0/2] remove SDKMACHINE variable

[Ed Bartosh]

Hi,

This patchset contains two identical changes for toasterconf.json: removing
SDKMACHINE variable. Variable is not used in toaster anymore as it's removed
by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html

The patchset logically belongs to my previous patchset: 8279: Provide a single way of starting Toaster
I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.

Please, send them after my previous patchset is accepted.

Changes in v2: removed forgotten comma after "PACKAGE_CLASSES": "package_rpm"

The following changes since commit fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:

  build-appliance-image: Update to jethro head revision (2015-11-03 14:03:03 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove-sdkmachine

Ed Bartosh (2):
  toasterconf: remove SDKMACHINE variable
  toasterconf: remove SDKMACHINE variable

 meta-yocto/conf/toasterconf.json | 3 +--
 meta/conf/toasterconf.json       | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

--
Regards,
Ed

[PATCH v2 1/2] toasterconf: remove SDKMACHINE variable

[Ed Bartosh]

This variable is not used in toaster anymore.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta/conf/toasterconf.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/conf/toasterconf.json b/meta/conf/toasterconf.json
index c8e42ef..1987793 100644
--- a/meta/conf/toasterconf.json
+++ b/meta/conf/toasterconf.json
@@ -4,8 +4,7 @@
         "DISTRO"       : "poky",
         "IMAGE_FSTYPES": "ext3 jffs2 tar.bz2",
         "IMAGE_INSTALL_append": "",
-        "PACKAGE_CLASSES": "package_rpm",
-        "SDKMACHINE"   : "x86_64"
+        "PACKAGE_CLASSES": "package_rpm"
     },
     "layersources": [
         {
-- 
2.1.4

[PATCH v2 2/2] toasterconf: remove SDKMACHINE variable

[Ed Bartosh]

This variable is not used in toaster anymore.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta-yocto/conf/toasterconf.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta-yocto/conf/toasterconf.json b/meta-yocto/conf/toasterconf.json
index 3df1703..3f79f42 100644
--- a/meta-yocto/conf/toasterconf.json
+++ b/meta-yocto/conf/toasterconf.json
@@ -4,8 +4,7 @@
         "DISTRO"       : "poky",
         "IMAGE_FSTYPES": "ext3 jffs2 tar.bz2",
         "IMAGE_INSTALL_append": "",
-        "PACKAGE_CLASSES": "package_rpm",
-        "SDKMACHINE"   : "x86_64"
+        "PACKAGE_CLASSES": "package_rpm"
     },
     "layersources": [
         {
-- 
2.1.4

Re: [PATCH v2 0/2] remove SDKMACHINE variable

[Reyna, David]

Hi Ed,

Have you tested this patch against the project configure variables page?

Specifically, this variable is also coded into these two files:

  views.py
  templates/projectconf.html

Are these files being handled in a separate commit? 

- David


> -----Original Message-----
> From: toaster-bounces@yoctoproject.org [mailto:toaster-
> bounces@yoctoproject.org] On Behalf Of Ed Bartosh
> Sent: Thursday, November 05, 2015 9:23 AM
> To: toaster@yoctoproject.org
> Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
> 
> Hi,
> 
> This patchset contains two identical changes for toasterconf.json:
> removing
> SDKMACHINE variable. Variable is not used in toaster anymore as it's
> removed
> by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-
> October/003234.html
> 
> The patchset logically belongs to my previous patchset: 8279: Provide
> a single way of starting Toaster
> I'm sending this in separate e-mail as below two patches should be
> send to different upstream projects:
> openembedded-core and yocto.
> 
> Please, send them after my previous patchset is accepted.
> 
> Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
> "package_rpm"
> 
> The following changes since commit
> fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
> 
>   build-appliance-image: Update to jethro head revision (2015-11-03
> 14:03:03 +0000)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
>   http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/log/?h=ed/toaster/remove-sdkmachine
> 
> Ed Bartosh (2):
>   toasterconf: remove SDKMACHINE variable
>   toasterconf: remove SDKMACHINE variable
> 
>  meta-yocto/conf/toasterconf.json | 3 +--
>  meta/conf/toasterconf.json       | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> --
> Regards,
> Ed
> 
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster

Re: [PATCH v2 0/2] remove SDKMACHINE variable

[Ed Bartosh]

On Thu, Nov 05, 2015 at 05:41:25PM +0000, Reyna, David wrote:
> Hi Ed,
> 
> Have you tested this patch against the project configure variables page?
> 
> Specifically, this variable is also coded into these two files:
> 
>   views.py
>   templates/projectconf.html
> 
> Are these files being handled in a separate commit? 
> 
Yep, they're both taken care of in this commit:
https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html

BTW, I mentoned it in the cover letter of this patchset.

Regards,
Ed

> > -----Original Message-----
> > From: toaster-bounces@yoctoproject.org [mailto:toaster-
> > bounces@yoctoproject.org] On Behalf Of Ed Bartosh
> > Sent: Thursday, November 05, 2015 9:23 AM
> > To: toaster@yoctoproject.org
> > Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
> > 
> > Hi,
> > 
> > This patchset contains two identical changes for toasterconf.json:
> > removing
> > SDKMACHINE variable. Variable is not used in toaster anymore as it's
> > removed
> > by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-
> > October/003234.html
> > 
> > The patchset logically belongs to my previous patchset: 8279: Provide
> > a single way of starting Toaster
> > I'm sending this in separate e-mail as below two patches should be
> > send to different upstream projects:
> > openembedded-core and yocto.
> > 
> > Please, send them after my previous patchset is accepted.
> > 
> > Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
> > "package_rpm"
> > 
> > The following changes since commit
> > fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
> > 
> >   build-appliance-image: Update to jethro head revision (2015-11-03
> > 14:03:03 +0000)
> > 
> > are available in the git repository at:
> > 
> >   git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
> >   http://git.yoctoproject.org/cgit.cgi/poky-
> > contrib/log/?h=ed/toaster/remove-sdkmachine
> > 
> > Ed Bartosh (2):
> >   toasterconf: remove SDKMACHINE variable
> >   toasterconf: remove SDKMACHINE variable
> > 
> >  meta-yocto/conf/toasterconf.json | 3 +--
> >  meta/conf/toasterconf.json       | 3 +--
> >  2 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > --
> > Regards,
> > Ed
> > 
> > --
> > _______________________________________________
> > toaster mailing list
> > toaster@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/toaster

-- 
--
Regards,
Ed

Re: [PATCH v2 0/2] remove SDKMACHINE variable

[Barros Pena, Belen]

On 05/11/2015 17:22, "toaster-bounces@yoctoproject.org on behalf of Ed
Bartosh" <toaster-bounces@yoctoproject.org on behalf of
ed.bartosh@linux.intel.com> wrote:

>Hi,
>
>This patchset contains two identical changes for toasterconf.json:
>removing
>SDKMACHINE variable. Variable is not used in toaster anymore as it's
>removed
>by this change: 
>https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html
>
>The patchset logically belongs to my previous patchset: 8279: Provide a
>single way of starting Toaster
>I'm sending this in separate e-mail as below two patches should be send
>to different upstream projects:
>openembedded-core and yocto.
>
>Please, send them after my previous patchset is accepted.
>
>Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
>"package_rpm"
>
>The following changes since commit
>fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>
>  build-appliance-image: Update to jethro head revision (2015-11-03
>14:03:03 +0000)
>
>are available in the git repository at:
>
>  git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
>  
>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove
>-sdkmachine

No more complaints: both the meta and meta-yocto conf files load without
issues.

Thanks!

Belén

>
>Ed Bartosh (2):
>  toasterconf: remove SDKMACHINE variable
>  toasterconf: remove SDKMACHINE variable
>
> meta-yocto/conf/toasterconf.json | 3 +--
> meta/conf/toasterconf.json       | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>--
>Regards,
>Ed
>
>-- 
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster

Re: [PATCH v2 0/2] remove SDKMACHINE variable

[Barros Pena, Belen]

On 06/11/2015 07:56, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Ed and Belén,
>
>> Specifically, this variable is also coded into these two files:
>>   views.py
>>   templates/projectconf.html
>
>If you want, I can take this task on and remove references to SDKMACHINE
>from these files, given that I am the one who put them in in the first
>place.

Looks like we need some changes in the template. The variable does not
display in the BitBake variables page (as expected, since it is no longer
set in the default configuration), but if you add it, you cannot delete it
(the 'delete' icon is missing). David: since you are familiar with that
template, do you think you could take care of this? When SDKMACHINE is not
defined, you should be able to add it and delete it like any other
variable using the 'add variable' form and the delete icon.

I can open a Bugzilla entry to track the work if you want me to.

Thanks!

Belén

 
>
>- David
>
>> -----Original Message-----
>> From: Reyna, David
>> Sent: Thursday, November 05, 2015 9:41 AM
>> To: 'Ed Bartosh'; toaster@yoctoproject.org
>> Subject: RE: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>> 
>> Hi Ed,
>> 
>> Have you tested this patch against the project configure variables
>> page?
>> 
>> Specifically, this variable is also coded into these two files:
>> 
>>   views.py
>>   templates/projectconf.html
>> 
>> Are these files being handled in a separate commit?
>> 
>> - David
>> 
>> 
>> > -----Original Message-----
>> > From: toaster-bounces@yoctoproject.org [mailto:toaster-
>> > bounces@yoctoproject.org] On Behalf Of Ed Bartosh
>> > Sent: Thursday, November 05, 2015 9:23 AM
>> > To: toaster@yoctoproject.org
>> > Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>> >
>> > Hi,
>> >
>> > This patchset contains two identical changes for toasterconf.json:
>> > removing
>> > SDKMACHINE variable. Variable is not used in toaster anymore as it's
>> > removed
>> > by this change:
>> https://lists.yoctoproject.org/pipermail/toaster/2015-
>> > October/003234.html
>> >
>> > The patchset logically belongs to my previous patchset: 8279:
>> Provide
>> > a single way of starting Toaster
>> > I'm sending this in separate e-mail as below two patches should be
>> > send to different upstream projects:
>> > openembedded-core and yocto.
>> >
>> > Please, send them after my previous patchset is accepted.
>> >
>> > Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
>> > "package_rpm"
>> >
>> > The following changes since commit
>> > fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>> >
>> >   build-appliance-image: Update to jethro head revision (2015-11-03
>> > 14:03:03 +0000)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.yoctoproject.org/poky-contrib ed/toaster/remove-
>> sdkmachine
>> >   http://git.yoctoproject.org/cgit.cgi/poky-
>> > contrib/log/?h=ed/toaster/remove-sdkmachine
>> >
>> > Ed Bartosh (2):
>> >   toasterconf: remove SDKMACHINE variable
>> >   toasterconf: remove SDKMACHINE variable
>> >
>> >  meta-yocto/conf/toasterconf.json | 3 +--
>> >  meta/conf/toasterconf.json       | 3 +--
>> >  2 files changed, 2 insertions(+), 4 deletions(-)
>> >
>> > --
>> > Regards,
>> > Ed
>> >
>> > --
>> > _______________________________________________
>> > toaster mailing list
>> > toaster@yoctoproject.org
>> > https://lists.yoctoproject.org/listinfo/toaster

Re: [PATCH v2 0/2] remove SDKMACHINE variable

[Barros Pena, Belen]

On 06/11/2015 11:46, "toaster-bounces@yoctoproject.org on behalf of Barros
Pena, Belen" <toaster-bounces@yoctoproject.org on behalf of
belen.barros.pena@intel.com> wrote:

>
>
>On 06/11/2015 07:56, "Reyna, David" <david.reyna@windriver.com> wrote:
>
>>Hi Ed and Belén,
>>
>>> Specifically, this variable is also coded into these two files:
>>>   views.py
>>>   templates/projectconf.html
>>
>>If you want, I can take this task on and remove references to SDKMACHINE
>>from these files, given that I am the one who put them in in the first
>>place.
>
>Looks like we need some changes in the template. The variable does not
>display in the BitBake variables page (as expected, since it is no longer
>set in the default configuration), but if you add it, you cannot delete it
>(the 'delete' icon is missing). David: since you are familiar with that
>template, do you think you could take care of this? When SDKMACHINE is not
>defined, you should be able to add it and delete it like any other
>variable using the 'add variable' form and the delete icon.

Just ignore me. This commit

https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html


Does take care of the issue I described above.

Thanks!

Belén

>
>I can open a Bugzilla entry to track the work if you want me to.
>
>Thanks!
>
>Belén
>
> 
>>
>>- David
>>
>>> -----Original Message-----
>>> From: Reyna, David
>>> Sent: Thursday, November 05, 2015 9:41 AM
>>> To: 'Ed Bartosh'; toaster@yoctoproject.org
>>> Subject: RE: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>>> 
>>> Hi Ed,
>>> 
>>> Have you tested this patch against the project configure variables
>>> page?
>>> 
>>> Specifically, this variable is also coded into these two files:
>>> 
>>>   views.py
>>>   templates/projectconf.html
>>> 
>>> Are these files being handled in a separate commit?
>>> 
>>> - David
>>> 
>>> 
>>> > -----Original Message-----
>>> > From: toaster-bounces@yoctoproject.org [mailto:toaster-
>>> > bounces@yoctoproject.org] On Behalf Of Ed Bartosh
>>> > Sent: Thursday, November 05, 2015 9:23 AM
>>> > To: toaster@yoctoproject.org
>>> > Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>>> >
>>> > Hi,
>>> >
>>> > This patchset contains two identical changes for toasterconf.json:
>>> > removing
>>> > SDKMACHINE variable. Variable is not used in toaster anymore as it's
>>> > removed
>>> > by this change:
>>> https://lists.yoctoproject.org/pipermail/toaster/2015-
>>> > October/003234.html
>>> >
>>> > The patchset logically belongs to my previous patchset: 8279:
>>> Provide
>>> > a single way of starting Toaster
>>> > I'm sending this in separate e-mail as below two patches should be
>>> > send to different upstream projects:
>>> > openembedded-core and yocto.
>>> >
>>> > Please, send them after my previous patchset is accepted.
>>> >
>>> > Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
>>> > "package_rpm"
>>> >
>>> > The following changes since commit
>>> > fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>>> >
>>> >   build-appliance-image: Update to jethro head revision (2015-11-03
>>> > 14:03:03 +0000)
>>> >
>>> > are available in the git repository at:
>>> >
>>> >   git://git.yoctoproject.org/poky-contrib ed/toaster/remove-
>>> sdkmachine
>>> >   http://git.yoctoproject.org/cgit.cgi/poky-
>>> > contrib/log/?h=ed/toaster/remove-sdkmachine
>>> >
>>> > Ed Bartosh (2):
>>> >   toasterconf: remove SDKMACHINE variable
>>> >   toasterconf: remove SDKMACHINE variable
>>> >
>>> >  meta-yocto/conf/toasterconf.json | 3 +--
>>> >  meta/conf/toasterconf.json       | 3 +--
>>> >  2 files changed, 2 insertions(+), 4 deletions(-)
>>> >
>>> > --
>>> > Regards,
>>> > Ed
>>> >
>>> > --
>>> > _______________________________________________
>>> > toaster mailing list
>>> > toaster@yoctoproject.org
>>> > https://lists.yoctoproject.org/listinfo/toaster
>
>-- 
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster