* [PATCH v3 0/2] add dma mapping error and remove parantheses
@ 2016-02-09 19:56 Haneen Mohammed
2016-02-09 20:03 ` [PATCH v3 1/2] Staging: rts5208: fix check for dma mapping error Haneen Mohammed
2016-02-09 20:06 ` [PATCH v3 2/2] Staging: rts5208: remove unnecessary parantheses Haneen Mohammed
0 siblings, 2 replies; 3+ messages in thread
From: Haneen Mohammed @ 2016-02-09 19:56 UTC (permalink / raw)
To: outreachy-kernel
This patchset fix check for dma mapping error, as well as removes
unnecessary parantheses in the same scope.
Haneen Mohammed (2):
Staging: rts5208: fix check for dma mapping error
Staging: rts5208: remove unnecessary parantheses
drivers/staging/rts5208/rtsx_transport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/2] Staging: rts5208: fix check for dma mapping error
2016-02-09 19:56 [PATCH v3 0/2] add dma mapping error and remove parantheses Haneen Mohammed
@ 2016-02-09 20:03 ` Haneen Mohammed
2016-02-09 20:06 ` [PATCH v3 2/2] Staging: rts5208: remove unnecessary parantheses Haneen Mohammed
1 sibling, 0 replies; 3+ messages in thread
From: Haneen Mohammed @ 2016-02-09 20:03 UTC (permalink / raw)
To: outreachy-kernel
use dma_mapping_error() instead of comparing the returned address with
zero after dma_map_single().
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
Changes in v2: Make patchset to remove extra parantheses
Changes in v3: Add acknowledgement.
drivers/staging/rts5208/rtsx_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index f27491e..0c9549b 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -653,7 +653,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
return -ENXIO;
addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
- if (!addr)
+ if (dma_mapping_error(&rtsx->pci->dev, addr))
return -ENOMEM;
if (card == SD_CARD)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] Staging: rts5208: remove unnecessary parantheses
2016-02-09 19:56 [PATCH v3 0/2] add dma mapping error and remove parantheses Haneen Mohammed
2016-02-09 20:03 ` [PATCH v3 1/2] Staging: rts5208: fix check for dma mapping error Haneen Mohammed
@ 2016-02-09 20:06 ` Haneen Mohammed
1 sibling, 0 replies; 3+ messages in thread
From: Haneen Mohammed @ 2016-02-09 20:06 UTC (permalink / raw)
To: outreachy-kernel
This patch removes unnecessary parantheses around rtsx->pci->dev.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
Changes in v3: Add acknowledgement.
drivers/staging/rts5208/rtsx_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index 0c9549b..f2eb18e 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -652,7 +652,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
else
return -ENXIO;
- addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
+ addr = dma_map_single(&rtsx->pci->dev, buf, len, dma_dir);
if (dma_mapping_error(&rtsx->pci->dev, addr))
return -ENOMEM;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-09 20:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09 19:56 [PATCH v3 0/2] add dma mapping error and remove parantheses Haneen Mohammed
2016-02-09 20:03 ` [PATCH v3 1/2] Staging: rts5208: fix check for dma mapping error Haneen Mohammed
2016-02-09 20:06 ` [PATCH v3 2/2] Staging: rts5208: remove unnecessary parantheses Haneen Mohammed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.