[PATCH 0/1] toaster: speed up and harden lsof usage

[PATCH 0/1] toaster: speed up and harden lsof usage

[brian avery]

This adds a -t to the lsof command so that it:
1) runs faster
2) doesn't give a warning on esoteric file system mounts (a docker experiment in my case)

If it does give a warning then the script assumes restarting bitbake failed and no build happens.
-b

The following changes since commit 246b02e281f84ffe1c9156ce24b728eb6f3742c1:

  ptest-runner: Explicitly set EXTRA_OEMAKE as required (2016-02-10 16:06:25 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib bavery/toaster/betterlsof
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/betterlsof

brian avery (1):
  add a -t to the lsof command so that it is faster and it won't fail on
    esoteric filesystem mounts since it is just looking at processes.

 bin/toaster | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.9.1

[PATCH 1/1] add a -t to the lsof command so that it is faster and it won't fail on esoteric filesystem mounts since it is just looking at processes.

[brian avery]

Signed-off-by: brian avery <avery.brian@gmail.com>
---
 bin/toaster | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/toaster b/bin/toaster
index 72eae64..89318f0 100755
--- a/bin/toaster
+++ b/bin/toaster
@@ -128,7 +128,7 @@ stop_bitbake() {
     BBSERVER=0.0.0.0:-1 bitbake -m
     unset BBSERVER
     # force stop any misbehaving bitbake server
-    lsof bitbake.lock | awk '{print $2}' | grep "[0-9]\+" | xargs -n1 -r kill
+    lsof -t bitbake.lock | awk '{print $2}' | grep "[0-9]\+" | xargs -n1 -r kill
 }
 
 verify_prereq() {
-- 
1.9.1

Re: [PATCH 0/1] toaster: speed up and harden lsof usage

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

On 10 February 2016 at 17:56, brian avery <avery.brian@gmail.com> wrote:

> This adds a -t to the lsof command so that it:
> 1) runs faster
> 2) doesn't give a warning on esoteric file system mounts (a docker
> experiment in my case)
>

Hello Brian.

I attempted to merge this today and it failed. You can either rebase and
submit it yourself (looks fine to me) or send for review and I'll submit it.

Elliot


>
> If it does give a warning then the script assumes restarting bitbake
> failed and no build happens.
> -b
>
> The following changes since commit
> 246b02e281f84ffe1c9156ce24b728eb6f3742c1:
>
>   ptest-runner: Explicitly set EXTRA_OEMAKE as required (2016-02-10
> 16:06:25 +0000)
>
> are available in the git repository at:
>
>   git://git.yoctoproject.org/poky-contrib bavery/toaster/betterlsof
>
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/betterlsof
>
> brian avery (1):
>   add a -t to the lsof command so that it is faster and it won't fail on
>     esoteric filesystem mounts since it is just looking at processes.
>
>  bin/toaster | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 1.9.1
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 2698 bytes --]

Re: [PATCH 0/1] toaster: speed up and harden lsof usage

[Brian Avery]

Thanks, I'll rebase and resubmit.
-b

On Tue, Feb 23, 2016 at 2:45 AM, Smith, Elliot <elliot.smith@intel.com> wrote:
> On 10 February 2016 at 17:56, brian avery <avery.brian@gmail.com> wrote:
>>
>> This adds a -t to the lsof command so that it:
>> 1) runs faster
>> 2) doesn't give a warning on esoteric file system mounts (a docker
>> experiment in my case)
>
>
> Hello Brian.
>
> I attempted to merge this today and it failed. You can either rebase and
> submit it yourself (looks fine to me) or send for review and I'll submit it.
>
> Elliot
>
>>
>>
>> If it does give a warning then the script assumes restarting bitbake
>> failed and no build happens.
>> -b
>>
>> The following changes since commit
>> 246b02e281f84ffe1c9156ce24b728eb6f3742c1:
>>
>>   ptest-runner: Explicitly set EXTRA_OEMAKE as required (2016-02-10
>> 16:06:25 +0000)
>>
>> are available in the git repository at:
>>
>>   git://git.yoctoproject.org/poky-contrib bavery/toaster/betterlsof
>>
>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/betterlsof
>>
>> brian avery (1):
>>   add a -t to the lsof command so that it is faster and it won't fail on
>>     esoteric filesystem mounts since it is just looking at processes.
>>
>>  bin/toaster | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --
>> 1.9.1
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre