[PATCH 0/2] Remove unused macros

[PATCH 0/2] Remove unused macros

[Bhumika Goyal]

This patchset remove PlatformAcquireSpinLock and PlatformReleaseSpinLock 
macros as they are not used anywhere. Also remove the commented places 
where these macros were used. Used grep to find occurences.

Bhumika Goyal (2):
  Staging: rtl8723au: Remove unused macros
  Staging: rtl8192u: Remove useless comments

 drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 5 -----
 drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
 2 files changed, 7 deletions(-)

-- 
1.9.1

[PATCH 1/2] Staging: rtl8723au: Remove unused macros

[Bhumika Goyal]

The macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are
not used anywhere so remove them. Used grep to find occurences.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
index d46d1c7..33eabf4 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
@@ -80,8 +80,6 @@ if ((BTCoexDbgLevel == _bt_dbg_on_)) {\
 #define PlatformProcessHCICommands(...)
 #define PlatformTxBTQueuedPackets(...)
 #define PlatformIndicateBTACLData(...)	(RT_STATUS_SUCCESS)
-#define PlatformAcquireSpinLock(padapter, type)
-#define PlatformReleaseSpinLock(padapter, type)
 
 #define GET_UNDECORATED_AVERAGE_RSSI(padapter)	\
 			(GET_HAL_DATA(padapter)->dmpriv.EntryMinUndecoratedSmoothedPWDB)
-- 
1.9.1

[PATCH 2/2] Staging: rtl8192u: Remove useless comments

[Bhumika Goyal]

Remove the commented out places where macros PlatformAcquireSpinLock and
PlatformReleaseSpinLock are called as these macros are no longer used.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
index f33c743..2b182e1 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
@@ -35,9 +35,7 @@ static void RxPktPendingTimeout(unsigned long data)
 	u8 index = 0;
 	bool bPktInBuf = false;
 
-
 	spin_lock_irqsave(&(ieee->reorder_spinlock), flags);
-	//PlatformAcquireSpinLock(Adapter, RT_RX_SPINLOCK);
 	IEEE80211_DEBUG(IEEE80211_DL_REORDER,"==================>%s()\n",__func__);
 	if(pRxTs->RxTimeoutIndicateSeq != 0xffff)
 	{
@@ -90,7 +88,6 @@ static void RxPktPendingTimeout(unsigned long data)
 		mod_timer(&pRxTs->RxPktPendingTimer,  jiffies + MSECS(ieee->pHTInfo->RxReorderPendingTime));
 	}
 	spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags);
-	//PlatformReleaseSpinLock(Adapter, RT_RX_SPINLOCK);
 }
 
 /********************************************************************************************************************
@@ -469,7 +466,6 @@ static void RemoveTsEntry(struct ieee80211_device *ieee, PTS_COMMON_INFO pTs,
 
 		while(!list_empty(&pRxTS->RxPendingPktList))
 		{
-		//      PlatformAcquireSpinLock(Adapter, RT_RX_SPINLOCK);
 			spin_lock_irqsave(&(ieee->reorder_spinlock), flags);
 			//pRxReorderEntry = list_entry(&pRxTS->RxPendingPktList.prev,RX_REORDER_ENTRY,List);
 			pRxReorderEntry = (PRX_REORDER_ENTRY)list_entry(pRxTS->RxPendingPktList.prev,RX_REORDER_ENTRY,List);
@@ -489,7 +485,6 @@ static void RemoveTsEntry(struct ieee80211_device *ieee, PTS_COMMON_INFO pTs,
 				prxb = NULL;
 			}
 			list_add_tail(&pRxReorderEntry->List,&ieee->RxReorder_Unused_List);
-			//PlatformReleaseSpinLock(Adapter, RT_RX_SPINLOCK);
 			spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags);
 		}
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH 0/2] Remove unused macros

[Julia Lawall]

On Sun, 14 Feb 2016, Bhumika Goyal wrote:

> This patchset remove PlatformAcquireSpinLock and PlatformReleaseSpinLock 
> macros as they are not used anywhere. Also remove the commented places 
> where these macros were used. Used grep to find occurences.

Isn't this a v2?

julia

> Bhumika Goyal (2):
>   Staging: rtl8723au: Remove unused macros
>   Staging: rtl8192u: Remove useless comments
> 
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 5 -----
>  drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
>  2 files changed, 7 deletions(-)
> 
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1455427132.git.bhumirks%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH 0/2] Remove unused macros

[Bhumika Goyal]

[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]



On Sunday, February 14, 2016 at 12:50:08 PM UTC+5:30, Julia Lawall wrote:
>
> On Sun, 14 Feb 2016, Bhumika Goyal wrote: 
>
> > This patchset remove PlatformAcquireSpinLock and PlatformReleaseSpinLock 
> > macros as they are not used anywhere. Also remove the commented places 
> > where these macros were used. Used grep to find occurences. 
>
> Isn't this a v2?
>
   
     Actually I broke v1 in two patches so I thought it should be a new 
patchset. v1 had just one patch so can v2 for the same  be a patchset? 
     Thanks,
     Bhumika

julia 
>
> > Bhumika Goyal (2): 
> >   Staging: rtl8723au: Remove unused macros 
> >   Staging: rtl8192u: Remove useless comments 
> > 
> >  drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 5 ----- 
> >  drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 -- 
> >  2 files changed, 7 deletions(-) 
> > 
> > -- 
> > 1.9.1 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/cover.1455427132.git.bhumirks%40gmail.com. 
>
> > For more options, visit https://groups.google.com/d/optout. 
> > 
>

[-- Attachment #1.2: Type: text/html, Size: 2978 bytes --]

Re: [Outreachy kernel] [PATCH 0/2] Remove unused macros

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2254 bytes --]



On Sun, 14 Feb 2016, Bhumika Goyal wrote:

> 
> 
> On Sunday, February 14, 2016 at 12:50:08 PM UTC+5:30, Julia Lawall wrote:
>       On Sun, 14 Feb 2016, Bhumika Goyal wrote:
> 
>       > This patchset remove PlatformAcquireSpinLock and
>       PlatformReleaseSpinLock
>       > macros as they are not used anywhere. Also remove the
>       commented places
>       > where these macros were used. Used grep to find occurences.
> 
>       Isn't this a v2?
> 
>   
>      Actually I broke v1 in two patches so I thought it should be a new
> patchset. v1 had just one patch so can v2 for the same  be a patchset?

v2 would make it more clear that v1 should be ignored.

julia

>      Thanks,
>      Bhumika
> 
>       julia
> 
>       > Bhumika Goyal (2):
>       >   Staging: rtl8723au: Remove unused macros
>       >   Staging: rtl8192u: Remove useless comments
>       >
>       >  drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 5 -----
>       >  drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
>       >  2 files changed, 7 deletions(-)
>       >
>       > --
>       > 1.9.1
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an email to outreachy-kern...@googlegroups.com.
>       > To post to this group, send email to
>       outreach...@googlegroups.com.
>       > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/cover.1455427132.git.bhu
>       mirks%40gmail.com.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
> 
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/31a999e2-93a3-48b0-950b-
> b8ec533158e3%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 
> 

[PATCH 0/2] Remove unused macros

[Shraddha Barke]

This patchset removes the macros since they are not used anywhere 
throughout the kernel.
 
Shraddha Barke (2):
  Staging: iio: cdc: ad7150: Remove unused macros
  Staging: iio: cdc: ad7152: Remove unused macros

 drivers/staging/iio/cdc/ad7150.c | 10 ----------
 drivers/staging/iio/cdc/ad7152.c | 18 ------------------
 2 files changed, 28 deletions(-)

-- 
2.1.4