All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliangtang@163.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
	Jes Sorensen <Jes.Sorensen@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Julian Calaby <julian.calaby@gmail.com>
Cc: Geliang Tang <geliangtang@163.com>,
	linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning
Date: Thu, 18 Feb 2016 22:19:28 +0800	[thread overview]
Message-ID: <cover.1455804404.git.geliangtang@163.com> (raw)
In-Reply-To: <wrfjtwl76ybi.fsf@redhat.com>

On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote:
> kbuild test robot <lkp@intel.com> writes:
> > Hi Geliang,
> >
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.5-rc4 next-20160217]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> >
> > url:    https://github.com/0day-ci/linux/commits/Geliang-Tang/staging-rtl8723au-use-list_for_each_entry/20160217-220638
> > config: i386-randconfig-s1-201607 (attached as .config)
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386 
> >
> > Note: the linux-review/Geliang-Tang/staging-rtl8723au-use-list_for_each_entry/20160217-220638 HEAD 495811a52aba181af76c3baf57da3d81a79c2fe8 builds fine.
> >       It only hurts bisectibility.
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/staging/rtl8723au/core/rtw_recv.c: In function 'rtw_free_recvframe23a_queue':
> >>> drivers/staging/rtl8723au/core/rtw_recv.c:203:2: error: 'plist' undeclared (first use in this function)
> >      plist = phead->next;
> >      ^
> 
> This doesn't work, you cannot break interim builds. Your patch 2 needs
> to go before patch 1, and you must always check that they compile for
> each patch you apply.
> 
> NACK

Sorry for the trouble caused. I updated my patchs to fix this problem.

- Geliang

This patch set uses list_for_each_entry*() instead of
list_for_each*(), removes useless codes, and cleans
whitespaces and blank lines.

Changes in v5:
 - fix build error.
Changes in v4:
 - revise the patchs as Jes suggested.
Changes in v3:
 - split it into three patches.
Changes in v2:
 - drop the coding style fixing in v1.

Geliang Tang (3):
  staging: rtl8723au: use list_for_each_entry*()
  staging: rtl8723au: core: rtw_recv: remove useless codes
  staging: rtl8723au: whitespace and blank line cleaning

 drivers/staging/rtl8723au/core/rtw_ap.c           | 92 ++++++-----------------
 drivers/staging/rtl8723au/core/rtw_mlme.c         | 38 +++-------
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c     | 13 ++--
 drivers/staging/rtl8723au/core/rtw_recv.c         | 42 ++++-------
 drivers/staging/rtl8723au/core/rtw_sta_mgt.c      | 36 +++------
 drivers/staging/rtl8723au/core/rtw_xmit.c         | 90 ++++++++--------------
 drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 22 ++----
 drivers/staging/rtl8723au/os_dep/usb_ops_linux.c  |  9 +--
 8 files changed, 106 insertions(+), 236 deletions(-)

-- 
2.5.0



  reply	other threads:[~2016-02-18 14:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-31 15:47 [PATCH] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-01-31 17:49 ` Jes Sorensen
2016-02-01 14:10   ` [PATCH v2] " Geliang Tang
2016-02-02 20:30     ` Jes Sorensen
2016-02-07  3:29       ` [PATCH v3 1/3] " Geliang Tang
2016-02-07  3:29         ` [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-07  3:30           ` [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-07 22:17             ` Julian Calaby
2016-02-15 15:43               ` Jes Sorensen
2016-02-15 15:33           ` [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Jes Sorensen
2016-02-15 15:32         ` [PATCH v3 1/3] staging: rtl8723au: use list_for_each_entry*() Jes Sorensen
2016-02-17 13:48           ` [PATCH v4 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang
2016-02-17 13:48             ` [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-02-17 13:48               ` [PATCH v4 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-17 13:48                 ` [PATCH v4 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-17 15:16               ` [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() kbuild test robot
2016-02-17 17:28                 ` Jes Sorensen
2016-02-18 14:19                   ` Geliang Tang [this message]
2016-02-18 14:19                     ` [PATCH v5 " Geliang Tang
2016-02-18 14:19                       ` [PATCH v5 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-18 14:19                         ` [PATCH v5 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-18 19:09                     ` [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1455804404.git.geliangtang@163.com \
    --to=geliangtang@163.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=julian.calaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.