From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Geliang Tang <geliangtang@163.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julian Calaby <julian.calaby@gmail.com>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning
Date: Thu, 18 Feb 2016 14:09:34 -0500 [thread overview]
Message-ID: <wrfjbn7dzvgx.fsf@redhat.com> (raw)
In-Reply-To: <cover.1455804404.git.geliangtang@163.com> (Geliang Tang's message of "Thu, 18 Feb 2016 22:19:28 +0800")
Geliang Tang <geliangtang@163.com> writes:
> On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote:
>> kbuild test robot <lkp@intel.com> writes:
>> > All errors (new ones prefixed by >>):
>> >
>> > drivers/staging/rtl8723au/core/rtw_recv.c: In function 'rtw_free_recvframe23a_queue':
>> >>> drivers/staging/rtl8723au/core/rtw_recv.c:203:2: error: 'plist' undeclared (first use in this function)
>> > plist = phead->next;
>> > ^
>>
>> This doesn't work, you cannot break interim builds. Your patch 2 needs
>> to go before patch 1, and you must always check that they compile for
>> each patch you apply.
>>
>> NACK
>
> Sorry for the trouble caused. I updated my patchs to fix this problem.
>
> - Geliang
>
> This patch set uses list_for_each_entry*() instead of
> list_for_each*(), removes useless codes, and cleans
> whitespaces and blank lines.
No worries, I much prefer taking a few rounds to get it right.
This set looks good to me.
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
prev parent reply other threads:[~2016-02-18 19:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 15:47 [PATCH] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-01-31 17:49 ` Jes Sorensen
2016-02-01 14:10 ` [PATCH v2] " Geliang Tang
2016-02-02 20:30 ` Jes Sorensen
2016-02-07 3:29 ` [PATCH v3 1/3] " Geliang Tang
2016-02-07 3:29 ` [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-07 3:30 ` [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-07 22:17 ` Julian Calaby
2016-02-15 15:43 ` Jes Sorensen
2016-02-15 15:33 ` [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Jes Sorensen
2016-02-15 15:32 ` [PATCH v3 1/3] staging: rtl8723au: use list_for_each_entry*() Jes Sorensen
2016-02-17 13:48 ` [PATCH v4 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang
2016-02-17 13:48 ` [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-02-17 13:48 ` [PATCH v4 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-17 13:48 ` [PATCH v4 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-17 15:16 ` [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() kbuild test robot
2016-02-17 17:28 ` Jes Sorensen
2016-02-18 14:19 ` [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang
2016-02-18 14:19 ` [PATCH v5 1/3] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-02-18 14:19 ` [PATCH v5 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-18 14:19 ` [PATCH v5 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-18 19:09 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjbn7dzvgx.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=geliangtang@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.