[PATCH 0/2] Staging: Use ether_addr_equal_64bits() insted of ether_addr_equal().

[PATCH 0/2] Staging: Use ether_addr_equal_64bits() insted of ether_addr_equal().

[Sandhya Bankar]

Use ether_addr_equal_64bits() insted of ether_addr_equal().
ether_addr_equal_64bits() is more efficient than ether_addr_equal(), and can be used when each argument is an array within a structure.

Sandhya Bankar (2):
  [PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal().
  [PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().

 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
 drivers/staging/slicoss/slicoss.c         | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

-- 
1.8.3.4

Re: [Outreachy kernel] [PATCH 0/2] Staging: Use ether_addr_equal_64bits() insted of ether_addr_equal().

[Julia Lawall]

On Sun, 28 Feb 2016, Sandhya Bankar wrote:

> Use ether_addr_equal_64bits() insted of ether_addr_equal().
> ether_addr_equal_64bits() is more efficient than ether_addr_equal(), and can be used when each argument is an array within a structure.

This seems to have come to me more slowly than the patches :)

However, it would be good to have the explanation in the patches, because 
that is the only thing that will be committed.  The cover letter just 
exists in the mailing list.

You chould check in each case that the mentioned field is not at the end 
of the structure, ie that it has at least two bytes within the structure 
after it.

However, what I recall from the mailing list discussions on this issue was 
that the condition for the call being valid was considered to be quite 
fragile, and so using this function was not considered to be worth it 
unless performance was really critical.

julia

> 
> Sandhya Bankar (2):
>   [PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal().
>   [PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().
> 
>  drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
>  drivers/staging/slicoss/slicoss.c         | 4 ++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> -- 
> 1.8.3.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1456660509.git.bankarsandhya512%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH 0/2] Staging: Use ether_addr_equal_64bits() insted of ether_addr_equal().

[sandhya bankar]

[-- Attachment #1: Type: text/plain, Size: 2145 bytes --]

Thanks for the information.!!
I will provide detail explanation of the patch in message body as well as
cover letter in upcoming patches.


Thanks
Sandhya

On Mon, Feb 29, 2016 at 1:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:

> On Sun, 28 Feb 2016, Sandhya Bankar wrote:
>
> > Use ether_addr_equal_64bits() insted of ether_addr_equal().
> > ether_addr_equal_64bits() is more efficient than ether_addr_equal(), and
> can be used when each argument is an array within a structure.
>
> This seems to have come to me more slowly than the patches :)
>
> However, it would be good to have the explanation in the patches, because
> that is the only thing that will be committed.  The cover letter just
> exists in the mailing list.
>
> You chould check in each case that the mentioned field is not at the end
> of the structure, ie that it has at least two bytes within the structure
> after it.
>
> However, what I recall from the mailing list discussions on this issue was
> that the condition for the call being valid was considered to be quite
> fragile, and so using this function was not considered to be worth it
> unless performance was really critical.
>
> julia
>
> >
> > Sandhya Bankar (2):
> >   [PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of
> ether_addr_equal().
> >   [PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead
> of ether_addr_equal().
> >
> >  drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
> >  drivers/staging/slicoss/slicoss.c         | 4 ++--
> >  2 files changed, 5 insertions(+), 4 deletions(-)
> >
> > --
> > 1.8.3.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/cover.1456660509.git.bankarsandhya512%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>

[-- Attachment #2: Type: text/html, Size: 3174 bytes --]