* [PATCH 0/3] Staging: Remove unused functions and prototypes
@ 2016-03-11 6:58 Bhumika Goyal
2016-03-11 6:58 ` [PATCH 1/3] Staging: sm750fb: Remove unused functions Bhumika Goyal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bhumika Goyal @ 2016-03-11 6:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Bhumika Goyal
This patchset removes some functions as they are not used anywhere
in the kernel. Also, remove their function prototypes.
Bhumika Goyal (3):
Staging: sm750fb: Remove unused functions
Staging: rtl8723au: Remove unused functions and prototype
taging: rtl8723au: Remove empty function odm_Init_RSSIForDM23a
drivers/staging/rtl8723au/core/rtw_ap.c | 115 -----------------------
drivers/staging/rtl8723au/hal/odm_HWConfig.c | 4 -
drivers/staging/rtl8723au/include/odm_HWConfig.h | 2 -
drivers/staging/rtl8723au/include/rtw_ap.h | 3 -
drivers/staging/sm750fb/ddk750_dvi.c | 38 --------
drivers/staging/sm750fb/ddk750_dvi.h | 3 -
6 files changed, 165 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/3] Staging: sm750fb: Remove unused functions 2016-03-11 6:58 [PATCH 0/3] Staging: Remove unused functions and prototypes Bhumika Goyal @ 2016-03-11 6:58 ` Bhumika Goyal 2016-03-11 6:58 ` [PATCH 2/3] Staging: rtl8723au: Remove unused functions and prototype Bhumika Goyal 2016-03-11 6:58 ` [PATCH 3/3] taging: rtl8723au: Remove empty function odm_Init_RSSIForDM23a Bhumika Goyal 2 siblings, 0 replies; 4+ messages in thread From: Bhumika Goyal @ 2016-03-11 6:58 UTC (permalink / raw) To: outreachy-kernel; +Cc: Bhumika Goyal The functions dviGetDeviceID and dviGetVendorID are not used anywhere in the kernel so remove them. Also, remove their function prototypes. Grepped to find occurences. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/staging/sm750fb/ddk750_dvi.c | 38 ------------------------------------ drivers/staging/sm750fb/ddk750_dvi.h | 3 --- 2 files changed, 41 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index a7a2351..a4a2550 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -53,44 +53,6 @@ int dviInit( return -1; /* error */ } - -/* - * dviGetVendorID - * This function gets the vendor ID of the DVI controller chip. - * - * Output: - * Vendor ID - */ -unsigned short dviGetVendorID(void) -{ - dvi_ctrl_device_t *pCurrentDviCtrl; - - pCurrentDviCtrl = g_dcftSupportedDviController; - if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0) - return pCurrentDviCtrl->pfnGetVendorId(); - - return 0x0000; -} - - -/* - * dviGetDeviceID - * This function gets the device ID of the DVI controller chip. - * - * Output: - * Device ID - */ -unsigned short dviGetDeviceID(void) -{ - dvi_ctrl_device_t *pCurrentDviCtrl; - - pCurrentDviCtrl = g_dcftSupportedDviController; - if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0) - return pCurrentDviCtrl->pfnGetDeviceId(); - - return 0x0000; -} - #endif diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index e1d4c9a..677939c 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -55,8 +55,5 @@ int dviInit( unsigned char pllFilterValue ); -unsigned short dviGetVendorID(void); -unsigned short dviGetDeviceID(void); - #endif -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] Staging: rtl8723au: Remove unused functions and prototype 2016-03-11 6:58 [PATCH 0/3] Staging: Remove unused functions and prototypes Bhumika Goyal 2016-03-11 6:58 ` [PATCH 1/3] Staging: sm750fb: Remove unused functions Bhumika Goyal @ 2016-03-11 6:58 ` Bhumika Goyal 2016-03-11 6:58 ` [PATCH 3/3] taging: rtl8723au: Remove empty function odm_Init_RSSIForDM23a Bhumika Goyal 2 siblings, 0 replies; 4+ messages in thread From: Bhumika Goyal @ 2016-03-11 6:58 UTC (permalink / raw) To: outreachy-kernel; +Cc: Bhumika Goyal The functions rtw_ap_inform_ch_switch23a, rtw_acl_remove_sta23a and rtw_acl_add_sta23a are not used anywhere in the kernel. So remove their definition and prototype. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/staging/rtl8723au/core/rtw_ap.c | 115 ----------------------------- drivers/staging/rtl8723au/include/rtw_ap.h | 3 - 2 files changed, 118 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c index ce4b589..f68e277 100644 --- a/drivers/staging/rtl8723au/core/rtw_ap.c +++ b/drivers/staging/rtl8723au/core/rtw_ap.c @@ -1046,93 +1046,6 @@ void rtw_set_macaddr_acl23a(struct rtw_adapter *padapter, int mode) pacl_list->mode = mode; } -int rtw_acl_add_sta23a(struct rtw_adapter *padapter, u8 *addr) -{ - struct list_head *phead; - u8 added = false; - int i, ret = 0; - struct rtw_wlan_acl_node *paclnode; - struct sta_priv *pstapriv = &padapter->stapriv; - struct wlan_acl_pool *pacl_list = &pstapriv->acl_list; - struct rtw_queue *pacl_node_q = &pacl_list->acl_node_q; - - DBG_8723A("%s(acl_num =%d) =%pM\n", __func__, pacl_list->num, addr); - - if ((NUM_ACL-1) < pacl_list->num) - return -1; - - spin_lock_bh(&pacl_node_q->lock); - phead = get_list_head(pacl_node_q); - list_for_each_entry(paclnode, phead, list) { - if (!memcmp(paclnode->addr, addr, ETH_ALEN)) { - if (paclnode->valid == true) { - added = true; - DBG_8723A("%s, sta has been added\n", __func__); - break; - } - } - } - spin_unlock_bh(&pacl_node_q->lock); - - if (added) - return ret; - - spin_lock_bh(&pacl_node_q->lock); - - for (i = 0; i < NUM_ACL; i++) { - paclnode = &pacl_list->aclnode[i]; - - if (!paclnode->valid) { - INIT_LIST_HEAD(&paclnode->list); - - memcpy(paclnode->addr, addr, ETH_ALEN); - - paclnode->valid = true; - - list_add_tail(&paclnode->list, get_list_head(pacl_node_q)); - - pacl_list->num++; - - break; - } - } - - DBG_8723A("%s, acl_num =%d\n", __func__, pacl_list->num); - - spin_unlock_bh(&pacl_node_q->lock); - return ret; -} - -int rtw_acl_remove_sta23a(struct rtw_adapter *padapter, u8 *addr) -{ - struct list_head *phead; - struct rtw_wlan_acl_node *paclnode, *ptmp; - struct sta_priv *pstapriv = &padapter->stapriv; - struct wlan_acl_pool *pacl_list = &pstapriv->acl_list; - struct rtw_queue *pacl_node_q = &pacl_list->acl_node_q; - - DBG_8723A("%s(acl_num =%d) = %pM\n", __func__, pacl_list->num, addr); - - spin_lock_bh(&pacl_node_q->lock); - phead = get_list_head(pacl_node_q); - list_for_each_entry_safe(paclnode, ptmp, phead, list) { - if (!memcmp(paclnode->addr, addr, ETH_ALEN)) { - if (paclnode->valid) { - paclnode->valid = false; - - list_del_init(&paclnode->list); - - pacl_list->num--; - } - } - } - spin_unlock_bh(&pacl_node_q->lock); - - DBG_8723A("%s, acl_num =%d\n", __func__, pacl_list->num); - - return 0; -} - static void update_bcn_erpinfo_ie(struct rtw_adapter *padapter) { struct mlme_priv *pmlmepriv = &padapter->mlmepriv; @@ -1598,34 +1511,6 @@ u8 ap_free_sta23a(struct rtw_adapter *padapter, struct sta_info *psta, bool acti return beacon_updated; } -int rtw_ap_inform_ch_switch23a(struct rtw_adapter *padapter, u8 new_ch, u8 ch_offset) -{ - struct list_head *phead; - struct sta_info *psta = NULL; - struct sta_priv *pstapriv = &padapter->stapriv; - struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; - u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; - - if ((pmlmeinfo->state&0x03) != MSR_AP) - return 0; - - DBG_8723A("%s(%s): with ch:%u, offset:%u\n", __func__, - padapter->pnetdev->name, new_ch, ch_offset); - - spin_lock_bh(&pstapriv->asoc_list_lock); - phead = &pstapriv->asoc_list; - list_for_each_entry(psta, phead, asoc_list) { - issue_action_spct_ch_switch23a(padapter, psta->hwaddr, new_ch, ch_offset); - psta->expire_to = ((pstapriv->expire_to * 2) > 5) ? 5 : (pstapriv->expire_to * 2); - } - spin_unlock_bh(&pstapriv->asoc_list_lock); - - issue_action_spct_ch_switch23a(padapter, bc_addr, new_ch, ch_offset); - - return 0; -} - int rtw_sta_flush23a(struct rtw_adapter *padapter) { struct list_head *phead; diff --git a/drivers/staging/rtl8723au/include/rtw_ap.h b/drivers/staging/rtl8723au/include/rtw_ap.h index 9f8d235..55a708f 100644 --- a/drivers/staging/rtl8723au/include/rtw_ap.h +++ b/drivers/staging/rtl8723au/include/rtw_ap.h @@ -36,8 +36,6 @@ int rtw_check_beacon_data23a(struct rtw_adapter *padapter, struct ieee80211_mgmt *mgmt, unsigned int len); void rtw_ap_restore_network(struct rtw_adapter *padapter); void rtw_set_macaddr_acl23a(struct rtw_adapter *padapter, int mode); -int rtw_acl_add_sta23a(struct rtw_adapter *padapter, u8 *addr); -int rtw_acl_remove_sta23a(struct rtw_adapter *padapter, u8 *addr); void associated_clients_update23a(struct rtw_adapter *padapter, u8 updated); void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info *psta); @@ -46,7 +44,6 @@ void sta_info_update23a(struct rtw_adapter *padapter, struct sta_info *psta); void ap_sta_info_defer_update23a(struct rtw_adapter *padapter, struct sta_info *psta); u8 ap_free_sta23a(struct rtw_adapter *padapter, struct sta_info *psta, bool active, u16 reason); int rtw_sta_flush23a(struct rtw_adapter *padapter); -int rtw_ap_inform_ch_switch23a(struct rtw_adapter *padapter, u8 new_ch, u8 ch_offset); void start_ap_mode23a(struct rtw_adapter *padapter); void stop_ap_mode23a(struct rtw_adapter *padapter); #endif /* end of CONFIG_8723AU_AP_MODE */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] taging: rtl8723au: Remove empty function odm_Init_RSSIForDM23a 2016-03-11 6:58 [PATCH 0/3] Staging: Remove unused functions and prototypes Bhumika Goyal 2016-03-11 6:58 ` [PATCH 1/3] Staging: sm750fb: Remove unused functions Bhumika Goyal 2016-03-11 6:58 ` [PATCH 2/3] Staging: rtl8723au: Remove unused functions and prototype Bhumika Goyal @ 2016-03-11 6:58 ` Bhumika Goyal 2 siblings, 0 replies; 4+ messages in thread From: Bhumika Goyal @ 2016-03-11 6:58 UTC (permalink / raw) To: outreachy-kernel; +Cc: Bhumika Goyal The function odm_Init_RSSIForDM23a is empty and therefore there is no use of keeping it. Also, remove its prototype. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 4 ---- drivers/staging/rtl8723au/include/odm_HWConfig.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging/rtl8723au/hal/odm_HWConfig.c index 7b9799e..0562f61 100644 --- a/drivers/staging/rtl8723au/hal/odm_HWConfig.c +++ b/drivers/staging/rtl8723au/hal/odm_HWConfig.c @@ -270,10 +270,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct dm_odm_t *pDM_Odm, } } -void odm_Init_RSSIForDM23a(struct dm_odm_t *pDM_Odm) -{ -} - static void odm_Process_RSSIForDM(struct dm_odm_t *pDM_Odm, struct phy_info *pPhyInfo, struct odm_packet_info *pPktinfo) diff --git a/drivers/staging/rtl8723au/include/odm_HWConfig.h b/drivers/staging/rtl8723au/include/odm_HWConfig.h index ce7abe7..c748d5f 100644 --- a/drivers/staging/rtl8723au/include/odm_HWConfig.h +++ b/drivers/staging/rtl8723au/include/odm_HWConfig.h @@ -142,8 +142,6 @@ struct phy_status_rpt_8195 { }; -void odm_Init_RSSIForDM23a(struct dm_odm_t *pDM_Odm); - void ODM_PhyStatusQuery23a( struct dm_odm_t *pDM_Odm, -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-11 6:59 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-11 6:58 [PATCH 0/3] Staging: Remove unused functions and prototypes Bhumika Goyal 2016-03-11 6:58 ` [PATCH 1/3] Staging: sm750fb: Remove unused functions Bhumika Goyal 2016-03-11 6:58 ` [PATCH 2/3] Staging: rtl8723au: Remove unused functions and prototype Bhumika Goyal 2016-03-11 6:58 ` [PATCH 3/3] taging: rtl8723au: Remove empty function odm_Init_RSSIForDM23a Bhumika Goyal
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.