* [PATCH 0/2] Fix multiple warnings
@ 2016-03-13 11:34 Anchal Jain
2016-03-13 11:35 ` [PATCH 1/2] staging: wilc1000: Remove camel case in variable names Anchal Jain
2016-03-13 11:37 ` [PATCH 2/2] staging: drivers: Fix lines over 80 characters Anchal Jain
0 siblings, 2 replies; 5+ messages in thread
From: Anchal Jain @ 2016-03-13 11:34 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
This patchset updates the wilc1000 driver in order to fix several checkpatch issues detected in the source code.
Anchal Jain (2):
staging: wilc1000: Remove camel case in variable names.
staging: drivers: Fix lines over 80 characters
drivers/staging/wilc1000/linux_mon.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] staging: wilc1000: Remove camel case in variable names.
2016-03-13 11:34 [PATCH 0/2] Fix multiple warnings Anchal Jain
@ 2016-03-13 11:35 ` Anchal Jain
2016-03-13 11:37 ` [PATCH 2/2] staging: drivers: Fix lines over 80 characters Anchal Jain
1 sibling, 0 replies; 5+ messages in thread
From: Anchal Jain @ 2016-03-13 11:35 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
Remove a check detect by checkpatch.pl
CHECK: Avoid CamelCase: <srcAdd>
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
drivers/staging/wilc1000/linux_mon.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index 7d9e5de..fd25116 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -24,7 +24,7 @@ struct wilc_wfi_radiotap_cb_hdr {
static struct net_device *wilc_wfi_mon; /* global monitor netdev */
-static u8 srcAdd[6];
+static u8 srcadd[6];
static u8 bssid[6];
static u8 broadcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
/**
@@ -225,11 +225,11 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
skb->dev = mon_priv->real_ndev;
/* Identify if Ethernet or MAC header (data or mgmt) */
- memcpy(srcAdd, &skb->data[10], 6);
+ memcpy(srcadd, &skb->data[10], 6);
memcpy(bssid, &skb->data[16], 6);
/* if source address and bssid fields are equal>>Mac header */
/*send it to mgmt frames handler */
- if (!(memcmp(srcAdd, bssid, 6))) {
+ if (!(memcmp(srcadd, bssid, 6))) {
ret = mon_mgmt_tx(mon_priv->real_ndev, skb->data, skb->len);
if (ret)
netdev_err(dev, "fail to mgmt tx\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] staging: drivers: Fix lines over 80 characters
2016-03-13 11:34 [PATCH 0/2] Fix multiple warnings Anchal Jain
2016-03-13 11:35 ` [PATCH 1/2] staging: wilc1000: Remove camel case in variable names Anchal Jain
@ 2016-03-13 11:37 ` Anchal Jain
2016-03-13 11:46 ` [Outreachy kernel] " Julia Lawall
2016-03-21 21:30 ` Greg KH
1 sibling, 2 replies; 5+ messages in thread
From: Anchal Jain @ 2016-03-13 11:37 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
Break lines so that they do not exceed 80
characters. Problem found using checkpatch.
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
drivers/staging/wilc1000/linux_mon.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index fd25116..0d79a61 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -59,9 +59,10 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
/* Get WILC header */
memcpy(&header, (buff - HOST_HDR_OFFSET), HOST_HDR_OFFSET);
-
- /* The packet offset field conain info about what type of managment frame */
- /* we are dealing with and ack status */
+ /*
+ * The packet offset field contains info about what type of management
+ * the frame we are dealing with and ack status
+ */
pkt_offset = GET_PKT_OFFSET(header);
if (pkt_offset & IS_MANAGMEMENT_CALLBACK) {
@@ -105,7 +106,7 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
hdr->hdr.it_len = cpu_to_le16(sizeof(struct wilc_wfi_radiotap_hdr));
hdr->hdr.it_present = cpu_to_le32
- (1 << IEEE80211_RADIOTAP_RATE); /* | */
+ (1 << IEEE80211_RADIOTAP_RATE); /* | */
hdr->rate = 5; /* txrate->bitrate / 5; */
}
@@ -127,8 +128,10 @@ struct tx_complete_mon_data {
static void mgmt_tx_complete(void *priv, int status)
{
struct tx_complete_mon_data *pv_data = priv;
-
- /* incase of fully hosting mode, the freeing will be done in response to the cfg packet */
+ /*
+ * in case of fully hosting mode, the freeing will be done
+ * in response to the cfg packet
+ */
kfree(pv_data->buff);
kfree(pv_data);
@@ -255,7 +258,8 @@ static const struct net_device_ops wilc_wfi_netdev_ops = {
* @date 12 JUL 2012
* @version 1.0
*/
-struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_device *real_dev)
+struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_device
+ *real_dev)
{
u32 ret = 0;
struct WILC_WFI_mon_priv *priv;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] staging: drivers: Fix lines over 80 characters
2016-03-13 11:37 ` [PATCH 2/2] staging: drivers: Fix lines over 80 characters Anchal Jain
@ 2016-03-13 11:46 ` Julia Lawall
2016-03-21 21:30 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2016-03-13 11:46 UTC (permalink / raw)
To: Anchal Jain; +Cc: outreachy-kernel
On Sun, 13 Mar 2016, Anchal Jain wrote:
> Break lines so that they do not exceed 80
> characters. Problem found using checkpatch.
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> drivers/staging/wilc1000/linux_mon.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
> index fd25116..0d79a61 100644
> --- a/drivers/staging/wilc1000/linux_mon.c
> +++ b/drivers/staging/wilc1000/linux_mon.c
> @@ -59,9 +59,10 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
>
> /* Get WILC header */
> memcpy(&header, (buff - HOST_HDR_OFFSET), HOST_HDR_OFFSET);
> -
> - /* The packet offset field conain info about what type of managment frame */
> - /* we are dealing with and ack status */
> + /*
> + * The packet offset field contains info about what type of management
> + * the frame we are dealing with and ack status
> + */
> pkt_offset = GET_PKT_OFFSET(header);
>
> if (pkt_offset & IS_MANAGMEMENT_CALLBACK) {
> @@ -105,7 +106,7 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
> hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
> hdr->hdr.it_len = cpu_to_le16(sizeof(struct wilc_wfi_radiotap_hdr));
> hdr->hdr.it_present = cpu_to_le32
> - (1 << IEEE80211_RADIOTAP_RATE); /* | */
> + (1 << IEEE80211_RADIOTAP_RATE); /* | */
> hdr->rate = 5; /* txrate->bitrate / 5; */
> }
>
> @@ -127,8 +128,10 @@ struct tx_complete_mon_data {
> static void mgmt_tx_complete(void *priv, int status)
> {
> struct tx_complete_mon_data *pv_data = priv;
> -
> - /* incase of fully hosting mode, the freeing will be done in response to the cfg packet */
> + /*
> + * in case of fully hosting mode, the freeing will be done
> + * in response to the cfg packet
> + */
> kfree(pv_data->buff);
>
> kfree(pv_data);
> @@ -255,7 +258,8 @@ static const struct net_device_ops wilc_wfi_netdev_ops = {
> * @date 12 JUL 2012
> * @version 1.0
> */
> -struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_device *real_dev)
> +struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_device
> + *real_dev)
The lines here are still over 80 characters. checkpatch should have
complained.
julia
> {
> u32 ret = 0;
> struct WILC_WFI_mon_priv *priv;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/55e6d749e6540164f7e206c1eb7ddc17b30fa292.1457868804.git.anchalj109%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] staging: drivers: Fix lines over 80 characters
2016-03-13 11:37 ` [PATCH 2/2] staging: drivers: Fix lines over 80 characters Anchal Jain
2016-03-13 11:46 ` [Outreachy kernel] " Julia Lawall
@ 2016-03-21 21:30 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-03-21 21:30 UTC (permalink / raw)
To: Anchal Jain; +Cc: outreachy-kernel
On Sun, Mar 13, 2016 at 05:07:50PM +0530, Anchal Jain wrote:
> Break lines so that they do not exceed 80
> characters. Problem found using checkpatch.
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
You need to say which driver you are changing in your subject :(
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-21 21:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-13 11:34 [PATCH 0/2] Fix multiple warnings Anchal Jain
2016-03-13 11:35 ` [PATCH 1/2] staging: wilc1000: Remove camel case in variable names Anchal Jain
2016-03-13 11:37 ` [PATCH 2/2] staging: drivers: Fix lines over 80 characters Anchal Jain
2016-03-13 11:46 ` [Outreachy kernel] " Julia Lawall
2016-03-21 21:30 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.