[PATCH 0/4] Staging: i4l: Fix coding style issues.

[PATCH 0/4] Staging: i4l: Fix coding style issues.

[Sandhya Bankar]

Fix coding style issues.This issue is found by checkpatch.pl.

Sandhya Bankar (4):
  Staging: i4l: Add paranthesis to complex macro.
  Staging: i4l: Use !x instead of x == NULL
  Staging: i4l: Do not initialise statics to 0.
  Staging: i4l: layer2: Add paranthesis to complex macro.

 drivers/staging/i4l/pcbit/capi.h   | 2 +-
 drivers/staging/i4l/pcbit/drv.c    | 4 ++--
 drivers/staging/i4l/pcbit/edss1.c  | 2 +-
 drivers/staging/i4l/pcbit/layer2.h | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

-- 
1.8.3.4

[PATCH 1/4] Staging: i4l: Add paranthesis to complex macro.

[Sandhya Bankar]

Add paranthesis to complex macro.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/i4l/pcbit/layer2.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i4l/pcbit/layer2.h b/drivers/staging/i4l/pcbit/layer2.h
index be1327b..6b9063e 100644
--- a/drivers/staging/i4l/pcbit/layer2.h
+++ b/drivers/staging/i4l/pcbit/layer2.h
@@ -109,7 +109,7 @@
 #define SCHED_READ    0x01
 #define SCHED_WRITE   0x02
 
-#define SET_RUN_TIMEOUT 2 * HZ /* 2 seconds */
+#define SET_RUN_TIMEOUT (2 * HZ) /* 2 seconds */
 
 struct frame_buf {
 	ulong msg;
-- 
1.8.3.4

Re: [Outreachy kernel] [PATCH 1/4] Staging: i4l: Add paranthesis to complex macro.

[Julia Lawall]

On Thu, 17 Mar 2016, Sandhya Bankar wrote:

> Add paranthesis to complex macro.

From the subject line, it looks like you are performing this change on all
of i4l, but in another patch the subject line mentions the same kind of
change, but ona subdirectory.  Also, paranthesis -> parentheses.

julia

>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/i4l/pcbit/layer2.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/i4l/pcbit/layer2.h b/drivers/staging/i4l/pcbit/layer2.h
> index be1327b..6b9063e 100644
> --- a/drivers/staging/i4l/pcbit/layer2.h
> +++ b/drivers/staging/i4l/pcbit/layer2.h
> @@ -109,7 +109,7 @@
>  #define SCHED_READ    0x01
>  #define SCHED_WRITE   0x02
>
> -#define SET_RUN_TIMEOUT 2 * HZ /* 2 seconds */
> +#define SET_RUN_TIMEOUT (2 * HZ) /* 2 seconds */
>
>  struct frame_buf {
>  	ulong msg;
> --
> 1.8.3.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/8ea64620333b0c695ab3e67bbfd2949d2a071f2e.1458213062.git.bankarsandhya512%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

[PATCH 2/4] Staging: i4l: Use !x instead of x == NULL.

[Sandhya Bankar]

Use !x instead of x == NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/i4l/pcbit/edss1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i4l/pcbit/edss1.c b/drivers/staging/i4l/pcbit/edss1.c
index b2262ba..e72c164 100644
--- a/drivers/staging/i4l/pcbit/edss1.c
+++ b/drivers/staging/i4l/pcbit/edss1.c
@@ -254,7 +254,7 @@ static void pcbit_fsm_timer(unsigned long data)
 
 	dev = chan2dev(chan);
 
-	if (dev == NULL) {
+	if (!dev) {
 		printk(KERN_WARNING "pcbit: timer for unknown device\n");
 		return;
 	}
-- 
1.8.3.4

[PATCH 3/4] Staging: i4l: Do not initialise statics to 0.

[Sandhya Bankar]

 Do not initialise statics to 0.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/i4l/pcbit/drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/i4l/pcbit/drv.c b/drivers/staging/i4l/pcbit/drv.c
index 2087a52..c1b6f88 100644
--- a/drivers/staging/i4l/pcbit/drv.c
+++ b/drivers/staging/i4l/pcbit/drv.c
@@ -699,8 +699,8 @@ void pcbit_l3_receive(struct pcbit_dev *dev, ulong msg,
  */
 
 static char statbuf[STATBUF_LEN];
-static int stat_st = 0;
-static int stat_end = 0;
+static int stat_st;
+static int stat_end;
 
 static int pcbit_stat(u_char __user *buf, int len, int driver, int channel)
 {
-- 
1.8.3.4

[PATCH 4/4] Staging: i4l: capi: Add paranthesis to complex macro.

[Sandhya Bankar]

Add paranthesis to complex macro.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/i4l/pcbit/capi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i4l/pcbit/capi.h b/drivers/staging/i4l/pcbit/capi.h
index 635f634..6f6f4dd 100644
--- a/drivers/staging/i4l/pcbit/capi.h
+++ b/drivers/staging/i4l/pcbit/capi.h
@@ -17,7 +17,7 @@
 #define REQ_DISPLAY       0x04
 #define REQ_USER_TO_USER  0x08
 
-#define AppInfoMask  REQ_CAUSE | REQ_DISPLAY | REQ_USER_TO_USER
+#define AppInfoMask  (REQ_CAUSE | REQ_DISPLAY | REQ_USER_TO_USER)
 
 /* Connection Setup */
 extern int capi_conn_req(const char *calledPN, struct sk_buff **buf,
-- 
1.8.3.4