[PATCH 1/4] Staging: rtl8188eu: Hal8188ERateAdaptive: Remove NULL comparison.

[PATCH 1/4] Staging: rtl8188eu: Hal8188ERateAdaptive: Remove NULL comparison.

[Sandhya Bankar]

Remove NULL comparison.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
index a108e80..201c15b 100644
--- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
+++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
@@ -557,7 +557,7 @@ int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
 	u8 WirelessMode = 0xFF; /* invalid value */
 	u8 max_rate_idx = 0x13; /* MCS7 */
 
-	if (dm_odm->pWirelessMode != NULL)
+	if (dm_odm->pWirelessMode)
 		WirelessMode = *(dm_odm->pWirelessMode);
 
 	if (WirelessMode != 0xFF) {
-- 
1.8.3.4

[PATCH 2/4] Staging: rtl8188eu: hal_intf: Remove NULL comparision.

[Sandhya Bankar]

Remove NULL comparision.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c
index 85c17ef..fb7bacb 100644
--- a/drivers/staging/rtl8188eu/hal/hal_intf.c
+++ b/drivers/staging/rtl8188eu/hal/hal_intf.c
@@ -186,7 +186,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *adapt, struct xmit_frame *pmgntframe)
 
 s32 rtw_hal_init_xmit_priv(struct adapter *adapt)
 {
-	if (adapt->HalFunc.init_xmit_priv != NULL)
+	if (adapt->HalFunc.init_xmit_priv)
 		return adapt->HalFunc.init_xmit_priv(adapt);
 	return _FAIL;
 }
-- 
1.8.3.4

[PATCH 3/4] Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL.

[Sandhya Bankar]

Use !x instead of x == NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index 53cf3ba..c7e48f1 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -45,7 +45,7 @@ static void process_link_qual(struct adapter *padapter,
 	struct rx_pkt_attrib *pattrib;
 	struct signal_stat *signal_stat;
 
-	if (prframe == NULL || padapter == NULL)
+	if (!prframe || !padapter)
 		return;
 
 	pattrib = &prframe->attrib;
-- 
1.8.3.4

[PATCH 4/4] Staging: rtl8188eu: usb_halinit: Use !x instead of x == NULL.

[Sandhya Bankar]

Use !x instead of x == NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 07a61b8..e25c38b 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -2083,7 +2083,7 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
 
 
 	adapt->HalData = kzalloc(sizeof(struct hal_data_8188e), GFP_KERNEL);
-	if (adapt->HalData == NULL)
+	if (!adapt->HalData)
 		DBG_88E("cant not alloc memory for HAL DATA\n");
 
 	halfunc->hal_power_on = rtl8188eu_InitPowerOn;
-- 
1.8.3.4

[PATCH v2 0/4] Staging: rtl8188eu: Remove NULL comparision.

[Sandhya Bankar]

Remove NULL comparision.This patch is found by checkpatch.pl script.
Changes in v2:
*Correcting the heading.

Sandhya Bankar (4):
  Staging: rtl8188eu: Remove NULL comparision.
  Staging: rtl8188eu: Remove NULL comparision.
  Staging: rtl8188eu: Use !x instead of x == NULL.
  Staging: rtl8188eu: Use !x instead of x == NULL.

 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
 drivers/staging/rtl8188eu/hal/hal_intf.c             | 2 +-
 drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c      | 2 +-
 drivers/staging/rtl8188eu/hal/usb_halinit.c          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.3.4

Re: [Outreachy kernel] [PATCH v2 2/4] Staging: rtl8188eu: Use !x instead of x == NULL.

[Julia Lawall]

On Sat, 19 Mar 2016, Sandhya Bankar wrote:

> Use !x instead of x == NULL.

There is a != test here.

julia

> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> Changes in v2:
> *Correcting the heading.
> 
>  drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c
> index 85c17ef..fb7bacb 100644
> --- a/drivers/staging/rtl8188eu/hal/hal_intf.c
> +++ b/drivers/staging/rtl8188eu/hal/hal_intf.c
> @@ -186,7 +186,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *adapt, struct xmit_frame *pmgntframe)
>  
>  s32 rtw_hal_init_xmit_priv(struct adapter *adapt)
>  {
> -	if (adapt->HalFunc.init_xmit_priv != NULL)
> +	if (adapt->HalFunc.init_xmit_priv)
>  		return adapt->HalFunc.init_xmit_priv(adapt);
>  	return _FAIL;
>  }
> -- 
> 1.8.3.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/08dbf910fd604fdfd258b82d2ca8e53621f9c6f8.1458376695.git.bankarsandhya512%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v2 0/4] Staging: rtl8188eu: Remove NULL comparision.

[Julia Lawall]

On Sat, 19 Mar 2016, Sandhya Bankar wrote:

> Remove NULL comparision.This patch is found by checkpatch.pl script.
> Changes in v2:
> *Correcting the heading.
> 
> Sandhya Bankar (4):
>   Staging: rtl8188eu: Remove NULL comparision.
>   Staging: rtl8188eu: Remove NULL comparision.
>   Staging: rtl8188eu: Use !x instead of x == NULL.
>   Staging: rtl8188eu: Use !x instead of x == NULL.

Theer are repeated subject lines here, which is going to cause problems.  
You could use the file name, without the .c, to differentiate between 
them.

julia

> 
>  drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
>  drivers/staging/rtl8188eu/hal/hal_intf.c             | 2 +-
>  drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c      | 2 +-
>  drivers/staging/rtl8188eu/hal/usb_halinit.c          | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 1.8.3.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1458376695.git.bankarsandhya512%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>