* [PATCH v2 0/4] Staging: i4l: Fix coding style issues.
@ 2016-03-20 11:14 Sandhya Bankar
2016-03-20 11:17 ` [PATCH v2 1/4] Staging: i4l: pcbit: layer2: Add parentheses to complex macro Sandhya Bankar
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 11:14 UTC (permalink / raw)
To: outreachy-kernel
Fix coding style issues.
Changes in v2:
* Correcting the heading.
* Resending v2 as previously it is not showing in mailing list.
Sandhya Bankar (4):
Staging: i4l: pcbit: capi: Add parentheses to complex macro.
Staging: i4l: pcbit: drv: Use !x instead of x == NULL
Staging: i4l: pcbit: edss1: Do not initialise statics to 0.
Staging: i4l: pcbit: layer2: Add parentheses to complex macro.
drivers/staging/i4l/pcbit/capi.h | 2 +-
drivers/staging/i4l/pcbit/drv.c | 4 ++--
drivers/staging/i4l/pcbit/edss1.c | 2 +-
drivers/staging/i4l/pcbit/layer2.h | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
--
1.8.3.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/4] Staging: i4l: pcbit: layer2: Add parentheses to complex macro.
2016-03-20 11:14 [PATCH v2 0/4] Staging: i4l: Fix coding style issues Sandhya Bankar
@ 2016-03-20 11:17 ` Sandhya Bankar
2016-03-20 11:19 ` [PATCH v2 2/4] Staging: i4l: pcbit: edss1: Use !x instead of x == NULL Sandhya Bankar
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 11:17 UTC (permalink / raw)
To: outreachy-kernel
Add parentheses to complex macro.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/i4l/pcbit/layer2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i4l/pcbit/layer2.h b/drivers/staging/i4l/pcbit/layer2.h
index be1327b..6b9063e 100644
--- a/drivers/staging/i4l/pcbit/layer2.h
+++ b/drivers/staging/i4l/pcbit/layer2.h
@@ -109,7 +109,7 @@
#define SCHED_READ 0x01
#define SCHED_WRITE 0x02
-#define SET_RUN_TIMEOUT 2 * HZ /* 2 seconds */
+#define SET_RUN_TIMEOUT (2 * HZ) /* 2 seconds */
struct frame_buf {
ulong msg;
--
1.8.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/4] Staging: i4l: pcbit: edss1: Use !x instead of x == NULL.
2016-03-20 11:14 [PATCH v2 0/4] Staging: i4l: Fix coding style issues Sandhya Bankar
2016-03-20 11:17 ` [PATCH v2 1/4] Staging: i4l: pcbit: layer2: Add parentheses to complex macro Sandhya Bankar
@ 2016-03-20 11:19 ` Sandhya Bankar
2016-03-20 11:20 ` [PATCH v2 3/4] Staging: i4l: pcbit: drv: Do not initialise statics to 0 Sandhya Bankar
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 11:19 UTC (permalink / raw)
To: outreachy-kernel
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/i4l/pcbit/edss1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i4l/pcbit/edss1.c b/drivers/staging/i4l/pcbit/edss1.c
index b2262ba..e72c164 100644
--- a/drivers/staging/i4l/pcbit/edss1.c
+++ b/drivers/staging/i4l/pcbit/edss1.c
@@ -254,7 +254,7 @@ static void pcbit_fsm_timer(unsigned long data)
dev = chan2dev(chan);
- if (dev == NULL) {
+ if (!dev) {
printk(KERN_WARNING "pcbit: timer for unknown device\n");
return;
}
--
1.8.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/4] Staging: i4l: pcbit: drv: Do not initialise statics to 0.
2016-03-20 11:14 [PATCH v2 0/4] Staging: i4l: Fix coding style issues Sandhya Bankar
2016-03-20 11:17 ` [PATCH v2 1/4] Staging: i4l: pcbit: layer2: Add parentheses to complex macro Sandhya Bankar
2016-03-20 11:19 ` [PATCH v2 2/4] Staging: i4l: pcbit: edss1: Use !x instead of x == NULL Sandhya Bankar
@ 2016-03-20 11:20 ` Sandhya Bankar
2016-03-20 11:22 ` [PATCH v2 4/4] Staging: i4l: pcbit: capi: Add parentheses to complex macro Sandhya Bankar
2016-03-20 18:16 ` [Outreachy kernel] [PATCH v2 0/4] Staging: i4l: Fix coding style issues Julia Lawall
4 siblings, 0 replies; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 11:20 UTC (permalink / raw)
To: outreachy-kernel
Do not initialise statics to 0.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/i4l/pcbit/drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/i4l/pcbit/drv.c b/drivers/staging/i4l/pcbit/drv.c
index 2087a52..c1b6f88 100644
--- a/drivers/staging/i4l/pcbit/drv.c
+++ b/drivers/staging/i4l/pcbit/drv.c
@@ -699,8 +699,8 @@ void pcbit_l3_receive(struct pcbit_dev *dev, ulong msg,
*/
static char statbuf[STATBUF_LEN];
-static int stat_st = 0;
-static int stat_end = 0;
+static int stat_st;
+static int stat_end;
static int pcbit_stat(u_char __user *buf, int len, int driver, int channel)
{
--
1.8.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 4/4] Staging: i4l: pcbit: capi: Add parentheses to complex macro.
2016-03-20 11:14 [PATCH v2 0/4] Staging: i4l: Fix coding style issues Sandhya Bankar
` (2 preceding siblings ...)
2016-03-20 11:20 ` [PATCH v2 3/4] Staging: i4l: pcbit: drv: Do not initialise statics to 0 Sandhya Bankar
@ 2016-03-20 11:22 ` Sandhya Bankar
2016-03-20 18:16 ` [Outreachy kernel] [PATCH v2 0/4] Staging: i4l: Fix coding style issues Julia Lawall
4 siblings, 0 replies; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 11:22 UTC (permalink / raw)
To: outreachy-kernel
Add parentheses to complex macro.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/i4l/pcbit/capi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i4l/pcbit/capi.h b/drivers/staging/i4l/pcbit/capi.h
index 635f634..6f6f4dd 100644
--- a/drivers/staging/i4l/pcbit/capi.h
+++ b/drivers/staging/i4l/pcbit/capi.h
@@ -17,7 +17,7 @@
#define REQ_DISPLAY 0x04
#define REQ_USER_TO_USER 0x08
-#define AppInfoMask REQ_CAUSE | REQ_DISPLAY | REQ_USER_TO_USER
+#define AppInfoMask (REQ_CAUSE | REQ_DISPLAY | REQ_USER_TO_USER)
/* Connection Setup */
extern int capi_conn_req(const char *calledPN, struct sk_buff **buf,
--
1.8.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 0/4] Staging: i4l: Fix coding style issues.
2016-03-20 11:14 [PATCH v2 0/4] Staging: i4l: Fix coding style issues Sandhya Bankar
` (3 preceding siblings ...)
2016-03-20 11:22 ` [PATCH v2 4/4] Staging: i4l: pcbit: capi: Add parentheses to complex macro Sandhya Bankar
@ 2016-03-20 18:16 ` Julia Lawall
4 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-03-20 18:16 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
Actually, when you resend something, you should put RESEND after PATCH in
the subject line.
julia
On Sun, 20 Mar 2016, Sandhya Bankar wrote:
> Fix coding style issues.
> Changes in v2:
> * Correcting the heading.
> * Resending v2 as previously it is not showing in mailing list.
>
> Sandhya Bankar (4):
> Staging: i4l: pcbit: capi: Add parentheses to complex macro.
> Staging: i4l: pcbit: drv: Use !x instead of x == NULL
> Staging: i4l: pcbit: edss1: Do not initialise statics to 0.
> Staging: i4l: pcbit: layer2: Add parentheses to complex macro.
>
> drivers/staging/i4l/pcbit/capi.h | 2 +-
> drivers/staging/i4l/pcbit/drv.c | 4 ++--
> drivers/staging/i4l/pcbit/edss1.c | 2 +-
> drivers/staging/i4l/pcbit/layer2.h | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> --
> 1.8.3.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1458471223.git.bankarsandhya512%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-20 18:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-20 11:14 [PATCH v2 0/4] Staging: i4l: Fix coding style issues Sandhya Bankar
2016-03-20 11:17 ` [PATCH v2 1/4] Staging: i4l: pcbit: layer2: Add parentheses to complex macro Sandhya Bankar
2016-03-20 11:19 ` [PATCH v2 2/4] Staging: i4l: pcbit: edss1: Use !x instead of x == NULL Sandhya Bankar
2016-03-20 11:20 ` [PATCH v2 3/4] Staging: i4l: pcbit: drv: Do not initialise statics to 0 Sandhya Bankar
2016-03-20 11:22 ` [PATCH v2 4/4] Staging: i4l: pcbit: capi: Add parentheses to complex macro Sandhya Bankar
2016-03-20 18:16 ` [Outreachy kernel] [PATCH v2 0/4] Staging: i4l: Fix coding style issues Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.