* [PATCH 1/3] Staging: rtl8188eu: rtw_efuse: Use sizeof type *pointer instead of sizeof type.
2016-03-20 14:19 [PATCH 0/3] Staging: Use sizeof type *pointer instead of sizeof type Sandhya Bankar
@ 2016-03-20 14:21 ` Sandhya Bankar
2016-03-20 14:23 ` [PATCH 2/3] Staging: lustre: rpc: " Sandhya Bankar
2016-03-20 14:25 ` [PATCH 3/3] Staging: lustre: o2iblnd: " Sandhya Bankar
2 siblings, 0 replies; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 14:21 UTC (permalink / raw)
To: outreachy-kernel
Use sizeof type *pointer instead of sizeof type.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c
index 19f11d0..cd64045 100644
--- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
+++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
@@ -107,7 +107,7 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8 *pbuf)
if (!efuseTbl)
return;
- eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E, EFUSE_MAX_WORD_UNIT, sizeof(u16));
+ eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E, EFUSE_MAX_WORD_UNIT, sizeof(*eFuseWord));
if (!eFuseWord) {
DBG_88E("%s: alloc eFuseWord fail!\n", __func__);
goto eFuseWord_failed;
--
1.8.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] Staging: lustre: rpc: Use sizeof type *pointer instead of sizeof type.
2016-03-20 14:19 [PATCH 0/3] Staging: Use sizeof type *pointer instead of sizeof type Sandhya Bankar
2016-03-20 14:21 ` [PATCH 1/3] Staging: rtl8188eu: rtw_efuse: " Sandhya Bankar
@ 2016-03-20 14:23 ` Sandhya Bankar
2016-03-21 19:27 ` [Outreachy kernel] " Greg KH
2016-03-20 14:25 ` [PATCH 3/3] Staging: lustre: o2iblnd: " Sandhya Bankar
2 siblings, 1 reply; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 14:23 UTC (permalink / raw)
To: outreachy-kernel
Use sizeof type *pointer instead of sizeof type.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/lustre/lnet/selftest/rpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c b/drivers/staging/lustre/lnet/selftest/rpc.c
index 69be7d6..563827c 100644
--- a/drivers/staging/lustre/lnet/selftest/rpc.c
+++ b/drivers/staging/lustre/lnet/selftest/rpc.c
@@ -256,7 +256,7 @@ srpc_service_init(struct srpc_service *svc)
svc->sv_shuttingdown = 0;
svc->sv_cpt_data = cfs_percpt_alloc(lnet_cpt_table(),
- sizeof(struct srpc_service_cd));
+ sizeof(*svc->sv_cpt_data));
if (!svc->sv_cpt_data)
return -ENOMEM;
--
1.8.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/3] Staging: lustre: rpc: Use sizeof type *pointer instead of sizeof type.
2016-03-20 14:23 ` [PATCH 2/3] Staging: lustre: rpc: " Sandhya Bankar
@ 2016-03-21 19:27 ` Greg KH
2016-03-21 19:45 ` sandhya bankar
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-03-21 19:27 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Sun, Mar 20, 2016 at 07:53:17PM +0530, Sandhya Bankar wrote:
> Use sizeof type *pointer instead of sizeof type.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/lustre/lnet/selftest/rpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You already sent this patch. Or you sent this again with changes, yet
did not provide a 'v2' marking and description of what changed.
I'm going to drop both series, please resend in a format that explains
what changed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/3] Staging: lustre: rpc: Use sizeof type *pointer instead of sizeof type.
2016-03-21 19:27 ` [Outreachy kernel] " Greg KH
@ 2016-03-21 19:45 ` sandhya bankar
0 siblings, 0 replies; 6+ messages in thread
From: sandhya bankar @ 2016-03-21 19:45 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
Hello,
Actually as per mentor suggestion i had made changes in commit massage.
So i have not send patch v2. I will send patch v2.
Thanks,
Sandhya
On Tue, Mar 22, 2016 at 12:57 AM, Greg KH <gregkh@linuxfoundation.org>
wrote:
> On Sun, Mar 20, 2016 at 07:53:17PM +0530, Sandhya Bankar wrote:
> > Use sizeof type *pointer instead of sizeof type.
> >
> > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> > ---
> > drivers/staging/lustre/lnet/selftest/rpc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> You already sent this patch. Or you sent this again with changes, yet
> did not provide a 'v2' marking and description of what changed.
>
> I'm going to drop both series, please resend in a format that explains
> what changed.
>
> thanks,
>
> greg k-h
>
[-- Attachment #2: Type: text/html, Size: 1425 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type.
2016-03-20 14:19 [PATCH 0/3] Staging: Use sizeof type *pointer instead of sizeof type Sandhya Bankar
2016-03-20 14:21 ` [PATCH 1/3] Staging: rtl8188eu: rtw_efuse: " Sandhya Bankar
2016-03-20 14:23 ` [PATCH 2/3] Staging: lustre: rpc: " Sandhya Bankar
@ 2016-03-20 14:25 ` Sandhya Bankar
2 siblings, 0 replies; 6+ messages in thread
From: Sandhya Bankar @ 2016-03-20 14:25 UTC (permalink / raw)
To: outreachy-kernel
Use sizeof type *pointer instead of sizeof type.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
index 0d32e65..89f9390 100644
--- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
+++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
@@ -1968,7 +1968,7 @@ static int kiblnd_net_init_pools(kib_net_t *net, __u32 *cpts, int ncpts)
*/
net->ibn_fmr_ps = cfs_percpt_alloc(lnet_cpt_table(),
- sizeof(kib_fmr_poolset_t));
+ sizeof(*net->ibn_fmr_ps));
if (!net->ibn_fmr_ps) {
CERROR("Failed to allocate FMR pool array\n");
rc = -ENOMEM;
@@ -1992,7 +1992,7 @@ static int kiblnd_net_init_pools(kib_net_t *net, __u32 *cpts, int ncpts)
create_tx_pool:
net->ibn_tx_ps = cfs_percpt_alloc(lnet_cpt_table(),
- sizeof(kib_tx_poolset_t));
+ sizeof(*net->ibn_tx_ps));
if (!net->ibn_tx_ps) {
CERROR("Failed to allocate tx pool array\n");
rc = -ENOMEM;
--
1.8.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread