All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xin Long <lucien.xin@gmail.com>
To: network dev <netdev@vger.kernel.org>, bridge@lists.linux-foundation.org
Cc: nikolay@cumulusnetworks.com, davem@davemloft.net
Subject: [Bridge] [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl
Date: Sat,  9 Apr 2016 00:03:27 +0800	[thread overview]
Message-ID: <cover.1460131308.git.lucien.xin@gmail.com> (raw)

This patchset is used to support sending rntl info to user in some places,
and ensure that whenever those attributes change internally or from sysfs,
that a netlink notification is sent out to listeners.

It also make some adjustment in bridge sysfs so that we can implement this
easily.

I've done some tests on this patchset, like:
[br_sysfs]
  1. change all the attribute values of br or brif:
  $ echo $value > /sys/class/net/br0/bridge/{*}
  $ echo $value > /sys/class/net/br0/brif/eth1/{*}

  2. meanwhile, on another terminal to observe the msg:
  $ bridge monitor

[br_ioctl]
  1. in bridge-utils package, do some changes in br_set, let brctl command
  use ioctl to set attribute:
         if ((ret = set_sysfs(path, value)) < 0) { -->
         if (1) {

  $ brctl set*

  2. meanwhile, on another terminal to observe the msg:
  $ bridge monitor

This test covers all the attributes that brctl and sysfs support to set.

Xin Long (6):
  bridge: simplify the flush_store by calling store_bridge_parm
  bridge: simplify the forward_delay_store by calling store_bridge_parm
  bridge: simplify the stp_state_store by calling store_bridge_parm
  bridge: a netlink notification should be sent when those attributes
    are changed by br_sysfs_br
  bridge: a netlink notification should be sent when those attributes
    are changed by br_sysfs_if
  bridge: a netlink notification should be sent when those attributes
    are changed by ioctl

 net/bridge/br_ioctl.c    | 40 ++++++++++++++---------
 net/bridge/br_sysfs_br.c | 84 ++++++++++++++++++++----------------------------
 net/bridge/br_sysfs_if.c |  5 +--
 net/bridge/br_vlan.c     | 30 +++--------------
 4 files changed, 66 insertions(+), 93 deletions(-)

-- 
2.1.0


WARNING: multiple messages have this Message-ID (diff)
From: Xin Long <lucien.xin@gmail.com>
To: network dev <netdev@vger.kernel.org>, bridge@lists.linux-foundation.org
Cc: nikolay@cumulusnetworks.com, davem@davemloft.net
Subject: [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl
Date: Sat,  9 Apr 2016 00:03:27 +0800	[thread overview]
Message-ID: <cover.1460131308.git.lucien.xin@gmail.com> (raw)

This patchset is used to support sending rntl info to user in some places,
and ensure that whenever those attributes change internally or from sysfs,
that a netlink notification is sent out to listeners.

It also make some adjustment in bridge sysfs so that we can implement this
easily.

I've done some tests on this patchset, like:
[br_sysfs]
  1. change all the attribute values of br or brif:
  $ echo $value > /sys/class/net/br0/bridge/{*}
  $ echo $value > /sys/class/net/br0/brif/eth1/{*}

  2. meanwhile, on another terminal to observe the msg:
  $ bridge monitor

[br_ioctl]
  1. in bridge-utils package, do some changes in br_set, let brctl command
  use ioctl to set attribute:
         if ((ret = set_sysfs(path, value)) < 0) { -->
         if (1) {

  $ brctl set*

  2. meanwhile, on another terminal to observe the msg:
  $ bridge monitor

This test covers all the attributes that brctl and sysfs support to set.

Xin Long (6):
  bridge: simplify the flush_store by calling store_bridge_parm
  bridge: simplify the forward_delay_store by calling store_bridge_parm
  bridge: simplify the stp_state_store by calling store_bridge_parm
  bridge: a netlink notification should be sent when those attributes
    are changed by br_sysfs_br
  bridge: a netlink notification should be sent when those attributes
    are changed by br_sysfs_if
  bridge: a netlink notification should be sent when those attributes
    are changed by ioctl

 net/bridge/br_ioctl.c    | 40 ++++++++++++++---------
 net/bridge/br_sysfs_br.c | 84 ++++++++++++++++++++----------------------------
 net/bridge/br_sysfs_if.c |  5 +--
 net/bridge/br_vlan.c     | 30 +++--------------
 4 files changed, 66 insertions(+), 93 deletions(-)

-- 
2.1.0

             reply	other threads:[~2016-04-08 16:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 16:03 Xin Long [this message]
2016-04-08 16:03 ` [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Xin Long
2016-04-08 16:03 ` [Bridge] [PATCHv3 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm Xin Long
2016-04-08 16:03   ` Xin Long
2016-04-09 12:27   ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:27     ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [Bridge] [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store " Xin Long
2016-04-08 16:03   ` Xin Long
2016-04-09 12:31   ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:31     ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [Bridge] [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store " Xin Long
2016-04-08 16:03   ` Xin Long
2016-04-09 12:33   ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:33     ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [Bridge] [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Xin Long
2016-04-08 16:03   ` Xin Long
2016-04-09 12:41   ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:41     ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [Bridge] [PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Xin Long
2016-04-08 16:03   ` Xin Long
2016-04-09 12:45   ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:45     ` Nikolay Aleksandrov via Bridge
2016-04-08 16:03 ` [Bridge] [PATCHv3 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl Xin Long
2016-04-08 16:03   ` Xin Long
2016-04-09 12:49   ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:49     ` Nikolay Aleksandrov via Bridge
2016-04-09 12:55 ` [Bridge] [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Nikolay Aleksandrov
2016-04-09 12:55   ` Nikolay Aleksandrov via Bridge
2016-04-14  2:42 ` [Bridge] " David Miller
2016-04-14  2:42   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1460131308.git.lucien.xin@gmail.com \
    --to=lucien.xin@gmail.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.