All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elliot Smith <elliot.smith@intel.com>
To: toaster@yoctoproject.org
Subject: [PATCH 0/4] Validate custom image names correctly
Date: Mon, 11 Apr 2016 12:27:23 +0100	[thread overview]
Message-ID: <cover.1460373321.git.elliot.smith@intel.com> (raw)

We currently validate the name of a new custom image across all projects.
This means you can't use the same custom image name in multiple projects.

Modify the code to do validation correctly, and add UI tests to verify.

To test:

1. Create a project.
2. Create a custom image with name 'goo' in this project; it should work.
3. Try to create another custom image called 'goo' in this project; it should fail.
4. Try to create a custom image called 'core-image-minimal' in this project; it should fail.
5. Create another project.
6. Create a custom image called 'goo' in the second project; it should work.

The following changes since commit 4bb6fb30b0d660eaeaf4af134b99b2feaf0b3db2:

  toaster: fixes for customimage package not found (2016-04-08 09:38:50 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib elliot/toaster/recipe_name_validation-9209
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/recipe_name_validation-9209

Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9209

Elliot Smith (4):
  toaster: only prevent duplicate custom image names within a project
  toaster: prevent exception when Project.release is null
  toaster-tests: add tests for new custom image page
  toaster-tests: make helper click on input before entering text

 bitbake/lib/toaster/orm/models.py                  |  16 ++-
 .../lib/toaster/tests/browser/selenium_helpers.py  |   6 +-
 .../tests/browser/test_new_custom_image_page.py    | 160 +++++++++++++++++++++
 .../toastergui/static/js/newcustomimage_modal.js   |   8 +-
 bitbake/lib/toaster/toastergui/views.py            |  33 +++--
 5 files changed, 200 insertions(+), 23 deletions(-)
 create mode 100644 bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py

--
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



             reply	other threads:[~2016-04-11 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 11:27 Elliot Smith [this message]
2016-04-11 11:27 ` [PATCH 1/4] toaster: only prevent duplicate custom image names within a project Elliot Smith
2016-04-11 11:27 ` [PATCH 2/4] toaster: prevent exception when Project.release is null Elliot Smith
2016-04-11 11:27 ` [PATCH 3/4] toaster-tests: add tests for new custom image page Elliot Smith
2016-04-11 11:27 ` [PATCH 4/4] toaster-tests: make helper click on input before entering text Elliot Smith
2016-04-13 20:57 ` [PATCH 0/4] Validate custom image names correctly Lerner, Dave
2016-04-14  7:13   ` Smith, Elliot
2016-04-19 16:33     ` Michael Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1460373321.git.elliot.smith@intel.com \
    --to=elliot.smith@intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.