All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <panand@redhat.com>
To: mingo@kernel.org, alexandre.belloni@free-electrons.com
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
	prarit@redhat.com, Pratyush Anand <panand@redhat.com>
Subject: [rtc-linux] [PATCH RFC 0/2] rtc-cmos: Workaround unwanted interrupt generation
Date: Tue, 21 Jun 2016 10:25:34 +0530	[thread overview]
Message-ID: <cover.1466484019.git.panand@redhat.com> (raw)

We have observed on few machines with rtc-cmos device that
hpet_rtc_interrupt() is called before cmos_do_probe() could call
hpet_rtc_timer_init(). It has not been observed during normal boot/reboot
of machines. It *sometime* happens when system is booted with kdump
secondary kernel. So, neither hpet_default_delta nor hpet_t1_cmp is
initialized by the time interrupt is raised in the given situation.
Therefore while loop of hpet_cnt_ahead() in hpet_rtc_timer_reinit() never
completes. This leads to "NMI watchdog: Watchdog detected hard LOCKUP on
cpu 0".

I am still clueless, how can an interrupt be raised before RTC is enabled.
But i do not have any idea about this device, so I am putting this patch as
RFC to get feedback from hpet/rtc-cmos developer. I am sure there would be
some better solution than this.



Pratyush Anand (2):
  rtc/hpet: Factorize hpet_rtc_timer_init()
  rtc/rtc-cmos: Initialize software counters before irq is registered

 arch/x86/include/asm/hpet.h |  2 ++
 arch/x86/kernel/hpet.c      | 41 +++++++++++++++++++++++++++++++++++------
 drivers/rtc/rtc-cmos.c      | 13 ++++++++++++-
 3 files changed, 49 insertions(+), 7 deletions(-)

-- 
2.5.5

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Anand <panand@redhat.com>
To: mingo@kernel.org, alexandre.belloni@free-electrons.com
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
	prarit@redhat.com, Pratyush Anand <panand@redhat.com>
Subject: [PATCH RFC 0/2] rtc-cmos: Workaround unwanted interrupt generation
Date: Tue, 21 Jun 2016 10:25:34 +0530	[thread overview]
Message-ID: <cover.1466484019.git.panand@redhat.com> (raw)

We have observed on few machines with rtc-cmos device that
hpet_rtc_interrupt() is called before cmos_do_probe() could call
hpet_rtc_timer_init(). It has not been observed during normal boot/reboot
of machines. It *sometime* happens when system is booted with kdump
secondary kernel. So, neither hpet_default_delta nor hpet_t1_cmp is
initialized by the time interrupt is raised in the given situation.
Therefore while loop of hpet_cnt_ahead() in hpet_rtc_timer_reinit() never
completes. This leads to "NMI watchdog: Watchdog detected hard LOCKUP on
cpu 0".

I am still clueless, how can an interrupt be raised before RTC is enabled.
But i do not have any idea about this device, so I am putting this patch as
RFC to get feedback from hpet/rtc-cmos developer. I am sure there would be
some better solution than this.



Pratyush Anand (2):
  rtc/hpet: Factorize hpet_rtc_timer_init()
  rtc/rtc-cmos: Initialize software counters before irq is registered

 arch/x86/include/asm/hpet.h |  2 ++
 arch/x86/kernel/hpet.c      | 41 +++++++++++++++++++++++++++++++++++------
 drivers/rtc/rtc-cmos.c      | 13 ++++++++++++-
 3 files changed, 49 insertions(+), 7 deletions(-)

-- 
2.5.5

             reply	other threads:[~2016-06-21  4:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21  4:55 Pratyush Anand [this message]
2016-06-21  4:55 ` [PATCH RFC 0/2] rtc-cmos: Workaround unwanted interrupt generation Pratyush Anand
2016-06-21  4:55 ` [rtc-linux] [PATCH RFC 1/2] rtc/hpet: Factorize hpet_rtc_timer_init() Pratyush Anand
2016-06-21  4:55   ` Pratyush Anand
2016-06-23  8:33   ` [rtc-linux] " Thomas Gleixner
2016-06-23  8:33     ` Thomas Gleixner
2016-06-23 14:37     ` [rtc-linux] " Pratyush Anand
2016-06-23 14:37       ` Pratyush Anand
2016-06-21  4:55 ` [rtc-linux] [PATCH RFC 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered Pratyush Anand
2016-06-21  4:55   ` Pratyush Anand
2016-06-27  4:49 ` [rtc-linux] Re: [PATCH RFC 0/2] rtc-cmos: Workaround unwanted interrupt generation Pratyush Anand
2016-06-27  4:49   ` Pratyush Anand
2016-07-04 16:19   ` [rtc-linux] " Pratyush Anand
2016-07-04 16:19     ` Pratyush Anand
2016-07-18 11:47     ` [rtc-linux] " Pratyush Anand
2016-07-18 11:47       ` Pratyush Anand
2016-07-19 14:29       ` [rtc-linux] " Alexandre Belloni
2016-07-19 14:29         ` Alexandre Belloni
2016-07-20  3:56         ` [rtc-linux] " Pratyush Anand
2016-07-20  3:56           ` Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1466484019.git.panand@redhat.com \
    --to=panand@redhat.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=prarit@redhat.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.