[meta-networking][PATCH 0/2 v2] samba: fix waf-samba and restrict the blacklist to ARM

[meta-networking][PATCH 0/2 v2] samba: fix waf-samba and restrict the blacklist to ARM

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

--
The following changes since commit 80b2d4de0ee2a5e6a3302a527e3fcfd2b99c3e37:

  samba: blacklist, fails to build with new binutils-2.27 (2016-09-05 13:34:13 -0400)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib.git jhuang0/d_samba_160909_0
  http://git.pokylinux.org/cgit.cgi//log/?h=jhuang0/d_samba_160909_0

Jackie Huang (2):
  waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS
  samba: restrict the blacklist to ARM only

 meta-networking/classes/waf-samba.bbclass                 | 1 +
 meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.8.3

[meta-networking][PATCH 1/2 v2] waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS for waf-samba.bbclass
because the PACKAGECONFIG will not be handled for all recipes after
the following commit in oe-core:

commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
Author: Martin Jansa <martin.jansa@gmail.com>
Date:   Tue Aug 30 16:19:58 2016 +0200

    base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in autotools.bbclass

    * recipes which don't inherit autotools or cmake bbclass and want to
      use the configure options from PACKAGECONFIG need to handle
      PACKAGECONFIG_CONFARGS themselves.

    Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta-networking/classes/waf-samba.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-samba.bbclass
index 772bc75..af4c7d0 100644
--- a/meta-networking/classes/waf-samba.bbclass
+++ b/meta-networking/classes/waf-samba.bbclass
@@ -18,6 +18,7 @@ CONFIGUREOPTS = " --prefix=${prefix} \
                   --oldincludedir=${oldincludedir} \
                   --infodir=${infodir} \
                   --mandir=${mandir} \
+                  ${PACKAGECONFIG_CONFARGS} \
                 "
 
 # Three methods for waf cross compile:
-- 
2.8.3

[meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only

[jackie.huang]

From: Jackie Huang <jackie.huang@windriver.com>

It builds fine except for arm now, and the do_package
and libpam issue is fixed by:
"waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
index 042203e..c34adcb 100644
--- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
+++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
@@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl"
 FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
 
 # http://errors.yoctoproject.org/Errors/Details/81004/
-# before this issue it was also failing in do_package and
-# autodetecting libpam dependency
-PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
+BLACKLIST_REASON ?= ""
+BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27"
+PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
-- 
2.8.3

Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

[[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.09 (Fri 10:34) jackie.huang@windriver.com wrote:

> From: Jackie Huang <jackie.huang@windriver.com>
> 
> It builds fine except for arm now, and the do_package
> and libpam issue is fixed by:
> "waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"

Did you confirm that you're still seeing the failure for arm?

-J.

> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> index 042203e..c34adcb 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> @@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl"
>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
>  
>  # http://errors.yoctoproject.org/Errors/Details/81004/
> -# before this issue it was also failing in do_package and
> -# autodetecting libpam dependency
> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
> +BLACKLIST_REASON ?= ""
> +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27"
> +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
> -- 
> 2.8.3
> 
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only

[Andreas Müller]

On Fri, Sep 9, 2016 at 10:44 PM, Joe MacDonald <Joe_MacDonald@mentor.com> wrote:
> [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.09 (Fri 10:34) jackie.huang@windriver.com wrote:
>
>> From: Jackie Huang <jackie.huang@windriver.com>
>>
>> It builds fine except for arm now, and the do_package
>> and libpam issue is fixed by:
>> "waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"
>
> Did you confirm that you're still seeing the failure for arm?
>
> -J.
>
>>
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> ---
>>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
>> index 042203e..c34adcb 100644
>> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
>> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
>> @@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl"
>>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
>>
>>  # http://errors.yoctoproject.org/Errors/Details/81004/
>> -# before this issue it was also failing in do_package and
>> -# autodetecting libpam dependency
>> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
>> +BLACKLIST_REASON ?= ""
>> +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27"
>> +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
>> --
>> 2.8.3
>>
> --
> -Joe MacDonald.
> :wq
>
Did you see [1] - it fixes build for arm.

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/108972.html


Andreas

Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]

[Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.10 (Sat 00:03) Andreas Müller wrote:

> On Fri, Sep 9, 2016 at 10:44 PM, Joe MacDonald <Joe_MacDonald@mentor.com> wrote:
> > [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.09 (Fri 10:34) jackie.huang@windriver.com wrote:
> >
> >> From: Jackie Huang <jackie.huang@windriver.com>
> >>
> >> It builds fine except for arm now, and the do_package
> >> and libpam issue is fixed by:
> >> "waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"
> >
> > Did you confirm that you're still seeing the failure for arm?
> >
> > -J.
> >
> >>
> >> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> >> ---
> >>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> >> index 042203e..c34adcb 100644
> >> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> >> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> >> @@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl"
> >>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
> >>
> >>  # http://errors.yoctoproject.org/Errors/Details/81004/
> >> -# before this issue it was also failing in do_package and
> >> -# autodetecting libpam dependency
> >> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
> >> +BLACKLIST_REASON ?= ""
> >> +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27"
> >> +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
> >> --
> >> 2.8.3
> >>
> > --
> > -Joe MacDonald.
> > :wq
> >
> Did you see [1] - it fixes build for arm.
> 
> [1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/108972.html

I didn't, actually, but I had picked it up in my tree anyway when I
scooped up the latest set of changes in master-next.  The reason I was
asking was because I wasn't seeing a failure anymore in samba on arm and
was curious why Jackie was still seeing it if I wasn't and I hadn't seen
an explicit patch to resolve the issue.  But there it is, mystery
solved.  Thanks for the heads-up, Andreas.

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of Joe MacDonald
> Sent: Saturday, September 10, 2016 8:35 AM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only
> 
> [Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.10 (Sat
> 00:03) Andreas Müller wrote:
> 
> > On Fri, Sep 9, 2016 at 10:44 PM, Joe MacDonald <Joe_MacDonald@mentor.com> wrote:
> > > [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.09 (Fri
> 10:34) jackie.huang@windriver.com wrote:
> > >
> > >> From: Jackie Huang <jackie.huang@windriver.com>
> > >>
> > >> It builds fine except for arm now, and the do_package
> > >> and libpam issue is fixed by:
> > >> "waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"
> > >
> > > Did you confirm that you're still seeing the failure for arm?
> > >
> > > -J.
> > >
> > >>
> > >> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> > >> ---
> > >>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
> > >>  1 file changed, 3 insertions(+), 3 deletions(-)
> > >>
> > >> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-
> networking/recipes-connectivity/samba/samba_4.4.5.bb
> > >> index 042203e..c34adcb 100644
> > >> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > >> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > >> @@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl"
> > >>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
> > >>
> > >>  # http://errors.yoctoproject.org/Errors/Details/81004/
> > >> -# before this issue it was also failing in do_package and
> > >> -# autodetecting libpam dependency
> > >> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27"
> > >> +BLACKLIST_REASON ?= ""
> > >> +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27"
> > >> +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
> > >> --
> > >> 2.8.3
> > >>
> > > --
> > > -Joe MacDonald.
> > > :wq
> > >
> > Did you see [1] - it fixes build for arm.
> >
> > [1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-
> September/108972.html
> 
> I didn't, actually, but I had picked it up in my tree anyway when I
> scooped up the latest set of changes in master-next.  The reason I was
> asking was because I wasn't seeing a failure anymore in samba on arm and
> was curious why Jackie was still seeing it if I wasn't and I hadn't seen

Actually I never see the failure in:
http://errors.yoctoproject.org/Errors/Details/81004/

and I didn't notice Andreas' patch, I was fixing another issue but Mark asked me
to include the restrict on ARM, please see:

https://patchwork.openembedded.org/patch/131249/

so I thought at least Mark was still seeing this and sent this patch.

Mark, could you confirm that you're still seeing the failure for arm?

Thanks,
Jackie

> an explicit patch to resolve the issue.  But there it is, mystery
> solved.  Thanks for the heads-up, Andreas.
> 
> --
> -Joe MacDonald.
> :wq

Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only

[Mark Asselstine]

On Sunday, September 11, 2016 9:26:44 PM EDT Huang, Jie (Jackie) wrote:
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel- bounces@lists.openembedded.org] On Behalf Of
> > Joe MacDonald
> > Sent: Saturday, September 10, 2016 8:35 AM
> > To: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the
> > blacklist to ARM only
> > 
> > [Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to
> > ARM only] On 16.09.10 (Sat> 
> > 00:03) Andreas Müller wrote:
> > > On Fri, Sep 9, 2016 at 10:44 PM, Joe MacDonald 
<Joe_MacDonald@mentor.com> wrote:
> > > > [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to
> > > > ARM only] On 16.09.09 (Fri> 
> > 10:34) jackie.huang@windriver.com wrote:
> > > >> From: Jackie Huang <jackie.huang@windriver.com>
> > > >> 
> > > >> It builds fine except for arm now, and the do_package
> > > >> and libpam issue is fixed by:
> > > >> "waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"
> > > > 
> > > > Did you confirm that you're still seeing the failure for arm?
> > > > 
> > > > -J.
> > > > 
> > > >> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> > > >> ---
> > > >> 
> > > >>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
> > > >>  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >> 
> > > >> diff --git
> > > >> a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-> 
> > networking/recipes-connectivity/samba/samba_4.4.5.bb
> > 
> > > >> index 042203e..c34adcb 100644
> > > >> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > > >> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > > >> @@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl"
> > > >> 
> > > >>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
> > > >>  
> > > >>  # http://errors.yoctoproject.org/Errors/Details/81004/
> > > >> 
> > > >> -# before this issue it was also failing in do_package and
> > > >> -# autodetecting libpam dependency
> > > >> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new
> > > >> binutils-2.27"
> > > >> +BLACKLIST_REASON ?= ""
> > > >> +BLACKLIST_REASON_arm = "BROKEN: fails to build with new
> > > >> binutils-2.27"
> > > >> +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
> > > >> --
> > > >> 2.8.3
> > > > 
> > > > --
> > > > -Joe MacDonald.
> > > > 
> > > > :wq
> > > 
> > > Did you see [1] - it fixes build for arm.
> > > 
> > > [1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-> > 
> > September/108972.html
> > 
> > I didn't, actually, but I had picked it up in my tree anyway when I
> > scooped up the latest set of changes in master-next.  The reason I was
> > asking was because I wasn't seeing a failure anymore in samba on arm and
> > was curious why Jackie was still seeing it if I wasn't and I hadn't seen
> 
> Actually I never see the failure in:
> http://errors.yoctoproject.org/Errors/Details/81004/
> 
> and I didn't notice Andreas' patch, I was fixing another issue but Mark
> asked me to include the restrict on ARM, please see:
> 
> https://patchwork.openembedded.org/patch/131249/
> 
> so I thought at least Mark was still seeing this and sent this patch.
> 
> Mark, could you confirm that you're still seeing the failure for arm?

I was never able to reproduce the issue but was working on the assumption that 
it was still a real issue, and thus the need to continue to blacklist ARM. if 
the issue no longer exists then the proper thing to do would be to remove the 
blacklist entry and in the commit log which does this, identify what changed 
to remedy the situation. 

Mark


> 
> Thanks,
> Jackie
> 
> > an explicit patch to resolve the issue.  But there it is, mystery
> > solved.  Thanks for the heads-up, Andreas.
> > 
> > --
> > -Joe MacDonald.
> > 
> > :wq