* [PATCH 0/2] Staging: Add space around the operator.
@ 2016-09-22 9:50 Sandhya Bankar
2016-09-22 9:53 ` [PATCH 1/2] Staging: speakup: varhandlers: " Sandhya Bankar
2016-09-22 9:57 ` [PATCH 2/2] Staging: speakup: kobjects: " Sandhya Bankar
0 siblings, 2 replies; 3+ messages in thread
From: Sandhya Bankar @ 2016-09-22 9:50 UTC (permalink / raw)
To: outreachy-kernel; +Cc: w.d.hubbs, chris, kirk, samuel.thibault, gregkh
This issue was found by checkpatch.
Sandhya Bankar (2):
Staging: speakup: kobjects: Add space around the operator.
Staging: speakup: varhandlers: Add space around the operator.
drivers/staging/speakup/kobjects.c | 10 +++++-----
drivers/staging/speakup/varhandlers.c | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] Staging: speakup: varhandlers: Add space around the operator.
2016-09-22 9:50 [PATCH 0/2] Staging: Add space around the operator Sandhya Bankar
@ 2016-09-22 9:53 ` Sandhya Bankar
2016-09-22 9:57 ` [PATCH 2/2] Staging: speakup: kobjects: " Sandhya Bankar
1 sibling, 0 replies; 3+ messages in thread
From: Sandhya Bankar @ 2016-09-22 9:53 UTC (permalink / raw)
To: outreachy-kernel; +Cc: w.d.hubbs, chris, kirk, samuel.thibault, gregkh
This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/speakup/varhandlers.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index e1393d2..21186e3 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -276,7 +276,7 @@ int spk_set_mask_bits(const char *input, const int which, const int how)
u_char *cp;
short mask = spk_punc_info[which].mask;
- if (how&1) {
+ if (how & 1) {
for (cp = (u_char *)spk_punc_info[3].value; *cp; cp++)
spk_chartab[*cp] &= ~mask;
}
@@ -290,14 +290,14 @@ int spk_set_mask_bits(const char *input, const int which, const int how)
if (mask < PUNC) {
if (!(spk_chartab[*cp] & PUNC))
break;
- } else if (spk_chartab[*cp]&B_NUM)
+ } else if (spk_chartab[*cp] & B_NUM)
break;
}
if (*cp)
return -EINVAL;
cp = (u_char *)input;
}
- if (how&2) {
+ if (how & 2) {
for (; *cp; cp++)
if (*cp > SPACE)
spk_chartab[*cp] |= mask;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] Staging: speakup: kobjects: Add space around the operator.
2016-09-22 9:50 [PATCH 0/2] Staging: Add space around the operator Sandhya Bankar
2016-09-22 9:53 ` [PATCH 1/2] Staging: speakup: varhandlers: " Sandhya Bankar
@ 2016-09-22 9:57 ` Sandhya Bankar
1 sibling, 0 replies; 3+ messages in thread
From: Sandhya Bankar @ 2016-09-22 9:57 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, samuel.thibault, w.d.hubbs, chris, kirk
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/speakup/kobjects.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 7fedee3..4a78d37 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -251,7 +251,7 @@ static ssize_t keymap_show(struct kobject *kobj, struct kobj_attribute *attr,
}
cp += sprintf(cp, "0, %d\n", KEY_MAP_VER);
spin_unlock_irqrestore(&speakup_info.spinlock, flags);
- return (int)(cp-buf);
+ return (int)(cp - buf);
}
/*
@@ -288,8 +288,8 @@ static ssize_t keymap_store(struct kobject *kobj, struct kobj_attribute *attr,
cp = spk_s2uchar(cp, cp1);
cp1++;
}
- i = (int)cp1[-2]+1;
- i *= (int)cp1[-1]+1;
+ i = (int)cp1[-2] + 1;
+ i *= (int)cp1[-1] + 1;
i += 2; /* 0 and last map ver */
if (cp1[-3] != KEY_MAP_VER || cp1[-1] > 10 ||
i+SHIFT_TBL_SIZE+4 >= sizeof(spk_key_buf)) {
@@ -350,9 +350,9 @@ static ssize_t silent_store(struct kobject *kobj, struct kobj_attribute *attr,
} else {
shut = 0;
}
- if (ch&4)
+ if (ch & 4)
shut |= 0x40;
- if (ch&1)
+ if (ch & 1)
spk_shut_up |= shut;
else
spk_shut_up &= ~shut;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-22 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-22 9:50 [PATCH 0/2] Staging: Add space around the operator Sandhya Bankar
2016-09-22 9:53 ` [PATCH 1/2] Staging: speakup: varhandlers: " Sandhya Bankar
2016-09-22 9:57 ` [PATCH 2/2] Staging: speakup: kobjects: " Sandhya Bankar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.