* [PATCH v4 0/5] staging: bcm2835-audio: fix multiple checkpatch warnings @ 2017-03-02 18:44 Aishwarya Pant 2017-03-02 18:45 ` [PATCH v4 1/5] staging: bcm2835-audio: move logical continuation to the same line Aishwarya Pant 0 siblings, 1 reply; 4+ messages in thread From: Aishwarya Pant @ 2017-03-02 18:44 UTC (permalink / raw) To: Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden, bcm-kernel-feedback-list Cc: outreachy-kernel Fix multiple code styling warnings issued by checkpatch on file bcm2835-ctl.c in bcm2835-audio driver Changes in v4: -Refactor commit messages Changes in v3: -Merge two if conditions -Fix subject of patch replace printk(... by dev_err(... Changes in v2: -Replace pr_err with dev_err Aishwarya Pant (5): *** HERE *** staging: bcm2835-audio: remove space after cast staging: bcm2835-audio: move logical continuation to the same line staging: bcm2835-audio: use kernel preferred block commenting style staging: bcm2835-audio: remove extra blank line staging: bcm2835-audio: replace printk(KERN_ERR...) with dev_err(...) .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 23 ++++++++++------------ 1 file changed, 10 insertions(+), 13 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v4 1/5] staging: bcm2835-audio: move logical continuation to the same line 2017-03-02 18:44 [PATCH v4 0/5] staging: bcm2835-audio: fix multiple checkpatch warnings Aishwarya Pant @ 2017-03-02 18:45 ` Aishwarya Pant 2017-03-02 22:43 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Aishwarya Pant @ 2017-03-02 18:45 UTC (permalink / raw) To: Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden, bcm-kernel-feedback-list Cc: outreachy-kernel Remove instances of unnecessary blank space after cast in bcm2835-ctl.c Signed-off-by: Aishwarya Pant <aishpant@gmail.com> --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c index a4ffa1b..99e9ca3 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c @@ -116,7 +116,7 @@ static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol, return -EINTR; if (kcontrol->private_value == PCM_PLAYBACK_VOLUME) { - audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int) ucontrol->value.integer.value[0]); + audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int)ucontrol->value.integer.value[0]); if (chip->mute == CTRL_VOL_MUTE) { /* changed = toggle_mute(chip, CTRL_VOL_UNMUTE); */ changed = 1; /* should return 0 to signify no change but the mixer takes this as the opposite sign (no idea why) */ @@ -226,7 +226,7 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol, return -EINTR; for (i = 0; i < 4; i++) - val |= (unsigned int) ucontrol->value.iec958.status[i] << (i * 8); + val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8); change = val != chip->spdif_status; chip->spdif_status = val; @@ -289,7 +289,7 @@ static int snd_bcm2835_spdif_stream_put(struct snd_kcontrol *kcontrol, return -EINTR; for (i = 0; i < 4; i++) - val |= (unsigned int) ucontrol->value.iec958.status[i] << (i * 8); + val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8); change = val != chip->spdif_status; chip->spdif_status = val; -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v4 1/5] staging: bcm2835-audio: move logical continuation to the same line 2017-03-02 18:45 ` [PATCH v4 1/5] staging: bcm2835-audio: move logical continuation to the same line Aishwarya Pant @ 2017-03-02 22:43 ` Julia Lawall 2017-03-02 22:43 ` Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Julia Lawall @ 2017-03-02 22:43 UTC (permalink / raw) To: Aishwarya Pant Cc: Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden, bcm-kernel-feedback-list, outreachy-kernel The subject seems quite unrelated to the patch. julia On Fri, 3 Mar 2017, Aishwarya Pant wrote: > Remove instances of unnecessary blank space after cast in bcm2835-ctl.c > > Signed-off-by: Aishwarya Pant <aishpant@gmail.com> > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > index a4ffa1b..99e9ca3 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > @@ -116,7 +116,7 @@ static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol, > return -EINTR; > > if (kcontrol->private_value == PCM_PLAYBACK_VOLUME) { > - audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int) ucontrol->value.integer.value[0]); > + audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int)ucontrol->value.integer.value[0]); > if (chip->mute == CTRL_VOL_MUTE) { > /* changed = toggle_mute(chip, CTRL_VOL_UNMUTE); */ > changed = 1; /* should return 0 to signify no change but the mixer takes this as the opposite sign (no idea why) */ > @@ -226,7 +226,7 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol, > return -EINTR; > > for (i = 0; i < 4; i++) > - val |= (unsigned int) ucontrol->value.iec958.status[i] << (i * 8); > + val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8); > > change = val != chip->spdif_status; > chip->spdif_status = val; > @@ -289,7 +289,7 @@ static int snd_bcm2835_spdif_stream_put(struct snd_kcontrol *kcontrol, > return -EINTR; > > for (i = 0; i < 4; i++) > - val |= (unsigned int) ucontrol->value.iec958.status[i] << (i * 8); > + val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8); > change = val != chip->spdif_status; > chip->spdif_status = val; > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/845a46f44fdc14bf896d03a9edd388716329cb47.1488479861.git.aishpant%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v4 1/5] staging: bcm2835-audio: move logical continuation to the same line 2017-03-02 22:43 ` [Outreachy kernel] " Julia Lawall @ 2017-03-02 22:43 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2017-03-02 22:43 UTC (permalink / raw) To: Julia Lawall Cc: Aishwarya Pant, Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden, bcm-kernel-feedback-list, outreachy-kernel On Thu, 2 Mar 2017, Julia Lawall wrote: > The subject seems quite unrelated to the patch. Oops, I didn't notice that this was already fixed. julia > > julia > > On Fri, 3 Mar 2017, Aishwarya Pant wrote: > > > Remove instances of unnecessary blank space after cast in bcm2835-ctl.c > > > > Signed-off-by: Aishwarya Pant <aishpant@gmail.com> > > --- > > drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > > index a4ffa1b..99e9ca3 100644 > > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > > @@ -116,7 +116,7 @@ static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol, > > return -EINTR; > > > > if (kcontrol->private_value == PCM_PLAYBACK_VOLUME) { > > - audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int) ucontrol->value.integer.value[0]); > > + audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int)ucontrol->value.integer.value[0]); > > if (chip->mute == CTRL_VOL_MUTE) { > > /* changed = toggle_mute(chip, CTRL_VOL_UNMUTE); */ > > changed = 1; /* should return 0 to signify no change but the mixer takes this as the opposite sign (no idea why) */ > > @@ -226,7 +226,7 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol, > > return -EINTR; > > > > for (i = 0; i < 4; i++) > > - val |= (unsigned int) ucontrol->value.iec958.status[i] << (i * 8); > > + val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8); > > > > change = val != chip->spdif_status; > > chip->spdif_status = val; > > @@ -289,7 +289,7 @@ static int snd_bcm2835_spdif_stream_put(struct snd_kcontrol *kcontrol, > > return -EINTR; > > > > for (i = 0; i < 4; i++) > > - val |= (unsigned int) ucontrol->value.iec958.status[i] << (i * 8); > > + val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8); > > change = val != chip->spdif_status; > > chip->spdif_status = val; > > > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/845a46f44fdc14bf896d03a9edd388716329cb47.1488479861.git.aishpant%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-02 22:43 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-03-02 18:44 [PATCH v4 0/5] staging: bcm2835-audio: fix multiple checkpatch warnings Aishwarya Pant 2017-03-02 18:45 ` [PATCH v4 1/5] staging: bcm2835-audio: move logical continuation to the same line Aishwarya Pant 2017-03-02 22:43 ` [Outreachy kernel] " Julia Lawall 2017-03-02 22:43 ` Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.