[PATCH 0/2] Use true/false instead of 1/0 for bool initialisations

[PATCH 0/2] Use true/false instead of 1/0 for bool initialisations

[sayli karnik]

The patch series uses true and false instead of 1 and 0 as bool variable
values. Detected by coccinelle/misc/boolinit.cocci.

sayli karnik (2):
  staging: media: mt9m114: Use true/false instead of 1/0 for bool
    initialisations
  staging: media: mt9m114: Use true/false instead of 1/0 for bool
    initialisations

 drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
 drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.7.4

Re: [Outreachy kernel] [PATCH 0/2] Use true/false instead of 1/0 for bool initialisations

[Julia Lawall]

On Sun, 12 Mar 2017, sayli karnik wrote:

> The patch series uses true and false instead of 1 and 0 as bool variable
> values. Detected by coccinelle/misc/boolinit.cocci.
>
> sayli karnik (2):
>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
>     initialisations
>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
>     initialisations

The two lines are identical?

julia

>
>  drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
>  drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 0/2] Use true/false instead of 1/0 for bool initialisations

[sayli karnik]

On Sun, Mar 12, 2017 at 8:17 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 12 Mar 2017, sayli karnik wrote:
>
>> The patch series uses true and false instead of 1 and 0 as bool variable
>> values. Detected by coccinelle/misc/boolinit.cocci.
>>
>> sayli karnik (2):
>>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
>>     initialisations
>>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
>>     initialisations
>
> The two lines are identical?
>
Actually one is for mt9m114.c and the other for mt9m114.h
Had sent 2 separate patches initially, but re-sent them as a series as
suggested by Greg.
> julia
>
>>
>>  drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
>>  drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
>>  2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH 0/2] Use true/false instead of 1/0 for bool initialisations

[Julia Lawall]

On Sun, 12 Mar 2017, sayli karnik wrote:

> On Sun, Mar 12, 2017 at 8:17 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Sun, 12 Mar 2017, sayli karnik wrote:
> >
> >> The patch series uses true and false instead of 1 and 0 as bool variable
> >> values. Detected by coccinelle/misc/boolinit.cocci.
> >>
> >> sayli karnik (2):
> >>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
> >>     initialisations
> >>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
> >>     initialisations
> >
> > The two lines are identical?
> >
> Actually one is for mt9m114.c and the other for mt9m114.h
> Had sent 2 separate patches initially, but re-sent them as a series as
> suggested by Greg.

OK, I haven't see the actual series yet for some reason, but every patch
has to have a different subject line.

Maybe it would make sense to just merge them into one.

julia

> > julia
> >
> >>
> >>  drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
> >>  drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
> >>  2 files changed, 5 insertions(+), 5 deletions(-)
> >>
> >> --
> >> 2.7.4
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>

Re: [Outreachy kernel] [PATCH 0/2] Use true/false instead of 1/0 for bool initialisations

[sayli karnik]

On Sun, Mar 12, 2017 at 8:25 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 12 Mar 2017, sayli karnik wrote:
>
>> On Sun, Mar 12, 2017 at 8:17 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> >
>> >
>> > On Sun, 12 Mar 2017, sayli karnik wrote:
>> >
>> >> The patch series uses true and false instead of 1 and 0 as bool variable
>> >> values. Detected by coccinelle/misc/boolinit.cocci.
>> >>
>> >> sayli karnik (2):
>> >>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
>> >>     initialisations
>> >>   staging: media: mt9m114: Use true/false instead of 1/0 for bool
>> >>     initialisations
>> >
>> > The two lines are identical?
>> >
>> Actually one is for mt9m114.c and the other for mt9m114.h
>> Had sent 2 separate patches initially, but re-sent them as a series as
>> suggested by Greg.
>
> OK, I haven't see the actual series yet for some reason, but every patch
> has to have a different subject line.
>
> Maybe it would make sense to just merge them into one.
>
Umm..okay I'll send one patch merging the two.

> julia
>
>> > julia
>> >
>> >>
>> >>  drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
>> >>  drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
>> >>  2 files changed, 5 insertions(+), 5 deletions(-)
>> >>
>> >> --
>> >> 2.7.4
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
>> >> For more options, visit https://groups.google.com/d/optout.
>> >>
>>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1703121554350.2174%40hadrien.
> For more options, visit https://groups.google.com/d/optout.