[PATCH 0/3] staging: iio: Fix multiple checkpatch issues

[PATCH 0/3] staging: iio: Fix multiple checkpatch issues

[Narcisa Ana Maria Vasile]

This patchset fixes multiple whitespace and alignment issues
reported by checkpatch.pl

Narcisa Ana Maria Vasile (3):
  staging: iio: adt7136: Remove unnecessary blank lines
  staging: iio: Add blank lines after function declarations
  staging: iio: cdc: ad7746: Fix alignment with paranthesis

 drivers/staging/iio/addac/adt7316.c | 5 +----
 drivers/staging/iio/cdc/ad7152.c    | 1 +
 drivers/staging/iio/cdc/ad7746.c    | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

-- 
1.9.1

[PATCH 1/3] staging: iio: adt7136: Remove unnecessary blank lines

[Narcisa Ana Maria Vasile]

This was reported by checkpatch.pl

Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
---
 drivers/staging/iio/addac/adt7316.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index aa251c2..872fac6 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -244,7 +244,6 @@ static ssize_t _adt7316_store_enabled(struct adt7316_chip_info *chip,
 	chip->config1 = config1;
 
 	return ret;
-
 }
 
 static ssize_t adt7316_store_enabled(struct device *dev,
@@ -434,7 +433,6 @@ static ssize_t adt7316_store_ad_channel(struct device *dev,
 		config2 = chip->config2 & (~ADT7316_AD_SINGLE_CH_MASK);
 	}
 
-
 	config2 |= data;
 
 	ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG2, config2);
@@ -725,7 +723,6 @@ static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,
 		adt7316_store_AIN_internal_Vref,
 		0);
 
-
 static ssize_t adt7316_show_enable_prop_DACA(struct device *dev,
 		struct device_attribute *attr,
 		char *buf)
@@ -925,7 +922,6 @@ static ssize_t adt7316_show_all_DAC_update_modes(struct device *dev,
 static IIO_DEVICE_ATTR(all_DAC_update_modes, 0444,
 		adt7316_show_all_DAC_update_modes, NULL, 0);
 
-
 static ssize_t adt7316_store_update_DAC(struct device *dev,
 		struct device_attribute *attr,
 		const char *buf,
-- 
1.9.1

[PATCH 2/3] staging: iio: Add blank lines after function declarations

[Narcisa Ana Maria Vasile]

This was reported by checkpatch.pl:
CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
---
 drivers/staging/iio/addac/adt7316.c | 1 +
 drivers/staging/iio/cdc/ad7152.c    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 872fac6..b2bce26 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -1863,6 +1863,7 @@ static ssize_t adt7316_set_int_mask(struct device *dev,
 
 	return len;
 }
+
 static inline ssize_t adt7316_show_ad_bound(struct device *dev,
 		struct device_attribute *attr,
 		char *buf)
diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index e8609b8..7679633 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -244,6 +244,7 @@ static int ad7152_write_raw_samp_freq(struct device *dev, int val)
 
 	return ret;
 }
+
 static int ad7152_write_raw(struct iio_dev *indio_dev,
 			    struct iio_chan_spec const *chan,
 			    int val,
-- 
1.9.1

[PATCH 3/3] staging: iio: cdc: ad7746: Fix alignment with paranthesis

[Narcisa Ana Maria Vasile]

This was reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis

Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
---
 drivers/staging/iio/cdc/ad7746.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 81f8b9e..69845a2 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -546,7 +546,7 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
 
 		regval = chip->config | AD7746_CONF_MODE_SINGLE_CONV;
 		ret = i2c_smbus_write_byte_data(chip->client, AD7746_REG_CFG,
-				regval);
+						regval);
 		if (ret < 0)
 			goto out;
 
-- 
1.9.1

Re: [PATCH 3/3] staging: iio: cdc: ad7746: Fix alignment with paranthesis

[Narcisa Ana Maria Vasile]

On Wed, Mar 22, 2017 at 08:38:36PM +0000, Jonathan Cameron wrote:
> On 20/03/17 12:18, Narcisa Ana Maria Vasile wrote:
> > This was reported by checkpatch.pl:
> > CHECK: Alignment should match open parenthesis
> > 
> > Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
> Applied to the togreg branch of iio.git and pushed out as testing.
> 
> Only real comment on this series is that it wasn't really a series.
> The linking element was check patch warnings.  Not really enough.
> A series should exist for one of two reasons:
> 1) Patches to the same driver that need to be applied in order to avoid fuzz
> or for more fundamental reasons.
> 2) Grouping patches because they are the same change to lots of drivers.
> This is useful because it aids review - comments also apply to at least
> some subset of the patches.
> 
> Doesn't matter that much, but these should really just have been 3 separate
> patches.  The first 2 might just fall under type 1 above I suppose, but
> not this third one!
> 
> Thanks,
> 
> Jonathan

  Ok, I'll keep this in mind. Indeed, I grouped them because they were
  all fixing checkpatch warnings. It's clear now that I
  shouldn't have made a patchset.
  Sorry for the mistake.

  Thank you,
  Narcisa
> > ---
> >  drivers/staging/iio/cdc/ad7746.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> > index 81f8b9e..69845a2 100644
> > --- a/drivers/staging/iio/cdc/ad7746.c
> > +++ b/drivers/staging/iio/cdc/ad7746.c
> > @@ -546,7 +546,7 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
> >  
> >  		regval = chip->config | AD7746_CONF_MODE_SINGLE_CONV;
> >  		ret = i2c_smbus_write_byte_data(chip->client, AD7746_REG_CFG,
> > -				regval);
> > +						regval);
> >  		if (ret < 0)
> >  			goto out;
> >  
> > 
>