All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] tinfoil overrides fix
@ 2017-04-20  2:20 Paul Eggleton
  2017-04-20  2:20 ` [PATCH 1/1] lib/bb/command: fix overrides in remote datastores where there is no default Paul Eggleton
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2017-04-20  2:20 UTC (permalink / raw)
  To: bitbake-devel

The following changes since commit b4da94a368c6c44c6e5b6e6e9a1e041ed84b4554:

  bitbake: Update version to 1.34.0 for stable release (2017-04-19 10:42:07 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib paule/tinfoil-overrides2-bb
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/tinfoil-overrides2-bb

Paul Eggleton (1):
  lib/bb/command: fix overrides in remote datastores where there is no default

 lib/bb/command.py | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.9.3



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] lib/bb/command: fix overrides in remote datastores where there is no default
  2017-04-20  2:20 [PATCH 0/1] tinfoil overrides fix Paul Eggleton
@ 2017-04-20  2:20 ` Paul Eggleton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggleton @ 2017-04-20  2:20 UTC (permalink / raw)
  To: bitbake-devel

If you have, for example, no value set for a variable VARIABLE and a
then VARIABLE_pn-something = "value" and then you parse something.bb,
you expect getVar('VARIABLE') on the resulting datastore to return
"value", but the code here assumed that if the variable wasn't set
without overrides then we didn't need to return the overridedata and
thus we didn't get the overridden value.

In OE this affected the ability to get RECIPE_MAINTAINER for a recipe
in a script using tinfoil (since this is only set from an inc file with
_pn- overrides for each recipe, and no default is set).

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 lib/bb/command.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/bb/command.py b/lib/bb/command.py
index 390d4f1..ab51d8e 100644
--- a/lib/bb/command.py
+++ b/lib/bb/command.py
@@ -479,6 +479,9 @@ class CommandsSync:
                         '_connector_overrides': overridedata}
             else:
                 value['_connector_overrides'] = overridedata
+        else:
+            value = {}
+            value['_connector_overrides'] = overridedata
         return value
     dataStoreConnectorFindVar.readonly = True
 
-- 
2.9.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-20  2:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-20  2:20 [PATCH 0/1] tinfoil overrides fix Paul Eggleton
2017-04-20  2:20 ` [PATCH 1/1] lib/bb/command: fix overrides in remote datastores where there is no default Paul Eggleton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.