* [PATCH 1/4] toaster: display error when the fstype select is empty
2017-09-03 5:23 [PATCH 0/4] toaster: cummulative 30082017 patch David Reyna
@ 2017-09-03 5:24 ` David Reyna
2017-09-03 5:24 ` [PATCH 2/4] toaster: Order column in Tasks selectable David Reyna
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: David Reyna @ 2017-09-03 5:24 UTC (permalink / raw)
To: bitbake-devel
From: David Reyna <David.Reyna@windriver.com>
There must be at least one FSTYPE selected in the Toaster bitbake
variable editor page. When the user deselects all the "Save"
button gets disabled, but the error message is missing.
[YOCTO #8126]
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
lib/toaster/toastergui/templates/projectconf.html | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/toaster/toastergui/templates/projectconf.html b/lib/toaster/toastergui/templates/projectconf.html
index fcf6df2..0e9712b 100644
--- a/lib/toaster/toastergui/templates/projectconf.html
+++ b/lib/toaster/toastergui/templates/projectconf.html
@@ -63,6 +63,7 @@
<button id="cancel-change-image_fstypes" type="button" class="btn btn-link">Cancel</button>
</div>
<p class="help-block text-danger" style="display:none;" id="hintError-image-fs_type">A valid image type cannot include underscores</p>
+ <p class="help-block text-danger" style="display:none;" id="fstypes-error-message">You must select at least one image type</p>
<label>Or choose from known image types:</label>
<input id="filter-image_fstypes" type="text" placeholder="Search image types" class="form-control">
<div id="all-image_fstypes" class="scrolling"></div>
@@ -716,8 +717,10 @@ $(document).ready(function() {
}
if ($('#new-imagefs_types').val().length === 0) {
$("#apply-change-image_fstypes").prop("disabled", true);
+ $('#fstypes-error-message').show();
} else {
$("#apply-change-image_fstypes").prop("disabled", false);
+ $('#fstypes-error-message').hide();
}
});
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/4] toaster: Order column in Tasks selectable
2017-09-03 5:23 [PATCH 0/4] toaster: cummulative 30082017 patch David Reyna
2017-09-03 5:24 ` [PATCH 1/4] toaster: display error when the fstype select is empty David Reyna
@ 2017-09-03 5:24 ` David Reyna
2017-09-03 5:24 ` [PATCH 3/4] toaster: debug message for lists layers missing separators David Reyna
2017-09-03 5:24 ` [PATCH 4/4] toaster: set default pokydirname if no external layers David Reyna
3 siblings, 0 replies; 5+ messages in thread
From: David Reyna @ 2017-09-03 5:24 UTC (permalink / raw)
To: bitbake-devel
From: Awais Belal <awais_belal@mentor.com>
The build page provides tables related to performance that
cover build time, CPU time and disk IO. The "Edit columns"
drop down does not allow selection of the Order column and
makes it hidden as well which is not accurate from user
interaction point of view.
This patch enables the hideable property for the Order column
so it is hidden by default but the user can enable it through
the drop down if need be.
[YOCTO #11040]
Signed-off-by: Awais Belal <awais_belal@mentor.com>
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
lib/toaster/toastergui/buildtables.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/toaster/toastergui/buildtables.py b/lib/toaster/toastergui/buildtables.py
index dd0a690..755a7c2 100644
--- a/lib/toaster/toastergui/buildtables.py
+++ b/lib/toaster/toastergui/buildtables.py
@@ -571,6 +571,7 @@ class BuildTimeTable(BuildTasksTable):
super(BuildTimeTable, self).setup_columns(**kwargs)
self.columns[self.toggle_columns['order']]['hidden'] = True
+ self.columns[self.toggle_columns['order']]['hideable'] = True
self.columns[self.toggle_columns['sstate_result']]['hidden'] = True
self.columns[self.toggle_columns['elapsed_time']]['hidden'] = False
@@ -586,6 +587,7 @@ class BuildCPUTimeTable(BuildTasksTable):
super(BuildCPUTimeTable, self).setup_columns(**kwargs)
self.columns[self.toggle_columns['order']]['hidden'] = True
+ self.columns[self.toggle_columns['order']]['hideable'] = True
self.columns[self.toggle_columns['sstate_result']]['hidden'] = True
self.columns[self.toggle_columns['cpu_time_sys']]['hidden'] = False
self.columns[self.toggle_columns['cpu_time_user']]['hidden'] = False
@@ -602,5 +604,6 @@ class BuildIOTable(BuildTasksTable):
super(BuildIOTable, self).setup_columns(**kwargs)
self.columns[self.toggle_columns['order']]['hidden'] = True
+ self.columns[self.toggle_columns['order']]['hideable'] = True
self.columns[self.toggle_columns['sstate_result']]['hidden'] = True
self.columns[self.toggle_columns['disk_io']]['hidden'] = False
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/4] toaster: debug message for lists layers missing separators
2017-09-03 5:23 [PATCH 0/4] toaster: cummulative 30082017 patch David Reyna
2017-09-03 5:24 ` [PATCH 1/4] toaster: display error when the fstype select is empty David Reyna
2017-09-03 5:24 ` [PATCH 2/4] toaster: Order column in Tasks selectable David Reyna
@ 2017-09-03 5:24 ` David Reyna
2017-09-03 5:24 ` [PATCH 4/4] toaster: set default pokydirname if no external layers David Reyna
3 siblings, 0 replies; 5+ messages in thread
From: David Reyna @ 2017-09-03 5:24 UTC (permalink / raw)
To: bitbake-devel
From: Olaf Mandel <o.mandel@menlosystems.com>
One of the debug messages during build contains a list of all layers
but without spaces or other separators between them. Use pformat
instead.
[YOCTO #12014]
Signed-off-by: Olaf Mandel <o.mandel@menlosystems.com>
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
lib/toaster/bldcontrol/localhostbecontroller.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/toaster/bldcontrol/localhostbecontroller.py b/lib/toaster/bldcontrol/localhostbecontroller.py
index 6142f7e..a93cf40 100644
--- a/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -230,7 +230,7 @@ class LocalhostBEController(BuildEnvironmentController):
continue # not a custom recipe, skip
layerlist.extend(nongitlayerlist)
- logger.debug("\n\nset layers gives this list \n %s" % ''.join(layerlist))
+ logger.debug("\n\nset layers gives this list %s" % pformat(layerlist))
self.islayerset = True
return layerlist
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 4/4] toaster: set default pokydirname if no external layers
2017-09-03 5:23 [PATCH 0/4] toaster: cummulative 30082017 patch David Reyna
` (2 preceding siblings ...)
2017-09-03 5:24 ` [PATCH 3/4] toaster: debug message for lists layers missing separators David Reyna
@ 2017-09-03 5:24 ` David Reyna
3 siblings, 0 replies; 5+ messages in thread
From: David Reyna @ 2017-09-03 5:24 UTC (permalink / raw)
To: bitbake-devel
From: Olaf Mandel <o.mandel@menlosystems.com>
If no external layers are defined, pokydirname is not set. Rectify
this by taking the 'be.sourcedir' as the pokydirname.
[YOCTO #12015]
Signed-off-by: Olaf Mandel <o.mandel@menlosystems.com>
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
lib/toaster/bldcontrol/localhostbecontroller.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/toaster/bldcontrol/localhostbecontroller.py b/lib/toaster/bldcontrol/localhostbecontroller.py
index a93cf40..a2ca95b 100644
--- a/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -213,6 +213,10 @@ class LocalhostBEController(BuildEnvironmentController):
self.setCloneStatus(bitbake,'complete',clone_total,clone_count)
logger.debug("localhostbecontroller: current layer list %s " % pformat(layerlist))
+ if self.pokydirname is None and os.path.exists(os.path.join(self.be.sourcedir, "oe-init-build-env")):
+ logger.debug("localhostbecontroller: selected poky dir name %s" % self.be.sourcedir)
+ self.pokydirname = self.be.sourcedir
+
# 5. create custom layer and add custom recipes to it
for target in targets:
try:
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread