* [PATCH 1/3] Drivers: gpu: drm: Don't cast kzalloc() return value
2017-10-14 12:54 [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues Georgiana Chelu
@ 2017-10-14 12:54 ` Georgiana Chelu
2017-10-14 12:54 ` [PATCH 2/3] Drivers: gpu: drm: Remove useless variable Georgiana Chelu
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Georgiana Chelu @ 2017-10-14 12:54 UTC (permalink / raw)
To: outreachy-kernel
Cc: Julia Lawall, Alex Deucher, Christian König, David Airlie
The kzalloc function returns a void pointer and the assignment
operator converts it to the type of pointer it is assigned to.
Therefore, there is no need to cast.
Issue found by coccinelle script:
WARNING: casting value returned by memory allocation function
to <struct type> is useless.
Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com>
---
.../amd/powerplay/hwmgr/vega10_processpptables.c | 24 ++++++++--------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
index e343df190375..d968c3834481 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
@@ -291,8 +291,7 @@ static int get_mm_clock_voltage_table(
table_size = sizeof(uint32_t) +
sizeof(phm_ppt_v1_mm_clock_voltage_dependency_record) *
mm_dependency_table->ucNumEntries;
- mm_table = (phm_ppt_v1_mm_clock_voltage_dependency_table *)
- kzalloc(table_size, GFP_KERNEL);
+ mm_table = kzalloc(table_size, GFP_KERNEL);
if (!mm_table)
return -ENOMEM;
@@ -519,8 +518,7 @@ static int get_socclk_voltage_dependency_table(
sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
clk_dep_table->ucNumEntries;
- clk_table = (phm_ppt_v1_clock_voltage_dependency_table *)
- kzalloc(table_size, GFP_KERNEL);
+ clk_table = kzalloc(table_size, GFP_KERNEL);
if (!clk_table)
return -ENOMEM;
@@ -554,8 +552,7 @@ static int get_mclk_voltage_dependency_table(
sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
mclk_dep_table->ucNumEntries;
- mclk_table = (phm_ppt_v1_clock_voltage_dependency_table *)
- kzalloc(table_size, GFP_KERNEL);
+ mclk_table = kzalloc(table_size, GFP_KERNEL);
if (!mclk_table)
return -ENOMEM;
@@ -596,8 +593,7 @@ static int get_gfxclk_voltage_dependency_table(
sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
clk_dep_table->ucNumEntries;
- clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)
- kzalloc(table_size, GFP_KERNEL);
+ clk_table = kzalloc(table_size, GFP_KERNEL);
if (!clk_table)
return -ENOMEM;
@@ -663,8 +659,7 @@ static int get_pix_clk_voltage_dependency_table(
sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
clk_dep_table->ucNumEntries;
- clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)
- kzalloc(table_size, GFP_KERNEL);
+ clk_table = kzalloc(table_size, GFP_KERNEL);
if (!clk_table)
return -ENOMEM;
@@ -728,8 +723,7 @@ static int get_dcefclk_voltage_dependency_table(
sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
num_entries;
- clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)
- kzalloc(table_size, GFP_KERNEL);
+ clk_table = kzalloc(table_size, GFP_KERNEL);
if (!clk_table)
return -ENOMEM;
@@ -772,8 +766,7 @@ static int get_pcie_table(struct pp_hwmgr *hwmgr,
sizeof(struct phm_ppt_v1_pcie_record) *
atom_pcie_table->ucNumEntries;
- pcie_table = (struct phm_ppt_v1_pcie_table *)
- kzalloc(table_size, GFP_KERNEL);
+ pcie_table = kzalloc(table_size, GFP_KERNEL);
if (!pcie_table)
return -ENOMEM;
@@ -1026,8 +1019,7 @@ static int get_vddc_lookup_table(
table_size = sizeof(uint32_t) +
sizeof(phm_ppt_v1_voltage_lookup_record) * max_levels;
- table = (phm_ppt_v1_voltage_lookup_table *)
- kzalloc(table_size, GFP_KERNEL);
+ table = kzalloc(table_size, GFP_KERNEL);
if (NULL == table)
return -ENOMEM;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] Drivers: gpu: drm: Remove useless variable
2017-10-14 12:54 [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues Georgiana Chelu
2017-10-14 12:54 ` [PATCH 1/3] Drivers: gpu: drm: Don't cast kzalloc() return value Georgiana Chelu
@ 2017-10-14 12:54 ` Georgiana Chelu
2017-10-14 12:54 ` [PATCH 3/3] Drivers: gpu: drm: Place the constant on the right side of the test Georgiana Chelu
2017-10-16 18:39 ` [Outreachy kernel] [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues Sean Paul
3 siblings, 0 replies; 6+ messages in thread
From: Georgiana Chelu @ 2017-10-14 12:54 UTC (permalink / raw)
To: outreachy-kernel
Cc: Julia Lawall, Alex Deucher, Christian König, David Airlie
The result variable is initialized at the beginning of the function, but
its value does not change during the function execution. Thus, remove the
variable and return the SUCCESS value, which is 0.
Issue found by coccinelle script:
* Unneeded variable: "result". Return "0"
Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
index d968c3834481..769ac11a9215 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
@@ -1174,7 +1174,6 @@ int vega10_pp_tables_initialize(struct pp_hwmgr *hwmgr)
static int vega10_pp_tables_uninitialize(struct pp_hwmgr *hwmgr)
{
- int result = 0;
struct phm_ppt_v2_information *pp_table_info =
(struct phm_ppt_v2_information *)(hwmgr->pptable);
@@ -1217,7 +1216,7 @@ static int vega10_pp_tables_uninitialize(struct pp_hwmgr *hwmgr)
kfree(hwmgr->pptable);
hwmgr->pptable = NULL;
- return result;
+ return 0;
}
const struct pp_table_func vega10_pptable_funcs = {
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] Drivers: gpu: drm: Place the constant on the right side of the test
2017-10-14 12:54 [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues Georgiana Chelu
2017-10-14 12:54 ` [PATCH 1/3] Drivers: gpu: drm: Don't cast kzalloc() return value Georgiana Chelu
2017-10-14 12:54 ` [PATCH 2/3] Drivers: gpu: drm: Remove useless variable Georgiana Chelu
@ 2017-10-14 12:54 ` Georgiana Chelu
2017-10-16 18:39 ` [Outreachy kernel] [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues Sean Paul
3 siblings, 0 replies; 6+ messages in thread
From: Georgiana Chelu @ 2017-10-14 12:54 UTC (permalink / raw)
To: outreachy-kernel
Cc: Julia Lawall, Alex Deucher, Christian König, David Airlie
Move the constant on the right side of the comparison in order to
make the code easier to read.
Issue found by checkpatch script:
* WARNING: Comparisons should place the constant on the right side of
the test
Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
index 769ac11a9215..f14c7611fad3 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
@@ -1021,7 +1021,7 @@ static int get_vddc_lookup_table(
table = kzalloc(table_size, GFP_KERNEL);
- if (NULL == table)
+ if (table == NULL)
return -ENOMEM;
table->count = vddc_lookup_pp_tables->ucNumEntries;
@@ -1130,12 +1130,12 @@ int vega10_pp_tables_initialize(struct pp_hwmgr *hwmgr)
hwmgr->pptable = kzalloc(sizeof(struct phm_ppt_v2_information), GFP_KERNEL);
- PP_ASSERT_WITH_CODE((NULL != hwmgr->pptable),
+ PP_ASSERT_WITH_CODE((hwmgr->pptable != NULL),
"Failed to allocate hwmgr->pptable!", return -ENOMEM);
powerplay_table = get_powerplay_table(hwmgr);
- PP_ASSERT_WITH_CODE((NULL != powerplay_table),
+ PP_ASSERT_WITH_CODE((powerplay_table != NULL),
"Missing PowerPlay Table!", return -1);
result = check_powerplay_tables(hwmgr, powerplay_table);
@@ -1229,7 +1229,7 @@ int vega10_get_number_of_powerplay_table_entries(struct pp_hwmgr *hwmgr)
const ATOM_Vega10_State_Array *state_arrays;
const ATOM_Vega10_POWERPLAYTABLE *pp_table = get_powerplay_table(hwmgr);
- PP_ASSERT_WITH_CODE((NULL != pp_table),
+ PP_ASSERT_WITH_CODE((pp_table != NULL),
"Missing PowerPlay Table!", return -1);
PP_ASSERT_WITH_CODE((pp_table->sHeader.format_revision >=
ATOM_Vega10_TABLE_REVISION_VEGA10),
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues
2017-10-14 12:54 [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues Georgiana Chelu
` (2 preceding siblings ...)
2017-10-14 12:54 ` [PATCH 3/3] Drivers: gpu: drm: Place the constant on the right side of the test Georgiana Chelu
@ 2017-10-16 18:39 ` Sean Paul
2017-10-17 20:21 ` Georgiana Chelu
3 siblings, 1 reply; 6+ messages in thread
From: Sean Paul @ 2017-10-16 18:39 UTC (permalink / raw)
To: Georgiana Chelu
Cc: outreachy-kernel, Julia Lawall, Alex Deucher,
Christian König, David Airlie
On Sat, Oct 14, 2017 at 8:54 AM, Georgiana Chelu
<georgiana.chelu93@gmail.com> wrote:
> The first two patches fix coccinelle issues and the last patch fix
> a checkpatch issue.
>
> First patch: The return value of kzalloc does not need a cast because
> the assignment operator will take care of this.
>
> Second patch: The 'result' variable does not change its value until the
> end of the function. Instead of using the variable, return its default value.
>
> Third patch: Placing the constant on the right side will make the code easier
> to read, as most of the people read from right to left.
>
> Georgiana Chelu (3):
> Drivers: gpu: drm: Don't cast kzalloc() return value
> Drivers: gpu: drm: Remove useless variable
> Drivers: gpu: drm: Place the constant on the right side of the test
>
Hi Georgiana,
Thank you for your patches.
A couple things:
- Please look at git log for the file(s) you're changing when choosing
your subject prefix. In this instance, it should be
"drm/amd/powerplay:"
- Please cc dri-devel@lists.freedesktop.org on drm patches
- Please post the cocci script or the path to it when submitting
cocci-generated patches.
I look forward to your v2!
Sean
> .../amd/powerplay/hwmgr/vega10_processpptables.c | 35 ++++++++--------------
> 1 file changed, 13 insertions(+), 22 deletions(-)
>
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1507985001.git.georgiana.chelu93%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Outreachy kernel] [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues
2017-10-16 18:39 ` [Outreachy kernel] [PATCH 0/3] Drivers: gpu: drm: Fix coccinelle and checkpatch issues Sean Paul
@ 2017-10-17 20:21 ` Georgiana Chelu
0 siblings, 0 replies; 6+ messages in thread
From: Georgiana Chelu @ 2017-10-17 20:21 UTC (permalink / raw)
To: Sean Paul
Cc: outreachy-kernel, Julia Lawall, Alex Deucher,
Christian König, David Airlie
On 16 October 2017 at 21:39, Sean Paul <seanpaul@chromium.org> wrote:
> On Sat, Oct 14, 2017 at 8:54 AM, Georgiana Chelu
> <georgiana.chelu93@gmail.com> wrote:
>> The first two patches fix coccinelle issues and the last patch fix
>> a checkpatch issue.
>>
>> First patch: The return value of kzalloc does not need a cast because
>> the assignment operator will take care of this.
>>
>> Second patch: The 'result' variable does not change its value until the
>> end of the function. Instead of using the variable, return its default value.
>>
>> Third patch: Placing the constant on the right side will make the code easier
>> to read, as most of the people read from right to left.
>>
>> Georgiana Chelu (3):
>> Drivers: gpu: drm: Don't cast kzalloc() return value
>> Drivers: gpu: drm: Remove useless variable
>> Drivers: gpu: drm: Place the constant on the right side of the test
>>
>
> Hi Georgiana,
> Thank you for your patches.
>
> A couple things:
> - Please look at git log for the file(s) you're changing when choosing
> your subject prefix. In this instance, it should be
> "drm/amd/powerplay:"
> - Please cc dri-devel@lists.freedesktop.org on drm patches
> - Please post the cocci script or the path to it when submitting
> cocci-generated patches.
>
> I look forward to your v2!
>
Hi Sean,
Thank you for the review! I will resend the patches soon.
Georgiana
> Sean
>
>
>> .../amd/powerplay/hwmgr/vega10_processpptables.c | 35 ++++++++--------------
>> 1 file changed, 13 insertions(+), 22 deletions(-)
>>
>> --
>> 2.11.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1507985001.git.georgiana.chelu93%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread