[PATCH 0/3] irqchip: pr_err() strings should end with newlines

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/3] irqchip:  pr_err() strings should end with newlines
@ 2017-11-13 13:53 ` Arvind Yadav
  0 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: tglx, jason, marc.zyngier, kgene, krzk
  Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Arvind Yadav (3):
  [PATCH 1/3] irqchip/mips-gic:  pr_err() strings should end with newlines
  [PATCH 2/3] irqchip/s3c24xx:  pr_err() strings should end with newlines
  [PATCH 3/3] irqchip/gic-v3:  pr_err() strings should end with newlines

 drivers/irqchip/irq-gic-v3.c   | 2 +-
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 drivers/irqchip/irq-s3c24xx.c  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 0/3] irqchip:  pr_err() strings should end with newlines
@ 2017-11-13 13:53 ` Arvind Yadav
  0 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: linux-arm-kernel

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Arvind Yadav (3):
  [PATCH 1/3] irqchip/mips-gic:  pr_err() strings should end with newlines
  [PATCH 2/3] irqchip/s3c24xx:  pr_err() strings should end with newlines
  [PATCH 3/3] irqchip/gic-v3:  pr_err() strings should end with newlines

 drivers/irqchip/irq-gic-v3.c   | 2 +-
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 drivers/irqchip/irq-s3c24xx.c  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 1/3] irqchip/mips-gic:  pr_err() strings should end with newlines
  2017-11-13 13:53 ` Arvind Yadav
@ 2017-11-13 13:53   ` Arvind Yadav
  -1 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: tglx, jason, marc.zyngier, kgene, krzk
  Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index c90976d..e87d33b 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
 					       gic_shared_intrs, 0,
 					       &gic_irq_domain_ops, NULL);
 	if (!gic_irq_domain) {
-		pr_err("Failed to add GIC IRQ domain");
+		pr_err("Failed to add GIC IRQ domain\n");
 		return -ENXIO;
 	}
 
@@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
 						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
 						  node, &gic_ipi_domain_ops, NULL);
 	if (!gic_ipi_domain) {
-		pr_err("Failed to add GIC IPI domain");
+		pr_err("Failed to add GIC IPI domain\n");
 		return -ENXIO;
 	}
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with newlines
@ 2017-11-13 13:53   ` Arvind Yadav
  0 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: linux-arm-kernel

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index c90976d..e87d33b 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
 					       gic_shared_intrs, 0,
 					       &gic_irq_domain_ops, NULL);
 	if (!gic_irq_domain) {
-		pr_err("Failed to add GIC IRQ domain");
+		pr_err("Failed to add GIC IRQ domain\n");
 		return -ENXIO;
 	}
 
@@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
 						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
 						  node, &gic_ipi_domain_ops, NULL);
 	if (!gic_ipi_domain) {
-		pr_err("Failed to add GIC IPI domain");
+		pr_err("Failed to add GIC IPI domain\n");
 		return -ENXIO;
 	}
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with newlines
  2017-11-13 13:53   ` Arvind Yadav
@ 2017-11-13 14:39     ` Marc Zyngier
  -1 siblings, 0 replies; 11+ messages in thread
From: Marc Zyngier @ 2017-11-13 14:39 UTC (permalink / raw)
  To: Arvind Yadav, tglx, jason, kgene, krzk
  Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc

On 13/11/17 13:53, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/irqchip/irq-mips-gic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index c90976d..e87d33b 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
>  					       gic_shared_intrs, 0,
>  					       &gic_irq_domain_ops, NULL);
>  	if (!gic_irq_domain) {
> -		pr_err("Failed to add GIC IRQ domain");
> +		pr_err("Failed to add GIC IRQ domain\n");
>  		return -ENXIO;
>  	}
>  
> @@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
>  						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
>  						  node, &gic_ipi_domain_ops, NULL);
>  	if (!gic_ipi_domain) {
> -		pr_err("Failed to add GIC IPI domain");
> +		pr_err("Failed to add GIC IPI domain\n");
>  		return -ENXIO;
>  	}
>  
> 

This patch doesn't apply to the current state of the irqchip tree, nor
of tip/irq/core. Please verify that it applies and resubmit if required.

I've applied patches 2 and 3.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with newlines
@ 2017-11-13 14:39     ` Marc Zyngier
  0 siblings, 0 replies; 11+ messages in thread
From: Marc Zyngier @ 2017-11-13 14:39 UTC (permalink / raw)
  To: linux-arm-kernel

On 13/11/17 13:53, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/irqchip/irq-mips-gic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index c90976d..e87d33b 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
>  					       gic_shared_intrs, 0,
>  					       &gic_irq_domain_ops, NULL);
>  	if (!gic_irq_domain) {
> -		pr_err("Failed to add GIC IRQ domain");
> +		pr_err("Failed to add GIC IRQ domain\n");
>  		return -ENXIO;
>  	}
>  
> @@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
>  						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
>  						  node, &gic_ipi_domain_ops, NULL);
>  	if (!gic_ipi_domain) {
> -		pr_err("Failed to add GIC IPI domain");
> +		pr_err("Failed to add GIC IPI domain\n");
>  		return -ENXIO;
>  	}
>  
> 

This patch doesn't apply to the current state of the irqchip tree, nor
of tip/irq/core. Please verify that it applies and resubmit if required.

I've applied patches 2 and 3.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 2/3] irqchip/s3c24xx:  pr_err() strings should end with newlines
  2017-11-13 13:53 ` Arvind Yadav
@ 2017-11-13 13:53   ` Arvind Yadav
  -1 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: tglx, jason, marc.zyngier, kgene, krzk
  Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-s3c24xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
index c25ce5a..ec0e6a8 100644
--- a/drivers/irqchip/irq-s3c24xx.c
+++ b/drivers/irqchip/irq-s3c24xx.c
@@ -156,7 +156,7 @@ static int s3c_irq_type(struct irq_data *data, unsigned int type)
 		irq_set_handler(data->irq, handle_level_irq);
 		break;
 	default:
-		pr_err("No such irq type %d", type);
+		pr_err("No such irq type %d\n", type);
 		return -EINVAL;
 	}
 
@@ -204,7 +204,7 @@ static int s3c_irqext_type_set(void __iomem *gpcon_reg,
 			break;
 
 		default:
-			pr_err("No such irq type %d", type);
+			pr_err("No such irq type %d\n", type);
 			return -EINVAL;
 	}
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/3] irqchip/s3c24xx: pr_err() strings should end with newlines
@ 2017-11-13 13:53   ` Arvind Yadav
  0 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: linux-arm-kernel

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-s3c24xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
index c25ce5a..ec0e6a8 100644
--- a/drivers/irqchip/irq-s3c24xx.c
+++ b/drivers/irqchip/irq-s3c24xx.c
@@ -156,7 +156,7 @@ static int s3c_irq_type(struct irq_data *data, unsigned int type)
 		irq_set_handler(data->irq, handle_level_irq);
 		break;
 	default:
-		pr_err("No such irq type %d", type);
+		pr_err("No such irq type %d\n", type);
 		return -EINVAL;
 	}
 
@@ -204,7 +204,7 @@ static int s3c_irqext_type_set(void __iomem *gpcon_reg,
 			break;
 
 		default:
-			pr_err("No such irq type %d", type);
+			pr_err("No such irq type %d\n", type);
 			return -EINVAL;
 	}
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/3] irqchip/gic-v3: pr_err() strings should end with newlines
  2017-11-13 13:53 ` Arvind Yadav
  (?)
@ 2017-11-13 13:53   ` Arvind Yadav
  -1 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: tglx, jason, marc.zyngier, kgene, krzk
  Cc: linux-samsung-soc, linux-kernel, linux-arm-kernel

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index b5df99c..252fb0c 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1489,7 +1489,7 @@ static void __init gic_acpi_setup_kvm_info(void)
 
 	err = gic_validate_dist_version(acpi_data.dist_base);
 	if (err) {
-		pr_err("No distributor detected at @%p, giving up",
+		pr_err("No distributor detected at @%p, giving up\n",
 		       acpi_data.dist_base);
 		goto out_dist_unmap;
 	}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/3] irqchip/gic-v3:  pr_err() strings should end with newlines
@ 2017-11-13 13:53   ` Arvind Yadav
  0 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: tglx, jason, marc.zyngier, kgene, krzk
  Cc: linux-kernel, linux-arm-kernel, linux-samsung-soc

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index b5df99c..252fb0c 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1489,7 +1489,7 @@ static void __init gic_acpi_setup_kvm_info(void)
 
 	err = gic_validate_dist_version(acpi_data.dist_base);
 	if (err) {
-		pr_err("No distributor detected at @%p, giving up",
+		pr_err("No distributor detected at @%p, giving up\n",
 		       acpi_data.dist_base);
 		goto out_dist_unmap;
 	}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/3] irqchip/gic-v3: pr_err() strings should end with newlines
@ 2017-11-13 13:53   ` Arvind Yadav
  0 siblings, 0 replies; 11+ messages in thread
From: Arvind Yadav @ 2017-11-13 13:53 UTC (permalink / raw)
  To: linux-arm-kernel

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index b5df99c..252fb0c 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1489,7 +1489,7 @@ static void __init gic_acpi_setup_kvm_info(void)
 
 	err = gic_validate_dist_version(acpi_data.dist_base);
 	if (err) {
-		pr_err("No distributor detected at @%p, giving up",
+		pr_err("No distributor detected at @%p, giving up\n",
 		       acpi_data.dist_base);
 		goto out_dist_unmap;
 	}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-11-13 14:39 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-13 13:53 [PATCH 0/3] irqchip: pr_err() strings should end with newlines Arvind Yadav
2017-11-13 13:53 ` Arvind Yadav
2017-11-13 13:53 ` [PATCH 1/3] irqchip/mips-gic: " Arvind Yadav
2017-11-13 13:53   ` Arvind Yadav
2017-11-13 14:39   ` Marc Zyngier
2017-11-13 14:39     ` Marc Zyngier
2017-11-13 13:53 ` [PATCH 2/3] irqchip/s3c24xx: " Arvind Yadav
2017-11-13 13:53   ` Arvind Yadav
2017-11-13 13:53 ` [PATCH 3/3] irqchip/gic-v3: " Arvind Yadav
2017-11-13 13:53   ` Arvind Yadav
2017-11-13 13:53   ` Arvind Yadav

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.