* [PATCH v2 1/3] staging: lustre: obdclass: Fix comparison to NULL
2018-03-04 9:09 [PATCH v2 0/3] Cleanup for staging lustre obdclass Dafna Hirschfeld
@ 2018-03-04 9:09 ` Dafna Hirschfeld
2018-03-04 19:04 ` [Outreachy kernel] " Julia Lawall
2018-03-04 9:09 ` [PATCH v2 2/3] staging: lustre: obdclass: Add 'const' to char* array Dafna Hirschfeld
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Dafna Hirschfeld @ 2018-03-04 9:09 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, jsimmons, gregkh
Cc: Dafna Hirschfeld, outreachy-kernel
Replace comparison to NULL with a 'not' operator.
Issue found with checkpatch.
Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index e1f4ef2..64cc746 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1585,7 +1585,7 @@ int ldebugfs_seq_create(struct dentry *parent, const char *name,
struct dentry *entry;
/* Disallow secretly (un)writable entries. */
- LASSERT((seq_fops->write == NULL) == ((mode & 0222) == 0));
+ LASSERT((!seq_fops->write) == ((mode & 0222) == 0));
entry = debugfs_create_file(name, mode, parent, data, seq_fops);
if (IS_ERR_OR_NULL(entry))
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Outreachy kernel] [PATCH v2 1/3] staging: lustre: obdclass: Fix comparison to NULL
2018-03-04 9:09 ` [PATCH v2 1/3] staging: lustre: obdclass: Fix comparison to NULL Dafna Hirschfeld
@ 2018-03-04 19:04 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2018-03-04 19:04 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: oleg.drokin, andreas.dilger, jsimmons, gregkh, outreachy-kernel
On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:
> Replace comparison to NULL with a 'not' operator.
> Issue found with checkpatch.
>
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> index e1f4ef2..64cc746 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> @@ -1585,7 +1585,7 @@ int ldebugfs_seq_create(struct dentry *parent, const char *name,
> struct dentry *entry;
>
> /* Disallow secretly (un)writable entries. */
> - LASSERT((seq_fops->write == NULL) == ((mode & 0222) == 0));
> + LASSERT((!seq_fops->write) == ((mode & 0222) == 0));
! actually binds more tightly than ==, but I think that keeping the
parentheses is helpful for clarity.
julia
>
> entry = debugfs_create_file(name, mode, parent, data, seq_fops);
> if (IS_ERR_OR_NULL(entry))
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2af5f92fecc211d04770d19600874f3345f97200.1520153895.git.dafna3%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/3] staging: lustre: obdclass: Add 'const' to char* array
2018-03-04 9:09 [PATCH v2 0/3] Cleanup for staging lustre obdclass Dafna Hirschfeld
2018-03-04 9:09 ` [PATCH v2 1/3] staging: lustre: obdclass: Fix comparison to NULL Dafna Hirschfeld
@ 2018-03-04 9:09 ` Dafna Hirschfeld
2018-03-04 9:09 ` [PATCH v2 3/3] staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int' Dafna Hirschfeld
2018-03-04 19:05 ` [Outreachy kernel] [PATCH v2 0/3] Cleanup for staging lustre obdclass Julia Lawall
3 siblings, 0 replies; 8+ messages in thread
From: Dafna Hirschfeld @ 2018-03-04 9:09 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, jsimmons, gregkh
Cc: Dafna Hirschfeld, outreachy-kernel
Replace 'const char*' arrays with 'const char * const'
since the values in the arrays are not changed.
Issues found with checkpatch.pl
Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +-
drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
index 3b683b7..9ca29a2 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
@@ -224,7 +224,7 @@ EXPORT_SYMBOL(cl_lock_release);
const char *cl_lock_mode_name(const enum cl_lock_mode mode)
{
- static const char *names[] = {
+ static const char * const names[] = {
[CLM_READ] = "R",
[CLM_WRITE] = "W",
[CLM_GROUP] = "G"
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index 7b18d77..7809f6a 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -495,7 +495,7 @@ static struct cache_stats cl_env_stats = {
int cl_site_stats_print(const struct cl_site *site, struct seq_file *m)
{
size_t i;
- static const char *pstate[] = {
+ static const char * const pstate[] = {
[CPS_CACHED] = "c",
[CPS_OWNED] = "o",
[CPS_PAGEOUT] = "w",
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 3/3] staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int'
2018-03-04 9:09 [PATCH v2 0/3] Cleanup for staging lustre obdclass Dafna Hirschfeld
2018-03-04 9:09 ` [PATCH v2 1/3] staging: lustre: obdclass: Fix comparison to NULL Dafna Hirschfeld
2018-03-04 9:09 ` [PATCH v2 2/3] staging: lustre: obdclass: Add 'const' to char* array Dafna Hirschfeld
@ 2018-03-04 9:09 ` Dafna Hirschfeld
2018-03-04 19:05 ` [Outreachy kernel] [PATCH v2 0/3] Cleanup for staging lustre obdclass Julia Lawall
3 siblings, 0 replies; 8+ messages in thread
From: Dafna Hirschfeld @ 2018-03-04 9:09 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, jsimmons, gregkh
Cc: Dafna Hirschfeld, outreachy-kernel
Replace 'unsigned' with 'unsigned int' to improve readability.
Issues found with checkpatch.pl
Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
drivers/staging/lustre/lustre/obdclass/lu_object.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 64cc746..2ed3505 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1467,7 +1467,7 @@ int lprocfs_write_frac_u64_helper(const char __user *buffer,
{
char kernbuf[22], *end, *pbuf;
__u64 whole, frac = 0, units;
- unsigned frac_d = 1;
+ unsigned int frac_d = 1;
int sign = 1;
if (count > (sizeof(kernbuf) - 1))
diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
index cca6881..964e854 100644
--- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
@@ -1797,10 +1797,10 @@ int lu_env_refill(struct lu_env *env)
EXPORT_SYMBOL(lu_env_refill);
struct lu_site_stats {
- unsigned lss_populated;
- unsigned lss_max_search;
- unsigned lss_total;
- unsigned lss_busy;
+ unsigned int lss_populated;
+ unsigned int lss_max_search;
+ unsigned int lss_total;
+ unsigned int lss_busy;
};
static void lu_site_stats_get(struct cfs_hash *hs,
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Outreachy kernel] [PATCH v2 0/3] Cleanup for staging lustre obdclass
2018-03-04 9:09 [PATCH v2 0/3] Cleanup for staging lustre obdclass Dafna Hirschfeld
` (2 preceding siblings ...)
2018-03-04 9:09 ` [PATCH v2 3/3] staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int' Dafna Hirschfeld
@ 2018-03-04 19:05 ` Julia Lawall
2018-03-04 19:37 ` Dafna Hirschfeld
3 siblings, 1 reply; 8+ messages in thread
From: Julia Lawall @ 2018-03-04 19:05 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: oleg.drokin, andreas.dilger, jsimmons, gregkh, outreachy-kernel
On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:
> Fixes of issues found with checkpatch.pl for the lustre obdclass driver.
>
> Changes in v2:
> patch 1:
> 1. Revert moving the constant to the right side of comparisons
> in order to keep the condition in the form of
> 'lower bound <= val && val <= upper bound'
>
> 2. Revert returning '!!ptr' instead of 'ptr != NULL' since this is
> not part of an 'if' statement.
>
> patches 2+3:
> No Change.
I think I acked these two. You should keep the ack in the resubmission.
julia
>
> Dafna Hirschfeld (3):
> staging: lustre: obdclass: Fix comparison to NULL
> staging: lustre: obdclass: Add 'const' to char* array
> staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int'
>
> drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +-
> drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++--
> drivers/staging/lustre/lustre/obdclass/lu_object.c | 8 ++++----
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1520153895.git.dafna3%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Outreachy kernel] [PATCH v2 0/3] Cleanup for staging lustre obdclass
2018-03-04 19:05 ` [Outreachy kernel] [PATCH v2 0/3] Cleanup for staging lustre obdclass Julia Lawall
@ 2018-03-04 19:37 ` Dafna Hirschfeld
2018-03-04 19:38 ` Julia Lawall
0 siblings, 1 reply; 8+ messages in thread
From: Dafna Hirschfeld @ 2018-03-04 19:37 UTC (permalink / raw)
To: Julia Lawall
Cc: oleg.drokin, andreas.dilger, jsimmons, gregkh, outreachy-kernel
On Sun, Mar 4, 2018 at 9:05 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:
>
>> Fixes of issues found with checkpatch.pl for the lustre obdclass driver.
>>
>> Changes in v2:
>> patch 1:
>> 1. Revert moving the constant to the right side of comparisons
>> in order to keep the condition in the form of
>> 'lower bound <= val && val <= upper bound'
>>
>> 2. Revert returning '!!ptr' instead of 'ptr != NULL' since this is
>> not part of an 'if' statement.
>>
>> patches 2+3:
>> No Change.
>
> I think I acked these two. You should keep the ack in the resubmission.
>
> julia
>
Hi, you did ack, shell I send another version with your acks ?
>>
>> Dafna Hirschfeld (3):
>> staging: lustre: obdclass: Fix comparison to NULL
>> staging: lustre: obdclass: Add 'const' to char* array
>> staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int'
>>
>> drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +-
>> drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
>> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++--
>> drivers/staging/lustre/lustre/obdclass/lu_object.c | 8 ++++----
>> 4 files changed, 8 insertions(+), 8 deletions(-)
>>
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1520153895.git.dafna3%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 0/3] Cleanup for staging lustre obdclass
2018-03-04 19:37 ` Dafna Hirschfeld
@ 2018-03-04 19:38 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2018-03-04 19:38 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: oleg.drokin, andreas.dilger, jsimmons, gregkh, outreachy-kernel
On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:
> On Sun, Mar 4, 2018 at 9:05 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:
> >
> >> Fixes of issues found with checkpatch.pl for the lustre obdclass driver.
> >>
> >> Changes in v2:
> >> patch 1:
> >> 1. Revert moving the constant to the right side of comparisons
> >> in order to keep the condition in the form of
> >> 'lower bound <= val && val <= upper bound'
> >>
> >> 2. Revert returning '!!ptr' instead of 'ptr != NULL' since this is
> >> not part of an 'if' statement.
> >>
> >> patches 2+3:
> >> No Change.
> >
> > I think I acked these two. You should keep the ack in the resubmission.
> >
> > julia
> >
> Hi, you did ack, shell I send another version with your acks ?
Sure. Thanks.
julia
>
> >>
> >> Dafna Hirschfeld (3):
> >> staging: lustre: obdclass: Fix comparison to NULL
> >> staging: lustre: obdclass: Add 'const' to char* array
> >> staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int'
> >>
> >> drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +-
> >> drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
> >> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++--
> >> drivers/staging/lustre/lustre/obdclass/lu_object.c | 8 ++++----
> >> 4 files changed, 8 insertions(+), 8 deletions(-)
> >>
> >> --
> >> 2.7.4
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1520153895.git.dafna3%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAJ1myNQ4EL6od8MOEh7JpoFUr6fKS7bwvcS0P8QDP5fDc4nCew%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 8+ messages in thread