From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Xin Long <lucien.xin@gmail.com>
Subject: [PATCH net-next 00/13] sctp: refactor MTU handling
Date: Thu, 26 Apr 2018 19:58:49 +0000 [thread overview]
Message-ID: <cover.1524772453.git.marcelo.leitner@gmail.com> (raw)
Currently MTU handling is spread over SCTP stack. There are multiple
places doing same/similar calculations and updating them is error prone
as one spot can easily be left out.
This patchset converges it into a more concise and consistent code. In
general, it moves MTU handling from functions with bigger objectives,
such as sctp_assoc_add_peer(), to specific functions.
It's also a preparation for the next patchset, which removes the
duplication between sctp_make_op_error_space and
sctp_make_op_error_fixed and relies on sctp_mtu_payload introduced here.
More details on each patch.
Marcelo Ricardo Leitner (13):
sctp: remove old and unused SCTP_MIN_PMTU
sctp: move transport pathmtu calc away of sctp_assoc_add_peer
sctp: remove an if() that is always true
sctp: introduce sctp_assoc_set_pmtu
sctp: introduce sctp_mtu_payload
sctp: introduce sctp_assoc_update_frag_point
sctp: remove sctp_assoc_pending_pmtu
sctp: introduce sctp_dst_mtu
sctp: remove sctp_transport_pmtu_check
sctp: re-use sctp_transport_pmtu in sctp_transport_route
sctp: honor PMTU_DISABLED when handling icmp
sctp: consider idata chunks when setting SCTP_MAXSEG
sctp: allow unsetting sockopt MAXSEG
include/net/sctp/constants.h | 5 ++--
include/net/sctp/sctp.h | 52 ++++++++++++++------------------------
include/net/sctp/structs.h | 2 ++
net/sctp/associola.c | 60 +++++++++++++++++++++++---------------------
net/sctp/chunk.c | 12 +--------
net/sctp/output.c | 28 ++++++++-------------
net/sctp/socket.c | 43 ++++++++++++++-----------------
net/sctp/transport.c | 37 ++++++++++++++-------------
8 files changed, 105 insertions(+), 134 deletions(-)
--
2.14.3
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Xin Long <lucien.xin@gmail.com>
Subject: [PATCH net-next 00/13] sctp: refactor MTU handling
Date: Thu, 26 Apr 2018 16:58:49 -0300 [thread overview]
Message-ID: <cover.1524772453.git.marcelo.leitner@gmail.com> (raw)
Currently MTU handling is spread over SCTP stack. There are multiple
places doing same/similar calculations and updating them is error prone
as one spot can easily be left out.
This patchset converges it into a more concise and consistent code. In
general, it moves MTU handling from functions with bigger objectives,
such as sctp_assoc_add_peer(), to specific functions.
It's also a preparation for the next patchset, which removes the
duplication between sctp_make_op_error_space and
sctp_make_op_error_fixed and relies on sctp_mtu_payload introduced here.
More details on each patch.
Marcelo Ricardo Leitner (13):
sctp: remove old and unused SCTP_MIN_PMTU
sctp: move transport pathmtu calc away of sctp_assoc_add_peer
sctp: remove an if() that is always true
sctp: introduce sctp_assoc_set_pmtu
sctp: introduce sctp_mtu_payload
sctp: introduce sctp_assoc_update_frag_point
sctp: remove sctp_assoc_pending_pmtu
sctp: introduce sctp_dst_mtu
sctp: remove sctp_transport_pmtu_check
sctp: re-use sctp_transport_pmtu in sctp_transport_route
sctp: honor PMTU_DISABLED when handling icmp
sctp: consider idata chunks when setting SCTP_MAXSEG
sctp: allow unsetting sockopt MAXSEG
include/net/sctp/constants.h | 5 ++--
include/net/sctp/sctp.h | 52 ++++++++++++++------------------------
include/net/sctp/structs.h | 2 ++
net/sctp/associola.c | 60 +++++++++++++++++++++++---------------------
net/sctp/chunk.c | 12 +--------
net/sctp/output.c | 28 ++++++++-------------
net/sctp/socket.c | 43 ++++++++++++++-----------------
net/sctp/transport.c | 37 ++++++++++++++-------------
8 files changed, 105 insertions(+), 134 deletions(-)
next reply other threads:[~2018-04-26 19:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 19:58 Marcelo Ricardo Leitner [this message]
2018-04-26 19:58 ` [PATCH net-next 00/13] sctp: refactor MTU handling Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 01/13] sctp: remove old and unused SCTP_MIN_PMTU Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 02/13] sctp: move transport pathmtu calc away of sctp_assoc_add_peer Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 03/13] sctp: remove an if() that is always true Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-27 10:50 ` Neil Horman
2018-04-27 10:50 ` Neil Horman
2018-04-27 18:13 ` Marcelo Ricardo Leitner
2018-04-27 18:13 ` Marcelo Ricardo Leitner
2018-04-27 19:03 ` Neil Horman
2018-04-27 19:03 ` Neil Horman
2018-04-26 19:58 ` [PATCH net-next 04/13] sctp: introduce sctp_assoc_set_pmtu Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 05/13] sctp: introduce sctp_mtu_payload Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 06/13] sctp: introduce sctp_assoc_update_frag_point Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 07/13] sctp: remove sctp_assoc_pending_pmtu Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 08/13] sctp: introduce sctp_dst_mtu Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 09/13] sctp: remove sctp_transport_pmtu_check Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:58 ` [PATCH net-next 10/13] sctp: re-use sctp_transport_pmtu in sctp_transport_route Marcelo Ricardo Leitner
2018-04-26 19:58 ` Marcelo Ricardo Leitner
2018-04-26 19:59 ` [PATCH net-next 11/13] sctp: honor PMTU_DISABLED when handling icmp Marcelo Ricardo Leitner
2018-04-26 19:59 ` Marcelo Ricardo Leitner
2018-04-26 19:59 ` [PATCH net-next 12/13] sctp: consider idata chunks when setting SCTP_MAXSEG Marcelo Ricardo Leitner
2018-04-26 19:59 ` Marcelo Ricardo Leitner
2018-04-26 19:59 ` [PATCH net-next 13/13] sctp: allow unsetting sockopt MAXSEG Marcelo Ricardo Leitner
2018-04-26 19:59 ` Marcelo Ricardo Leitner
2018-04-27 10:04 ` [PATCH net-next 00/13] sctp: refactor MTU handling Xin Long
2018-04-27 10:04 ` Xin Long
2018-04-27 18:42 ` David Miller
2018-04-27 18:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1524772453.git.marcelo.leitner@gmail.com \
--to=marcelo.leitner@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.