* [PATCH 1/2] staging: netlogic: replace old kconfig with new syntax
2018-10-21 21:08 [PATCH 1/2] staging: netlogic Ioannis Valasakis
@ 2018-10-21 20:15 ` Ioannis Valasakis
2018-10-21 20:15 ` [PATCH 2/2] staging: netlogic: Cleanup parenetheses Ioannis Valasakis
2018-10-21 22:14 ` [Outreachy kernel] [PATCH 1/2] staging: netlogic Julia Lawall
2 siblings, 0 replies; 5+ messages in thread
From: Ioannis Valasakis @ 2018-10-21 20:15 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
KConfig prefers the help macro instead of the old slashed one.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/netlogic/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging/netlogic/Kconfig
index d660de51b541..c25a00dd2d5f 100644
--- a/drivers/staging/netlogic/Kconfig
+++ b/drivers/staging/netlogic/Kconfig
@@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET
tristate "Netlogic XLR/XLS network device"
depends on CPU_XLR
select PHYLIB
- ---help---
+ help
This driver support Netlogic XLR/XLS on chip gigabit
Ethernet.
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] staging: netlogic: Cleanup parenetheses
2018-10-21 21:08 [PATCH 1/2] staging: netlogic Ioannis Valasakis
2018-10-21 20:15 ` [PATCH 1/2] staging: netlogic: replace old kconfig with new syntax Ioannis Valasakis
@ 2018-10-21 20:15 ` Ioannis Valasakis
2018-10-21 22:14 ` [Outreachy kernel] " Julia Lawall
2018-10-21 22:14 ` [Outreachy kernel] [PATCH 1/2] staging: netlogic Julia Lawall
2 siblings, 1 reply; 5+ messages in thread
From: Ioannis Valasakis @ 2018-10-21 20:15 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Cleanup mismatching parentheses.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/netlogic/platform_net.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index abf4c71ee66b..1b1a8a0c9b72 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -107,8 +107,8 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
.dev.platform_data = &ndata1,
};
- gmac4_addr = ioremap(CPHYSADDR(
- nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);
+ gmac5_addr = ioremap(CPHYSADDR
+ (nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);
ndata1.serdes_addr = gmac4_addr;
ndata1.pcs_addr = gmac4_addr;
ndata1.mii_addr = gmac0_addr;
@@ -134,8 +134,8 @@ static void xls_gmac_init(void)
{
int mac;
struct platform_device *xlr_net_dev1;
- void __iomem *gmac0_addr = ioremap(CPHYSADDR(
- nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
+ void __iomem *gmac0_addr = ioremap(CPHYSADDR
+ (nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
static struct xlr_net_data ndata0 = {
.rfr_station = FMN_STNID_GMACRFR_0,
@@ -153,8 +153,8 @@ static void xls_gmac_init(void)
ndata0.mii_addr = gmac0_addr;
/* Passing GPIO base for serdes init. Only needed on sgmii ports */
- gpio_addr = ioremap(CPHYSADDR(
- nlm_mmio_base(NETLOGIC_IO_GPIO_OFFSET)), 0xfff);
+ gpio_addr = ioremap(CPHYSADDR
+ (nlm_mmio_base(NETLOGIC_IO_GPIO_OFFSET)), 0xfff);
ndata0.gpio_addr = gpio_addr;
ndata0.cpu_mask = nlm_current_node()->coremask;
@@ -214,8 +214,8 @@ static void xlr_gmac_init(void)
.id = 0,
.dev.platform_data = &ndata0,
};
- ndata0.mii_addr = ioremap(CPHYSADDR(
- nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
+ ndata0.mii_addr = ioremap(CPHYSADDR
+ (nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
ndata0.cpu_mask = nlm_current_node()->coremask;
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] staging: netlogic
@ 2018-10-21 21:08 Ioannis Valasakis
2018-10-21 20:15 ` [PATCH 1/2] staging: netlogic: replace old kconfig with new syntax Ioannis Valasakis
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ioannis Valasakis @ 2018-10-21 21:08 UTC (permalink / raw)
To: outreachy-kernel
Ioannis Valasakis (2):
staging: netlogic: replace old kconfig with new syntax
staging: netlogic: Cleanup parenetheses
drivers/staging/netlogic/Kconfig | 2 +-
drivers/staging/netlogic/platform_net.c | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] staging: netlogic: Cleanup parenetheses
2018-10-21 20:15 ` [PATCH 2/2] staging: netlogic: Cleanup parenetheses Ioannis Valasakis
@ 2018-10-21 22:14 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2018-10-21 22:14 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: gregkh, outreachy-kernel
On Sun, 21 Oct 2018, Ioannis Valasakis wrote:
> Cleanup mismatching parentheses.
> Reported by checkpatch.
It doesn't look very nice to me with the function arguments alone on a
line like that. Maybe there are other places where newlines could be put.
julia
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/netlogic/platform_net.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index abf4c71ee66b..1b1a8a0c9b72 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -107,8 +107,8 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
> .dev.platform_data = &ndata1,
> };
>
> - gmac4_addr = ioremap(CPHYSADDR(
> - nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);
> + gmac5_addr = ioremap(CPHYSADDR
> + (nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);
> ndata1.serdes_addr = gmac4_addr;
> ndata1.pcs_addr = gmac4_addr;
> ndata1.mii_addr = gmac0_addr;
> @@ -134,8 +134,8 @@ static void xls_gmac_init(void)
> {
> int mac;
> struct platform_device *xlr_net_dev1;
> - void __iomem *gmac0_addr = ioremap(CPHYSADDR(
> - nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
> + void __iomem *gmac0_addr = ioremap(CPHYSADDR
> + (nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
>
> static struct xlr_net_data ndata0 = {
> .rfr_station = FMN_STNID_GMACRFR_0,
> @@ -153,8 +153,8 @@ static void xls_gmac_init(void)
> ndata0.mii_addr = gmac0_addr;
>
> /* Passing GPIO base for serdes init. Only needed on sgmii ports */
> - gpio_addr = ioremap(CPHYSADDR(
> - nlm_mmio_base(NETLOGIC_IO_GPIO_OFFSET)), 0xfff);
> + gpio_addr = ioremap(CPHYSADDR
> + (nlm_mmio_base(NETLOGIC_IO_GPIO_OFFSET)), 0xfff);
> ndata0.gpio_addr = gpio_addr;
> ndata0.cpu_mask = nlm_current_node()->coremask;
>
> @@ -214,8 +214,8 @@ static void xlr_gmac_init(void)
> .id = 0,
> .dev.platform_data = &ndata0,
> };
> - ndata0.mii_addr = ioremap(CPHYSADDR(
> - nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
> + ndata0.mii_addr = ioremap(CPHYSADDR
> + (nlm_mmio_base(NETLOGIC_IO_GMAC_0_OFFSET)), 0xfff);
>
> ndata0.cpu_mask = nlm_current_node()->coremask;
>
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/e7defe7da804d867532182a1fcb387a9f41f9482.1540152794.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: netlogic
2018-10-21 21:08 [PATCH 1/2] staging: netlogic Ioannis Valasakis
2018-10-21 20:15 ` [PATCH 1/2] staging: netlogic: replace old kconfig with new syntax Ioannis Valasakis
2018-10-21 20:15 ` [PATCH 2/2] staging: netlogic: Cleanup parenetheses Ioannis Valasakis
@ 2018-10-21 22:14 ` Julia Lawall
2 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2018-10-21 22:14 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel
It looks like this would be 0/2?
julia
On Sun, 21 Oct 2018, Ioannis Valasakis wrote:
> Ioannis Valasakis (2):
> staging: netlogic: replace old kconfig with new syntax
> staging: netlogic: Cleanup parenetheses
>
> drivers/staging/netlogic/Kconfig | 2 +-
> drivers/staging/netlogic/platform_net.c | 16 ++++++++--------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1540152794.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-21 22:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-21 21:08 [PATCH 1/2] staging: netlogic Ioannis Valasakis
2018-10-21 20:15 ` [PATCH 1/2] staging: netlogic: replace old kconfig with new syntax Ioannis Valasakis
2018-10-21 20:15 ` [PATCH 2/2] staging: netlogic: Cleanup parenetheses Ioannis Valasakis
2018-10-21 22:14 ` [Outreachy kernel] " Julia Lawall
2018-10-21 22:14 ` [Outreachy kernel] [PATCH 1/2] staging: netlogic Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.