[PATCH v3 0/5] staging: greybus Address minor styling issues

[PATCH v3 0/5] staging: greybus Address minor styling issues

[Ioannis Valasakis]

Changes to v3:
	- Pointer comparison to NULL is corrected

Ioannis Valasakis (5):
  staging: greybus Align parameters to parentheses
  staging: greybus Add a blank line after declaration
  staging: greybus Fix SPDX identifier
  staging: greybus Align arguments with parentheses
  staging: greybus Shorten comparison to NULL

 drivers/staging/greybus/control.h | 5 +++--
 drivers/staging/greybus/core.c    | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
2.19.1


-- 
ta
ioannis

[PATCH v3 1/5] staging: greybus Align parameters to parentheses

[Ioannis Valasakis]

Align parameters to the right side of the left parentheses
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index dafa430d176e..d28773e06838 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -28,7 +28,7 @@ int greybus_disabled(void)
 EXPORT_SYMBOL_GPL(greybus_disabled);
 
 static bool greybus_match_one_id(struct gb_bundle *bundle,
-				     const struct greybus_bundle_id *id)
+				 const struct greybus_bundle_id *id)
 {
 	if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
 	    (id->vendor != bundle->intf->vendor_id))
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
 static const struct greybus_bundle_id *
 greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
 {
-	if (id == NULL)
+	if (!id == NULL)
 		return NULL;
 
 	for (; id->vendor || id->product || id->class || id->driver_info;
@@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
 }
 
 int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
-		const char *mod_name)
+			    const char *mod_name)
 {
 	int retval;
 
-- 
2.19.1


-- 
ta
ioannis

Re: [Outreachy kernel] [PATCH v3 1/5] staging: greybus Align parameters to parentheses

[Sasha Levin]

On Fri, Nov 02, 2018 at 09:38:55PM +0000, Ioannis Valasakis wrote:
>@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
> static const struct greybus_bundle_id *
> greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
> {
>-	if (id == NULL)
>+	if (!id == NULL)
> 		return NULL;
>
> 	for (; id->vendor || id->product || id->class || id->driver_info;

This still looks broken.

--
Thanks,
Sasha

Re: [Outreachy kernel] [PATCH v3 1/5] staging: greybus Align parameters to parentheses

[Julia Lawall]

On Fri, 2 Nov 2018, Ioannis Valasakis wrote:

> Align parameters to the right side of the left parentheses
> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> index dafa430d176e..d28773e06838 100644
> --- a/drivers/staging/greybus/core.c
> +++ b/drivers/staging/greybus/core.c
> @@ -28,7 +28,7 @@ int greybus_disabled(void)
>  EXPORT_SYMBOL_GPL(greybus_disabled);
>
>  static bool greybus_match_one_id(struct gb_bundle *bundle,
> -				     const struct greybus_bundle_id *id)
> +				 const struct greybus_bundle_id *id)
>  {
>  	if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
>  	    (id->vendor != bundle->intf->vendor_id))
> @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
>  static const struct greybus_bundle_id *
>  greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
>  {
> -	if (id == NULL)
> +	if (!id == NULL)

This change is still wrong and is still not coveredby the log message.

I think it would be better to start over rather than trying to fix up this
series, because it is not progressing.

julia

>  		return NULL;
>
>  	for (; id->vendor || id->product || id->class || id->driver_info;
> @@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
>  }
>
>  int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
> -		const char *mod_name)
> +			    const char *mod_name)
>  {
>  	int retval;
>
> --
> 2.19.1
>
>
> --
> ta
> ioannis
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/537e6bd9f572df1cce6fc8624471a9c7c2714c35.1541194567.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>

[PATCH v3 2/5] staging: greybus Add a blank line after declaration

[Ioannis Valasakis]

Add a blank line after the struct declaration
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/control.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 643ddb9e0f92..9c453e0b1b33 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -24,6 +24,7 @@ struct gb_control {
 	char *vendor_string;
 	char *product_string;
 };
+
 #define to_gb_control(d) container_of(d, struct gb_control, dev)
 
 struct gb_control *gb_control_create(struct gb_interface *intf);
-- 
2.19.1


-- 
ta
ioannis

[PATCH v3 3/5] staging: greybus Fix SPDX identifier

[Ioannis Valasakis]

Fix the SPDX identifier as by replacing with standard C comment the
file
Reported by checkpatch

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/control.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 9c453e0b1b33..ebb7a2ee17dc 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus CPort control protocol
  *
-- 
2.19.1


-- 
ta
ioannis

[PATCH v3 4/5] staging: greybus Align arguments with parentheses

[Ioannis Valasakis]

Align arguments with the right side of the open left parentheses
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/control.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index ebb7a2ee17dc..5a45d55349a1 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
 int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
 int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
 int gb_control_disconnecting_operation(struct gb_control *control,
-					u16 cport_id);
+				       u16 cport_id);
 int gb_control_mode_switch_operation(struct gb_control *control);
 void gb_control_mode_switch_prepare(struct gb_control *control);
 void gb_control_mode_switch_complete(struct gb_control *control);
-- 
2.19.1


-- 
ta
ioannis

[PATCH v3 5/5] staging: greybus Shorten comparison to NULL

[Ioannis Valasakis]

Shorten pointer NULL check by simple truth test
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index d28773e06838..0ed3b0ffee5a 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
 static const struct greybus_bundle_id *
 greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
 {
-	if (!id == NULL)
+	if (id)
 		return NULL;
 
 	for (; id->vendor || id->product || id->class || id->driver_info;
-- 
2.19.1


-- 
ta
ioannis

Re: [Outreachy kernel] [PATCH v3 5/5] staging: greybus Shorten comparison to NULL

[Himanshu Jha]

On Fri, Nov 02, 2018 at 09:39:44PM +0000, Ioannis Valasakis wrote:
> Shorten pointer NULL check by simple truth test
> Reported by checkpatch.
> 
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> index d28773e06838..0ed3b0ffee5a 100644
> --- a/drivers/staging/greybus/core.c
> +++ b/drivers/staging/greybus/core.c
> @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
>  static const struct greybus_bundle_id *
>  greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
>  {
> -	if (!id == NULL)
> +	if (id)

I don't think the original code was `if (!id == NULL)`


-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

Re: [Outreachy kernel] [PATCH v3 5/5] staging: greybus Shorten comparison to NULL

[Julia Lawall]

On Sat, 3 Nov 2018, Himanshu Jha wrote:

> On Fri, Nov 02, 2018 at 09:39:44PM +0000, Ioannis Valasakis wrote:
> > Shorten pointer NULL check by simple truth test
> > Reported by checkpatch.
> >
> > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > ---
> >  drivers/staging/greybus/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> > index d28773e06838..0ed3b0ffee5a 100644
> > --- a/drivers/staging/greybus/core.c
> > +++ b/drivers/staging/greybus/core.c
> > @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
> >  static const struct greybus_bundle_id *
> >  greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
> >  {
> > -	if (!id == NULL)
> > +	if (id)
>
> I don't think the original code was `if (!id == NULL)`

As Himanshu says, you need to start with Greg's tree.  If you don't feel
that you have the git commands down to do that, then just destroy your
tree and start over.

julia