* [PATCH 01/14] staging: greybus Align parameters to parentheses
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
@ 2018-11-05 14:18 ` Ioannis Valasakis
2018-11-05 14:27 ` Greg KH
2018-11-05 14:18 ` [PATCH 02/14] staging: greybus Add a blank line after declaration Ioannis Valasakis
` (13 subsequent siblings)
14 siblings, 1 reply; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:18 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Align parameters to the right side of the left parentheses
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index dafa430d176e..d28773e06838 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -28,7 +28,7 @@ int greybus_disabled(void)
EXPORT_SYMBOL_GPL(greybus_disabled);
static bool greybus_match_one_id(struct gb_bundle *bundle,
- const struct greybus_bundle_id *id)
+ const struct greybus_bundle_id *id)
{
if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
(id->vendor != bundle->intf->vendor_id))
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
static const struct greybus_bundle_id *
greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
{
- if (id == NULL)
+ if (!id == NULL)
return NULL;
for (; id->vendor || id->product || id->class || id->driver_info;
@@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
}
int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
- const char *mod_name)
+ const char *mod_name)
{
int retval;
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 01/14] staging: greybus Align parameters to parentheses
2018-11-05 14:18 ` [PATCH 01/14] staging: greybus Align parameters to parentheses Ioannis Valasakis
@ 2018-11-05 14:27 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2018-11-05 14:27 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel
On Mon, Nov 05, 2018 at 02:18:28PM +0000, Ioannis Valasakis wrote:
> Align parameters to the right side of the left parentheses
> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
You forgot a ":" after "greybus" on most of the subject lines in this
patch series :(
Please fix up and resend the whole thing.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 02/14] staging: greybus Add a blank line after declaration
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
2018-11-05 14:18 ` [PATCH 01/14] staging: greybus Align parameters to parentheses Ioannis Valasakis
@ 2018-11-05 14:18 ` Ioannis Valasakis
2018-11-05 14:18 ` [PATCH 03/14] staging: greybus Fix SPDX identifier Ioannis Valasakis
` (12 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:18 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Add a blank line after the struct declaration
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/control.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 643ddb9e0f92..9c453e0b1b33 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -24,6 +24,7 @@ struct gb_control {
char *vendor_string;
char *product_string;
};
+
#define to_gb_control(d) container_of(d, struct gb_control, dev)
struct gb_control *gb_control_create(struct gb_interface *intf);
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 03/14] staging: greybus Fix SPDX identifier
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
2018-11-05 14:18 ` [PATCH 01/14] staging: greybus Align parameters to parentheses Ioannis Valasakis
2018-11-05 14:18 ` [PATCH 02/14] staging: greybus Add a blank line after declaration Ioannis Valasakis
@ 2018-11-05 14:18 ` Ioannis Valasakis
2018-11-05 14:19 ` [PATCH 04/14] staging: greybus Align arguments with parentheses Ioannis Valasakis
` (11 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:18 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Fix the SPDX identifier as by replacing with standard C comment the
file
Reported by checkpatch
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/control.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 9c453e0b1b33..ebb7a2ee17dc 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus CPort control protocol
*
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 04/14] staging: greybus Align arguments with parentheses
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (2 preceding siblings ...)
2018-11-05 14:18 ` [PATCH 03/14] staging: greybus Fix SPDX identifier Ioannis Valasakis
@ 2018-11-05 14:19 ` Ioannis Valasakis
2018-11-05 14:19 ` [PATCH 05/14] staging: greybus Shorten comparison to NULL Ioannis Valasakis
` (10 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Align arguments with the right side of the open left parentheses
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/control.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index ebb7a2ee17dc..5a45d55349a1 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
int gb_control_disconnecting_operation(struct gb_control *control,
- u16 cport_id);
+ u16 cport_id);
int gb_control_mode_switch_operation(struct gb_control *control);
void gb_control_mode_switch_prepare(struct gb_control *control);
void gb_control_mode_switch_complete(struct gb_control *control);
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 05/14] staging: greybus Shorten comparison to NULL
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (3 preceding siblings ...)
2018-11-05 14:19 ` [PATCH 04/14] staging: greybus Align arguments with parentheses Ioannis Valasakis
@ 2018-11-05 14:19 ` Ioannis Valasakis
2018-11-05 14:22 ` [Outreachy kernel] " Julia Lawall
2018-11-05 14:19 ` [PATCH 06/14] staging: greybus Correct SPDX License Identifier Ioannis Valasakis
` (9 subsequent siblings)
14 siblings, 1 reply; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Shorten pointer NULL check by simple truth test
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index d28773e06838..0ed3b0ffee5a 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
static const struct greybus_bundle_id *
greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
{
- if (!id == NULL)
+ if (id)
return NULL;
for (; id->vendor || id->product || id->class || id->driver_info;
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [Outreachy kernel] [PATCH 05/14] staging: greybus Shorten comparison to NULL
2018-11-05 14:19 ` [PATCH 05/14] staging: greybus Shorten comparison to NULL Ioannis Valasakis
@ 2018-11-05 14:22 ` Julia Lawall
0 siblings, 0 replies; 19+ messages in thread
From: Julia Lawall @ 2018-11-05 14:22 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel, gregkh
On Mon, 5 Nov 2018, Ioannis Valasakis wrote:
> Shorten pointer NULL check by simple truth test
> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> index d28773e06838..0ed3b0ffee5a 100644
> --- a/drivers/staging/greybus/core.c
> +++ b/drivers/staging/greybus/core.c
> @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
> static const struct greybus_bundle_id *
> greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
> {
> - if (!id == NULL)
> + if (id)
This is not the right starting point. It is on top of on of your
incorrect patches. Overall, I think you have done something wrong in
redoing this series.
julia
> return NULL;
>
> for (; id->vendor || id->product || id->class || id->driver_info;
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/abb81a5c17d259dcd043049d3d77b704a364b437.1541427415.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 06/14] staging: greybus Correct SPDX License Identifier
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (4 preceding siblings ...)
2018-11-05 14:19 ` [PATCH 05/14] staging: greybus Shorten comparison to NULL Ioannis Valasakis
@ 2018-11-05 14:19 ` Ioannis Valasakis
2018-11-05 14:19 ` [PATCH 07/14] staging: greybus Remove multiple blank lines Ioannis Valasakis
` (8 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Correct the SPDX License Identifier by using C style comments
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/arche_platform.h | 2 +-
drivers/staging/greybus/arpc.h | 2 +-
drivers/staging/greybus/audio_apbridgea.h | 2 +-
drivers/staging/greybus/audio_codec.h | 2 +-
drivers/staging/greybus/audio_manager.h | 2 +-
drivers/staging/greybus/audio_manager_private.h | 2 +-
drivers/staging/greybus/bundle.h | 2 +-
drivers/staging/greybus/connection.h | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/greybus/arche_platform.h b/drivers/staging/greybus/arche_platform.h
index 02056351d25a..9d997f2d6517 100644
--- a/drivers/staging/greybus/arche_platform.h
+++ b/drivers/staging/greybus/arche_platform.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Arche Platform driver to enable Unipro link.
*
diff --git a/drivers/staging/greybus/arpc.h b/drivers/staging/greybus/arpc.h
index 3534ba1a4e6c..3dab6375909c 100644
--- a/drivers/staging/greybus/arpc.h
+++ b/drivers/staging/greybus/arpc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
/*
* This file is provided under a dual BSD/GPLv2 license. When using or
* redistributing this file, you may do so under either license.
diff --git a/drivers/staging/greybus/audio_apbridgea.h b/drivers/staging/greybus/audio_apbridgea.h
index 42ac6059bfc7..330fc7a397eb 100644
--- a/drivers/staging/greybus/audio_apbridgea.h
+++ b/drivers/staging/greybus/audio_apbridgea.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: BSD-3-Clause
+/* SPDX-License-Identifier: BSD-3-Clause */
/**
* Copyright (c) 2015-2016 Google Inc.
* All rights reserved.
diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
index 4efd8b3ebe07..d36f8cd35e06 100644
--- a/drivers/staging/greybus/audio_codec.h
+++ b/drivers/staging/greybus/audio_codec.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus audio driver
* Copyright 2015 Google Inc.
diff --git a/drivers/staging/greybus/audio_manager.h b/drivers/staging/greybus/audio_manager.h
index dcb1a20f5ff1..be605485a8ce 100644
--- a/drivers/staging/greybus/audio_manager.h
+++ b/drivers/staging/greybus/audio_manager.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus operations
*
diff --git a/drivers/staging/greybus/audio_manager_private.h b/drivers/staging/greybus/audio_manager_private.h
index 9d9b58fc54c4..2b3a766c7de7 100644
--- a/drivers/staging/greybus/audio_manager_private.h
+++ b/drivers/staging/greybus/audio_manager_private.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus operations
*
diff --git a/drivers/staging/greybus/bundle.h b/drivers/staging/greybus/bundle.h
index ffcfd43802cc..8734d2055657 100644
--- a/drivers/staging/greybus/bundle.h
+++ b/drivers/staging/greybus/bundle.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus bundles
*
diff --git a/drivers/staging/greybus/connection.h b/drivers/staging/greybus/connection.h
index ec3f1d3ef3b9..8deeb1d5f008 100644
--- a/drivers/staging/greybus/connection.h
+++ b/drivers/staging/greybus/connection.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus connections
*
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 07/14] staging: greybus Remove multiple blank lines
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (5 preceding siblings ...)
2018-11-05 14:19 ` [PATCH 06/14] staging: greybus Correct SPDX License Identifier Ioannis Valasakis
@ 2018-11-05 14:19 ` Ioannis Valasakis
2018-11-05 14:19 ` [PATCH 08/14] staging: greybus Insert empty line after struct Ioannis Valasakis
` (7 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Remove continuous multiple blank lines
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/arche-apb-ctrl.c | 1 -
drivers/staging/greybus/connection.c | 4 ----
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
index cc8d6fc831b4..be5ffed90bcf 100644
--- a/drivers/staging/greybus/arche-apb-ctrl.c
+++ b/drivers/staging/greybus/arche-apb-ctrl.c
@@ -20,7 +20,6 @@
#include <linux/spinlock.h>
#include "arche_platform.h"
-
static void apb_bootret_deassert(struct device *dev);
struct arche_apb_ctrl_drvdata {
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 2103168b585e..56ae30533a70 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -11,17 +11,13 @@
#include "greybus.h"
#include "greybus_trace.h"
-
#define GB_CONNECTION_CPORT_QUIESCE_TIMEOUT 1000
-
static void gb_connection_kref_release(struct kref *kref);
-
static DEFINE_SPINLOCK(gb_connections_lock);
static DEFINE_MUTEX(gb_connection_mutex);
-
/* Caller holds gb_connection_mutex. */
static bool gb_connection_cport_in_use(struct gb_interface *intf, u16 cport_id)
{
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 08/14] staging: greybus Insert empty line after struct
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (6 preceding siblings ...)
2018-11-05 14:19 ` [PATCH 07/14] staging: greybus Remove multiple blank lines Ioannis Valasakis
@ 2018-11-05 14:19 ` Ioannis Valasakis
2018-11-05 14:19 ` [PATCH 09/14] staging: greybus Remove space before tab Ioannis Valasakis
` (6 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Insert empty line after struct definition
Reported by checkpatch
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/bundle.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/bundle.h b/drivers/staging/greybus/bundle.h
index 8734d2055657..4aaf7a0880fd 100644
--- a/drivers/staging/greybus/bundle.h
+++ b/drivers/staging/greybus/bundle.h
@@ -31,6 +31,7 @@ struct gb_bundle {
struct list_head links; /* interface->bundles */
};
+
#define to_gb_bundle(d) container_of(d, struct gb_bundle, dev)
/* Greybus "private" definitions" */
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 09/14] staging: greybus Remove space before tab
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (7 preceding siblings ...)
2018-11-05 14:19 ` [PATCH 08/14] staging: greybus Insert empty line after struct Ioannis Valasakis
@ 2018-11-05 14:19 ` Ioannis Valasakis
2018-11-05 14:20 ` [PATCH 10/14] staging: greybus: cleanup long line in gb_uart_probe() Ioannis Valasakis
` (5 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Remove extra space before a tab character
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 3313cb0b60af..b3bffe91ae99 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -805,8 +805,8 @@ static const struct tty_operations gb_ops = {
.tiocmget = gb_tty_tiocmget,
.tiocmset = gb_tty_tiocmset,
.get_icount = gb_tty_get_icount,
- .set_serial = set_serial_info,
- .get_serial = get_serial_info,
+ .set_serial = set_serial_info,
+ .get_serial = get_serial_info,
};
static const struct tty_port_operations gb_port_ops = {
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 10/14] staging: greybus: cleanup long line in gb_uart_probe()
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (8 preceding siblings ...)
2018-11-05 14:19 ` [PATCH 09/14] staging: greybus Remove space before tab Ioannis Valasakis
@ 2018-11-05 14:20 ` Ioannis Valasakis
2018-11-05 14:21 ` [Outreachy kernel] " Julia Lawall
2018-11-05 14:20 ` [PATCH 11/14] staging: greybus: remove multiple blank lines Ioannis Valasakis
` (4 subsequent siblings)
14 siblings, 1 reply; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Clear line over 80 characters warning in gb_uart_probe() by adding
appropriate lines breaks.
Reported by checkpatch
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index b3bffe91ae99..735f70c09823 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
if (!gb_tty)
return -ENOMEM;
- connection = gb_connection_create(gbphy_dev->bundle,
- le16_to_cpu(gbphy_dev->cport_desc->id),
+ connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
+ (gbphy_dev->cport_desc->id),
gb_uart_request_handler);
if (IS_ERR(connection)) {
retval = PTR_ERR(connection);
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [Outreachy kernel] [PATCH 10/14] staging: greybus: cleanup long line in gb_uart_probe()
2018-11-05 14:20 ` [PATCH 10/14] staging: greybus: cleanup long line in gb_uart_probe() Ioannis Valasakis
@ 2018-11-05 14:21 ` Julia Lawall
0 siblings, 0 replies; 19+ messages in thread
From: Julia Lawall @ 2018-11-05 14:21 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel, gregkh
On Mon, 5 Nov 2018, Ioannis Valasakis wrote:
> Clear line over 80 characters warning in gb_uart_probe() by adding
> appropriate lines breaks.
> Reported by checkpatch
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/uart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
> index b3bffe91ae99..735f70c09823 100644
> --- a/drivers/staging/greybus/uart.c
> +++ b/drivers/staging/greybus/uart.c
> @@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
> if (!gb_tty)
> return -ENOMEM;
>
> - connection = gb_connection_create(gbphy_dev->bundle,
> - le16_to_cpu(gbphy_dev->cport_desc->id),
> + connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
> + (gbphy_dev->cport_desc->id),
This is not a good way to make the change. Put le16_to_cpu in front of
its argument list and move the indentation back to some multiple of tabs
if needed.
julia
> gb_uart_request_handler);
> if (IS_ERR(connection)) {
> retval = PTR_ERR(connection);
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/7fe735d1e4a5d0497711c8a34c95184dfc3c9930.1541427415.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 11/14] staging: greybus: remove multiple blank lines
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (9 preceding siblings ...)
2018-11-05 14:20 ` [PATCH 10/14] staging: greybus: cleanup long line in gb_uart_probe() Ioannis Valasakis
@ 2018-11-05 14:20 ` Ioannis Valasakis
2018-11-05 14:20 ` [PATCH 12/14] staging: greybus: Add extra space around OR operator Ioannis Valasakis
` (3 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Remove extra blank lines to conform with the warning.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/greybus_protocols.h | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index 9bd7b6dfb476..f38f4a8db2b7 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -65,7 +65,6 @@
#define GB_CONTROL_BUNDLE_ID 0
#define GB_CONTROL_CPORT_ID 0
-
/*
* All operation messages (both requests and responses) begin with
* a header that encodes the size of the message (header included).
@@ -95,7 +94,6 @@ struct gb_operation_msg_hdr {
__u8 pad[2]; /* must be zero (ignore when read) */
} __packed;
-
/* Generic request types */
#define GB_REQUEST_TYPE_CPORT_SHUTDOWN 0x00
#define GB_REQUEST_TYPE_INVALID 0x7f
@@ -104,7 +102,6 @@ struct gb_cport_shutdown_request {
__u8 phase;
} __packed;
-
/* Control Protocol */
/* Greybus control request types */
@@ -249,7 +246,6 @@ struct gb_apb_request_cport_flags {
#define GB_APB_CPORT_FLAG_HIGH_PRIO 0x02
} __packed;
-
/* Firmware Download Protocol */
/* Request Types */
@@ -286,7 +282,6 @@ struct gb_fw_download_release_firmware_request {
} __packed;
/* firmware download release firmware response has no payload */
-
/* Firmware Management Protocol */
/* Request Types */
@@ -368,7 +363,6 @@ struct gb_fw_mgmt_backend_fw_updated_request {
} __packed;
/* firmware management backend firmware updated response has no payload */
-
/* Component Authentication Protocol (CAP) */
/* Request Types */
@@ -405,7 +399,6 @@ struct gb_cap_authenticate_response {
__u8 signature[0];
} __packed;
-
/* Bootrom Protocol */
/* Version of the Greybus bootrom protocol we support */
@@ -474,7 +467,6 @@ struct gb_bootrom_get_vid_pid_response {
__le32 product_id;
} __packed;
-
/* Power Supply */
/* Greybus power supply request types */
@@ -648,7 +640,6 @@ struct gb_power_supply_event_request {
#define GB_POWER_SUPPLY_UPDATE 0x01
} __packed;
-
/* HID */
/* Greybus HID operation types */
@@ -694,7 +685,6 @@ struct gb_hid_input_report_request {
__u8 report[0];
} __packed;
-
/* I2C */
/* Greybus i2c request types */
@@ -730,7 +720,6 @@ struct gb_i2c_transfer_response {
__u8 data[0]; /* inbound data */
} __packed;
-
/* GPIO */
/* Greybus GPIO request types */
@@ -829,7 +818,6 @@ struct gb_gpio_irq_event_request {
} __packed;
/* irq event has no response */
-
/* PWM */
/* Greybus PWM operation types */
@@ -1317,7 +1305,6 @@ struct gb_svc_intf_oops_request {
} __packed;
/* intf_oops response has no payload */
-
/* RAW */
/* Greybus raw request types */
@@ -1328,7 +1315,6 @@ struct gb_raw_send_request {
__u8 data[0];
} __packed;
-
/* UART */
/* Greybus UART operation types */
@@ -2204,7 +2190,6 @@ struct gb_audio_send_data_request {
__u8 data[0];
} __packed;
-
/* Log */
/* operations */
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 12/14] staging: greybus: Add extra space around OR operator
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (10 preceding siblings ...)
2018-11-05 14:20 ` [PATCH 11/14] staging: greybus: remove multiple blank lines Ioannis Valasakis
@ 2018-11-05 14:20 ` Ioannis Valasakis
2018-11-05 14:20 ` [PATCH 13/14] staging: greybus: remove extra space before tab Ioannis Valasakis
` (2 subsequent siblings)
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Add extra spaces around the OR operator.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/greybus_protocols.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index f38f4a8db2b7..5783f715bdc2 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -866,10 +866,10 @@ struct gb_pwm_disable_request {
/* Should match up with modes in linux/spi/spi.h */
#define GB_SPI_MODE_CPHA 0x01 /* clock phase */
#define GB_SPI_MODE_CPOL 0x02 /* clock polarity */
-#define GB_SPI_MODE_MODE_0 (0|0) /* (original MicroWire) */
-#define GB_SPI_MODE_MODE_1 (0|GB_SPI_MODE_CPHA)
-#define GB_SPI_MODE_MODE_2 (GB_SPI_MODE_CPOL|0)
-#define GB_SPI_MODE_MODE_3 (GB_SPI_MODE_CPOL|GB_SPI_MODE_CPHA)
+#define GB_SPI_MODE_MODE_0 (0 | 0) /* (original MicroWire) */
+#define GB_SPI_MODE_MODE_1 (0 | GB_SPI_MODE_CPHA)
+#define GB_SPI_MODE_MODE_2 (GB_SPI_MODE_CPOL | 0)
+#define GB_SPI_MODE_MODE_3 (GB_SPI_MODE_CPOL | GB_SPI_MODE_CPHA)
#define GB_SPI_MODE_CS_HIGH 0x04 /* chipselect active high? */
#define GB_SPI_MODE_LSB_FIRST 0x08 /* per-word bits-on-wire */
#define GB_SPI_MODE_3WIRE 0x10 /* SI/SO signals shared */
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 13/14] staging: greybus: remove extra space before tab
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (11 preceding siblings ...)
2018-11-05 14:20 ` [PATCH 12/14] staging: greybus: Add extra space around OR operator Ioannis Valasakis
@ 2018-11-05 14:20 ` Ioannis Valasakis
2018-11-05 14:20 ` [PATCH 14/14] staging: greybus: correct SPDX license identifiers Ioannis Valasakis
2018-11-05 14:28 ` [PATCH 00/14] staging: greybus: various code cleanups Greg KH
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Remove extra spaces before the tab character inside a comment section.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/greybus_protocols.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index 5783f715bdc2..429a952c5200 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -918,8 +918,8 @@ struct gb_spi_device_config_response {
* 0 the default (from @spi_device) is used.
* @len: size of rx and tx buffers (in bytes)
* @delay_usecs: microseconds to delay after this transfer before (optionally)
- * changing the chipselect status, then starting the next transfer or
- * completing this spi_message.
+ * changing the chipselect status, then starting the next transfer or
+ * completing this spi_message.
* @cs_change: affects chipselect after this transfer completes
* @bits_per_word: select a bits_per_word other than the device default for this
* transfer. If 0 the default (from @spi_device) is used.
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 14/14] staging: greybus: correct SPDX license identifiers
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (12 preceding siblings ...)
2018-11-05 14:20 ` [PATCH 13/14] staging: greybus: remove extra space before tab Ioannis Valasakis
@ 2018-11-05 14:20 ` Ioannis Valasakis
2018-11-05 14:28 ` [PATCH 00/14] staging: greybus: various code cleanups Greg KH
14 siblings, 0 replies; 19+ messages in thread
From: Ioannis Valasakis @ 2018-11-05 14:20 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Correct the SPDX License Identifiers by replacing the comment to C-style
comment.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/firmware.h | 2 +-
drivers/staging/greybus/gb-camera.h | 2 +-
drivers/staging/greybus/gbphy.h | 2 +-
drivers/staging/greybus/greybus.h | 2 +-
drivers/staging/greybus/greybus_authentication.h | 2 +-
drivers/staging/greybus/greybus_firmware.h | 2 +-
drivers/staging/greybus/greybus_manifest.h | 2 +-
drivers/staging/greybus/greybus_protocols.h | 2 +-
drivers/staging/greybus/greybus_trace.h | 2 +-
drivers/staging/greybus/hd.h | 2 +-
drivers/staging/greybus/interface.h | 2 +-
drivers/staging/greybus/manifest.h | 2 +-
drivers/staging/greybus/module.h | 2 +-
drivers/staging/greybus/operation.h | 2 +-
drivers/staging/greybus/spilib.h | 2 +-
drivers/staging/greybus/svc.h | 2 +-
16 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h
index 946221307ef6..72dfabfa4704 100644
--- a/drivers/staging/greybus/firmware.h
+++ b/drivers/staging/greybus/firmware.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus Firmware Management Header
*
diff --git a/drivers/staging/greybus/gb-camera.h b/drivers/staging/greybus/gb-camera.h
index ee293e461fc3..5fc469101fc1 100644
--- a/drivers/staging/greybus/gb-camera.h
+++ b/drivers/staging/greybus/gb-camera.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus Camera protocol driver.
*
diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
index 99463489d7d6..087928a586fb 100644
--- a/drivers/staging/greybus/gbphy.h
+++ b/drivers/staging/greybus/gbphy.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus Bridged-Phy Bus driver
*
diff --git a/drivers/staging/greybus/greybus.h b/drivers/staging/greybus/greybus.h
index d03ddb7c9df0..f0488ffff93e 100644
--- a/drivers/staging/greybus/greybus.h
+++ b/drivers/staging/greybus/greybus.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus driver and device API
*
diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
index 03ea9615b217..d654760cf175 100644
--- a/drivers/staging/greybus/greybus_authentication.h
+++ b/drivers/staging/greybus/greybus_authentication.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
/*
* Greybus Component Authentication User Header
*
diff --git a/drivers/staging/greybus/greybus_firmware.h b/drivers/staging/greybus/greybus_firmware.h
index b58281a63ba4..13ef3aa5279e 100644
--- a/drivers/staging/greybus/greybus_firmware.h
+++ b/drivers/staging/greybus/greybus_firmware.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
/*
* Greybus Firmware Management User Header
*
diff --git a/drivers/staging/greybus/greybus_manifest.h b/drivers/staging/greybus/greybus_manifest.h
index 2cec5cf7a846..db68f7e7d5a7 100644
--- a/drivers/staging/greybus/greybus_manifest.h
+++ b/drivers/staging/greybus/greybus_manifest.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus manifest definition
*
diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index 429a952c5200..ee3bbdfa1477 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
/*
* This file is provided under a dual BSD/GPLv2 license. When using or
* redistributing this file, you may do so under either license.
diff --git a/drivers/staging/greybus/greybus_trace.h b/drivers/staging/greybus/greybus_trace.h
index 7b5e2c6b1f6b..1bc9f1275c65 100644
--- a/drivers/staging/greybus/greybus_trace.h
+++ b/drivers/staging/greybus/greybus_trace.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus driver and device API
*
diff --git a/drivers/staging/greybus/hd.h b/drivers/staging/greybus/hd.h
index 6cf024a20a58..348b76fabc9a 100644
--- a/drivers/staging/greybus/hd.h
+++ b/drivers/staging/greybus/hd.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus Host Device
*
diff --git a/drivers/staging/greybus/interface.h b/drivers/staging/greybus/interface.h
index 1c00c5bb3ec9..8fb1eacda302 100644
--- a/drivers/staging/greybus/interface.h
+++ b/drivers/staging/greybus/interface.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus Interface Block code
*
diff --git a/drivers/staging/greybus/manifest.h b/drivers/staging/greybus/manifest.h
index f3c95a255631..88aa7e44cad5 100644
--- a/drivers/staging/greybus/manifest.h
+++ b/drivers/staging/greybus/manifest.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus manifest parsing
*
diff --git a/drivers/staging/greybus/module.h b/drivers/staging/greybus/module.h
index b1ebcc6636db..2a27e520ee94 100644
--- a/drivers/staging/greybus/module.h
+++ b/drivers/staging/greybus/module.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus Module code
*
diff --git a/drivers/staging/greybus/operation.h b/drivers/staging/greybus/operation.h
index 40b7b02fff88..17ba3daf111b 100644
--- a/drivers/staging/greybus/operation.h
+++ b/drivers/staging/greybus/operation.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus operations
*
diff --git a/drivers/staging/greybus/spilib.h b/drivers/staging/greybus/spilib.h
index 043d4d32c3ee..9d416839e3be 100644
--- a/drivers/staging/greybus/spilib.h
+++ b/drivers/staging/greybus/spilib.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus SPI library header
*
diff --git a/drivers/staging/greybus/svc.h b/drivers/staging/greybus/svc.h
index ad01783bac9c..e7452057cfe4 100644
--- a/drivers/staging/greybus/svc.h
+++ b/drivers/staging/greybus/svc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus SVC code
*
--
2.19.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 00/14] staging: greybus: various code cleanups
2018-11-05 14:18 [PATCH 00/14] staging: greybus: various code cleanups Ioannis Valasakis
` (13 preceding siblings ...)
2018-11-05 14:20 ` [PATCH 14/14] staging: greybus: correct SPDX license identifiers Ioannis Valasakis
@ 2018-11-05 14:28 ` Greg KH
14 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2018-11-05 14:28 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel
On Mon, Nov 05, 2018 at 02:18:12PM +0000, Ioannis Valasakis wrote:
> staging: greybus: Various code cleanups reported by checkpatch.
>
> Ioannis Valasakis (14):
> staging: greybus Align parameters to parentheses
> staging: greybus Add a blank line after declaration
> staging: greybus Fix SPDX identifier
> staging: greybus Align arguments with parentheses
> staging: greybus Shorten comparison to NULL
> staging: greybus Correct SPDX License Identifier
> staging: greybus Remove multiple blank lines
> staging: greybus Insert empty line after struct
> staging: greybus Remove space before tab
> staging: greybus: cleanup long line in gb_uart_probe()
> staging: greybus: remove multiple blank lines
> staging: greybus: Add extra space around OR operator
> staging: greybus: remove extra space before tab
> staging: greybus: correct SPDX license identifiers
You can see the missed ":" very easily here. It's a good check to
verify that you got the text correct to look at this output.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread